fix(oauth): send an expired session back through sign-in from the connect page

Author: waleedlatif1

apps/sim/app/oauth/connect/connect-confirmation.tsx

@@ -2,6 +2,7 @@
 
 import { useState } from 'react'
 import { AuthIdentity, AuthButton as Chip } from '@sim/auth-ui'
+import { isApiClientError } from '@/lib/api/client/errors'
 import { requestJson } from '@/lib/api/client/request'
 import { startCredentialConnectionContract } from '@/lib/api/contracts/credentials'
 import { DesktopHandoffShell } from '@/app/desktop/components/desktop-handoff-shell'
@@ -43,6 +44,12 @@ export function ConnectConfirmation({
       if (callbackURL) launch.searchParams.set('callbackURL', callbackURL)
       window.location.assign(launch.toString())
     } catch (error) {
+      if (isApiClientError(error) && error.status === 401) {
+        // The session ended after this page rendered: sign in again, then return here.
+        const here = `${window.location.pathname}${window.location.search}`
+        window.location.assign(`/login?callbackUrl=${encodeURIComponent(here)}`)
+        return
+      }
       setErrorMessage(error instanceof Error ? error.message : null)
       setStatus('error')
     }

apps/sim/lib/credentials/application/connection-target.ts

@@ -21,7 +21,7 @@ export interface ResolvedCredentialConnectionTarget {
   displayName?: string
 }
 
-export class CredentialConnectionProviderMismatchError extends OrchestrationError {
+class CredentialConnectionProviderMismatchError extends OrchestrationError {
   constructor() {
     super('validation', 'Credential provider does not match the requested OAuth provider')
     this.name = 'CredentialConnectionProviderMismatchError'

scripts/check-test-types.baseline.json

@@ -26,8 +26,7 @@
     "TS2739": 2
   },
   "apps/sim/app/api/auth/oauth2/authorize/route.test.ts": {
-    "TS2345": 2,
-    "TS2554": 1
+    "TS2345": 2
   },
   "apps/sim/app/api/auth/oauth2/callback/quickbooks/route.test.ts": {
     "TS2554": 3