fix(executor): dedupe replay attachments on user turns only and type the run-read fixture

Author: waleedlatif1

.claude/rules/sim-content-delivery.md

@@ -30,8 +30,8 @@ the workflow executor see byte-identical results.
 
 A run Chat starts executes as Chat's principal, so `executeWorkflowCore` runs every execution under
 `runWorkflowOutsideContentDelivery`, where that principal reads like any other. What the run returns
-is gated where Chat started it: run execute/resume withhold unadmitted inline file bytes
-(`withholdUnadmittedInlineFiles`); Chat's run tools return no file bytes.
+is gated where Chat started it: run execute/resume keep inline file bytes only for admitted files
+(`withholdUnadmittedInlineFiles`), and Chat's in-app run tools strip `base64` from their result.
 
 ## The pieces
 

.cursor/rules/sim-content-delivery.mdc

@@ -21,8 +21,8 @@ the workflow executor see byte-identical results.
 
 A run Chat starts executes as Chat's principal, so `executeWorkflowCore` runs every execution under
 `runWorkflowOutsideContentDelivery`, where that principal reads like any other. What the run returns
-is gated where Chat started it: run execute/resume withhold unadmitted inline file bytes
-(`withholdUnadmittedInlineFiles`); Chat's run tools return no file bytes.
+is gated where Chat started it: run execute/resume keep inline file bytes only for admitted files
+(`withholdUnadmittedInlineFiles`), and Chat's in-app run tools strip `base64` from their result.
 
 ## The pieces
 

apps/sim/executor/handlers/agent/handler.test.ts

@@ -780,6 +780,29 @@ describe('AgentBlockHandler', () => {
       expect(userTurns.map((message) => message.files?.length)).toEqual([1, 1, undefined])
       hydrate.mockRestore()
     })
+
+    it('keeps a user turn’s file when only an earlier assistant turn carried it', async () => {
+      mockGetProviderFromModel.mockReturnValue('openai')
+      const hydrate = hydrateWithBytes()
+      queueTableRows(schemaMock.memory, [
+        {
+          secretProvenanceVersion: null,
+          data: [
+            { role: 'assistant', content: 'Here is a file', files: [file] },
+            { role: 'user', content: 'Read it', files: [file] },
+          ],
+        },
+      ])
+      await handler.execute({ ...mockContext, executionId: 'exec-3' }, mockBlock, {
+        model: 'gpt-4o',
+        memoryType: 'conversation',
+        conversationId: 'conversation-1',
+        messages: [{ role: 'user', content: 'And now?' }],
+      })
+      const sent = mockExecuteProviderRequest.mock.calls.at(-1)?.[1].messages as Message[]
+      expect(sent.find((message) => message.content === 'Read it')?.files).toHaveLength(1)
+      hydrate.mockRestore()
+    })
   })
 
   describe('model fallback', () => {

apps/sim/executor/handlers/agent/memory.ts

@@ -119,14 +119,16 @@ function isOptionalMemoryStorageFailure(error: unknown): boolean {
 }
 
 /**
- * The attachments each message sends to the model. A storage key pins its bytes, so a file attached
- * on several turns is sent once, where it first appears, keeping the replayed prefix stable across
- * runs; a message with no text keeps its own so it is never sent empty.
+ * The attachments each message sends to the model. A storage key pins its bytes, so a file a user
+ * attached on several turns is sent once, where it first appears, keeping the replayed prefix
+ * stable across runs; a user turn with no text keeps its own so it is never sent empty. Only user
+ * turns are deduplicated: every provider sends their attachments, while some drop other roles'.
  */
 export function selectReplayAttachments(messages: readonly Message[]): UserFile[][] {
   const sent = new Set<string>()
   return messages.map((message) => {
     const files = message.files ?? []
+    if (message.role !== 'user') return files
     const unsent = files.filter((file) => {
       const identity = file.key || file.id
       if (sent.has(identity)) return false

apps/sim/lib/workspace-files/delivery.integration.ts

@@ -41,6 +41,7 @@ import { hydrateUserFilesWithBase64 } from '@/lib/uploads/utils/user-file-base64
 import { downloadWorkspaceFileStream } from '@/lib/workspace-files/application/download-workspace-file'
 import { readWorkspaceInlineFile } from '@/lib/workspace-files/application/read-workspace-inline-file'
 import { createFileReadReceipt, recheckFileReadReceipt } from '@/lib/workspace-files/read-receipt'
+import type { UserFile } from '@/executor/types'
 
 const uploadRoot = mkdtempSync(join(tmpdir(), 'sim-delivery-test-'))
 setUploadDirServer(uploadRoot)
@@ -315,7 +316,7 @@ describe('A workflow run Chat started reads workspace files as any run does', ()
     if (provenance === 'unknown') {
       await markWorkspaceFileSecretProvenanceUnknown(f.workspaceId, [uploaded.id])
     }
-    const file = {
+    const file: UserFile = {
       id: uploaded.id,
       name: uploaded.name,
       url: uploaded.url,