fix(mothership): answer a chat for an unreachable workspace with 404, as the workspace routes do

Author: waleedlatif1

apps/sim/lib/mothership/chat/post.ts

@@ -72,7 +72,11 @@ import { CopilotTransport } from '@/lib/mothership/generated/trace-attribute-val
 import { TraceAttr } from '@/lib/mothership/generated/trace-attributes-v1'
 import { TraceSpan } from '@/lib/mothership/generated/trace-spans-v1'
 import { resolveMothershipModelSettings } from '@/lib/mothership/model-options'
-import { createBadRequestResponse, createUnauthorizedResponse } from '@/lib/mothership/request/http'
+import {
+  createBadRequestResponse,
+  createNotFoundResponse,
+  createUnauthorizedResponse,
+} from '@/lib/mothership/request/http'
 import { durableResourceAuthoringVersion } from '@/lib/mothership/request/lifecycle/recovery-config'
 import { createSSEStream, SSE_RESPONSE_HEADERS } from '@/lib/mothership/request/lifecycle/start'
 import { startCopilotOtelRoot, withCopilotSpan } from '@/lib/mothership/request/otel'
@@ -643,7 +647,7 @@ async function resolveBranch(params: {
   )
 
   if (workspacePermission === null) {
-    return createBadRequestResponse('Workspace not found or access denied')
+    return createNotFoundResponse('Workspace not found or access denied')
   }
 
   return {

apps/sim/scripts/test-browser-extension-e2e.ts

@@ -2334,11 +2334,8 @@ try {
         await composer.fill('QA scoped follow-up')
         await composer.press('Enter')
         const refusal = (await followUp).status()
-        // The chat route answers a workspace the sender cannot reach with 400, before any run.
-        assert(
-          refusal === 400 || refusal === 403 || refusal === 404,
-          `The follow-up was answered ${refusal}`
-        )
+        // A workspace the sender cannot reach is not found to them, answered before any run.
+        assert.equal(refusal, 404, `The follow-up was answered ${refusal}`)
         // Refused, not re-scoped: no run under the organization, and the chat keeps its workspace.
         assert.deepEqual(await runs(), [{ workspaceId: scopedWorkspaceId, organizationId: null }])
         const [chat] = await sql<{ workspaceId: string | null; organizationId: string | null }[]>`