fix(logs): keep a unique request id per webhook poll and per emitted event

Executions started by one poll tick, or by one parent request, would otherwise share a request id, and tool code that keys idempotency on it (deployments) could replay one execution's result in another. The logger now owns requestId on the line, so these ids no longer need to match the request to correlate.

Author: waleedlatif1

apps/sim/lib/webhooks/polling/orchestrator.ts

@@ -1,6 +1,6 @@
 import { createLogger } from '@sim/logger'
+import { generateShortId } from '@sim/utils/id'
 import { withResourceOutboundScope } from '@/lib/core/network/resource-scope.server'
-import { generateRequestId } from '@/lib/core/utils/request'
 import { findRecentlyRefusedWorkspaces } from '@/lib/webhooks/polling/admission-refusals'
 import { getPollingHandler } from '@/lib/webhooks/polling/registry'
 import type { PollSummary } from '@/lib/webhooks/polling/types'
@@ -47,12 +47,11 @@ export async function pollProvider(providerName: string): Promise<PollSummary> {
         return 'skipped'
       }
 
-      // Polls share the tick's request id; the webhook id tells concurrent polls apart.
       return withResourceOutboundScope({ workspaceId: entry.workflow.workspaceId }, () =>
         handler.pollWebhook({
           webhookData: entry.webhook,
           workflowData: entry.workflow,
-          requestId: generateRequestId(),
+          requestId: generateShortId(),
           logger: logger.withMetadata({ webhookId: entry.webhook.id }),
         })
       )

apps/sim/lib/workspace-events/emitter.ts

@@ -1,6 +1,6 @@
 import { createLogger } from '@sim/logger'
 import { getActiveWorkflowContext } from '@sim/platform-authz/workflow'
-import { generateRequestId } from '@/lib/core/utils/request'
+import { generateShortId } from '@sim/utils/id'
 import type { WorkflowExecutionLog } from '@/lib/logs/types'
 import {
   isSimRuleEventType,
@@ -46,7 +46,7 @@ export async function dispatchSimEvent(
   subscription: SimSubscription,
   payload: SimEventPayload
 ): Promise<void> {
-  const requestId = generateRequestId()
+  const requestId = generateShortId()
   try {
     const { processPolledWebhookEvent } = await import('@/lib/webhooks/processor')
     const result = await processPolledWebhookEvent(