fix(dashboards): cap dashboard folders and reject folder name collisions

Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01S6aTRnkiu7PxYZPNPXYEMV

Author: TheodoreSpeaks

apps/sim/app/workspace/[workspaceId]/dashboards/dashboard-dialog.tsx

@@ -75,6 +75,14 @@ export function DashboardDialog({
     if (!row) return false
     return row.id === ancestorId || (row.parentId !== null && isWithin(row.parentId, ancestorId))
   }
+  const folderNameTaken =
+    (state.kind === 'createFolder' || state.kind === 'editFolder') &&
+    folders.some(
+      (folder) =>
+        ('folder' in state ? folder.id !== state.folder.id : true) &&
+        (folder.parentId ?? '') === target &&
+        folder.name === name.trim()
+    )
   function save() {
     const callbacks = {
       onSuccess: (result: Awaited<ReturnType<typeof mutation.mutateAsync>>) => {
@@ -136,7 +144,13 @@ export function DashboardDialog({
           </p>
         ) : (
           <>
-            <ChipModalField type='input' title='Name' value={name} onChange={setName} />
+            <ChipModalField
+              type='input'
+              title='Name'
+              value={name}
+              onChange={setName}
+              error={folderNameTaken ? 'A folder with this name already exists here' : undefined}
+            />
             {(state.kind === 'edit' || state.kind === 'editFolder') && (
               <ChipModalField
                 type='dropdown'
@@ -166,7 +180,7 @@ export function DashboardDialog({
         primaryAction={{
           label: deleting ? 'Delete' : 'Save',
           variant: deleting ? 'destructive' : 'primary',
-          disabled: mutation.isPending || (!deleting && !name.trim()),
+          disabled: mutation.isPending || (!deleting && (!name.trim() || folderNameTaken)),
           onClick: save,
         }}
       />

apps/sim/lib/dashboards/application/dashboards.ts

@@ -4,7 +4,7 @@ import { OrchestrationError } from '@/lib/core/orchestration/types'
 import { dashboardOperations } from '@/lib/dashboards/application/operations'
 import { requireDashboardsEnabled } from '@/lib/dashboards/feature-flag'
 import { DASHBOARD_CONTENT_TYPE, dashboardDisplayName } from '@/lib/dashboards/resource'
-import { parseDashboardSpec } from '@/lib/dashboards/spec'
+import { MAX_DASHBOARD_SOURCE_BYTES, parseDashboardSpec } from '@/lib/dashboards/spec'
 import { notifyWorkspaceFilesChanged } from '@/lib/realtime/notify'
 import {
   ContentVersionConflictError,
@@ -109,7 +109,7 @@ export const readDashboard = defineAuthorizedWorkspaceFileUseCase({
   authorizeResource: ({ context }) => requireDashboardsEnabled(context.workspaceOrganizationId),
   async execute({ context }) {
     const file = await requireDashboardFile(context.workspaceId, context.fileId)
-    const content = await fetchWorkspaceFileBuffer(file, { maxBytes: 128 * 1024 })
+    const content = await fetchWorkspaceFileBuffer(file, { maxBytes: MAX_DASHBOARD_SOURCE_BYTES })
     return { dashboard: dashboardRecord(file), content: content.toString('utf-8') }
   },
 })

apps/sim/lib/dashboards/application/folders.ts

@@ -4,12 +4,13 @@ import { OrchestrationError } from '@/lib/core/orchestration/types'
 import { dashboardWorkspace } from '@/lib/dashboards/application/dashboards'
 import { dashboardOperations } from '@/lib/dashboards/application/operations'
 import { requireDashboardsEnabled } from '@/lib/dashboards/feature-flag'
+import { MAX_FOLDERS_PER_WORKSPACE } from '@/lib/folders/constants'
 import {
   createFolderAtPathTransition,
   deleteFolderByPathTransition,
   relocateFolderByPathTransition,
 } from '@/lib/folders/orchestration'
-import { listFoldersForWorkspace, toFolderApi } from '@/lib/folders/queries'
+import { listActiveFolderRows, toFolderApi } from '@/lib/folders/queries'
 import { notifyWorkspaceFilesChanged } from '@/lib/realtime/notify'
 import { defineAuthorizedWorkspaceFileUseCase } from '@/lib/workspace-files/application/authorized-workspace-file-use-case'
 
@@ -24,8 +25,10 @@ export const listDashboardFolders = defineAuthorizedWorkspaceFileUseCase({
     dashboardWorkspace(input.workspaceId),
   authorizeResource: ({ context }) => requireDashboardsEnabled(context.workspaceOrganizationId),
   async execute({ context }) {
-    const folders = await listFoldersForWorkspace(context.workspaceId, 'active', 'dashboard')
-    return { folders }
+    const rows = await listActiveFolderRows(context.workspaceId, 'dashboard', {
+      maxRows: MAX_FOLDERS_PER_WORKSPACE,
+    })
+    return { folders: rows.map(toFolderApi) }
   },
 })
 
@@ -39,6 +42,7 @@ export const createDashboardFolder = defineAuthorizedWorkspaceFileUseCase({
       resourceType: 'dashboard',
       userId: requirePrincipalSubjectUserId(principal),
       path: input.path,
+      maxFolderRows: MAX_FOLDERS_PER_WORKSPACE,
       effects: false,
       throwInfrastructure: true,
     })
@@ -71,6 +75,7 @@ export const moveDashboardFolder = defineAuthorizedWorkspaceFileUseCase({
       userId: requirePrincipalSubjectUserId(principal),
       path: input.path,
       destinationPath: input.destinationPath,
+      maxFolderRows: MAX_FOLDERS_PER_WORKSPACE,
       effects: false,
       throwInfrastructure: true,
     })
@@ -102,6 +107,7 @@ export const deleteDashboardFolder = defineAuthorizedWorkspaceFileUseCase({
       userId: requirePrincipalSubjectUserId(principal),
       path: input.path,
       recursive: true,
+      maxFolderRows: MAX_FOLDERS_PER_WORKSPACE,
       effects: false,
       throwInfrastructure: true,
     })