fix(queries): give optimistic rows collision-free ids

generateTempId used Date.now(), so two rows created in the same millisecond
shared an id and the first server response overwrote both — leaving one row
duplicated and the other's real id lost until a refetch. Now uses generateId(),
matching what the workflow mutations already do. Reachable by double-clicking
create, or by any scripted or bulk create.

Also documents the contract of fetchOAuthConnections, which reports an unknown
connection state as disconnected. No consumer reads that field today — both
read names and icons, and connection state comes from useWorkspaceCredentials —
so letting the query reject would blank the suggested-action rows and drop the
credential page to raw provider ids. The note is what stops a future consumer
branching on it silently.

Author: waleedlatif1

apps/sim/hooks/queries/oauth/oauth-connections.ts

@@ -56,6 +56,18 @@ function defineServices(): ServiceInfo[] {
   return servicesList
 }
 
+/**
+ * Resolves the service catalog merged with the caller's connections.
+ *
+ * A failed request resolves with the bare catalog rather than rejecting, so
+ * consumers keep correct service names and ids when the merge data is
+ * unavailable. The cost is that `isConnected`/`accounts` then report *unknown*
+ * as *disconnected*, which the result cannot distinguish. Read connection
+ * state from the workspace credentials query (`useWorkspaceCredentials`), which
+ * surfaces its own errors; a consumer that must branch on `isConnected` here
+ * needs this fallback removed first, or it will tell a connected user they are
+ * not.
+ */
 async function fetchOAuthConnections(signal?: AbortSignal): Promise<ServiceInfo[]> {
   try {
     const serviceDefinitions = defineServices()

apps/sim/hooks/queries/utils/optimistic-mutation.test.ts

@@ -0,0 +1,24 @@
+/**
+ * @vitest-environment node
+ */
+import { afterEach, describe, expect, it, vi } from 'vitest'
+import { generateTempId } from '@/hooks/queries/utils/optimistic-mutation'
+
+describe('generateTempId', () => {
+  afterEach(() => {
+    vi.useRealTimers()
+  })
+
+  it('is unique for ids created within the same millisecond', () => {
+    vi.useFakeTimers()
+    vi.setSystemTime(new Date('2026-01-01T00:00:00.000Z'))
+
+    const ids = new Set(Array.from({ length: 100 }, () => generateTempId('temp-folder')))
+
+    expect(ids.size).toBe(100)
+  })
+
+  it('keeps the prefix so callers can identify optimistic rows', () => {
+    expect(generateTempId('temp-folder').startsWith('temp-folder-')).toBe(true)
+  })
+})

apps/sim/hooks/queries/utils/optimistic-mutation.ts

@@ -1,4 +1,5 @@
 import { createLogger } from '@sim/logger'
+import { generateId } from '@sim/utils/id'
 import type { QueryClient } from '@tanstack/react-query'
 
 const logger = createLogger('OptimisticMutation')
@@ -72,6 +73,12 @@ export function createOptimisticMutationHandlers<TData, TVariables, TItem>(
   }
 }
 
+/**
+ * Placeholder id for an optimistic row, held only until the server response
+ * replaces it. Uses `generateId()` rather than a timestamp so two rows created
+ * in the same millisecond cannot collide — a collision would make
+ * `replaceOptimisticEntry` overwrite both entries with one server row.
+ */
 export function generateTempId(prefix: string): string {
-  return `${prefix}-${Date.now()}`
+  return `${prefix}-${generateId()}`
 }