fix(people): keep the publish refresh on cold status reads and fail the SCIM status read from load

Author: waleedlatif1

apps/sim/hooks/queries/people-sync.ts

@@ -37,7 +37,7 @@ export function isDirectorySyncAccessError(error: unknown) {
 
 function refreshPublishedPeople(client: QueryClient, organizationId: string, result: SyncResult) {
   const previous = client.getQueryData<SyncResult>(syncKeys.organization(organizationId))
-  if (previous && (previous.sync?.lastSuccessAt ?? null) !== (result.sync?.lastSuccessAt ?? null)) {
+  if ((previous?.sync?.lastSuccessAt ?? null) !== (result.sync?.lastSuccessAt ?? null)) {
     return client.invalidateQueries({ queryKey: peopleKeys.organization(organizationId) })
   }
 }

apps/sim/scripts/test-scim-e2e.ts

@@ -535,13 +535,13 @@ async function run() {
             .addCookies([
               { name: 'better-auth.session_token', value: primary.cookie, url: baseUrl.origin },
             ])
-          await page.goto(
-            new URL(`/o/${primary.orgId}/people?focus=${aliceMemberId}`, baseUrl).href
-          )
           const statusUrl = new URL(syncPath, baseUrl).href
           await page.route(statusUrl, (route) =>
             route.fulfill({ status: 503, json: { error: 'Unavailable' } })
           )
+          await page.goto(
+            new URL(`/o/${primary.orgId}/people?focus=${aliceMemberId}`, baseUrl).href
+          )
           const openSync = page.getByRole('button', { name: 'Directory sync', exact: true })
           await openSync.click()
           await page.getByRole('heading', { name: 'Directory sync', level: 1 }).waitFor()