refactor(dashboards): drop file discovery for a content-type exclusion

With one dashboard per workspace, the listed/unlisted discovery column, its
migration, legacy-writer trigger, and the upload backfill script are no longer
needed. File listings, search, and workflow file pickers exclude the dashboard
content type instead, and the one-dashboard index is now migration 0392.

Author: TheodoreSpeaks

apps/sim/app/api/files/uploads/finalizers.ts

@@ -22,7 +22,6 @@ import {
 import { getWorkspaceFileSize, type StorageContext } from '@/lib/uploads/shared/types'
 import { UploadSessionError, type UploadSessionRecord } from '@/lib/uploads/upload-session/service'
 import { readWorkspaceFileUploadProvenance } from '@/lib/uploads/upload-session/workspace-file-provenance'
-import { defaultFileDiscovery } from '@/lib/workspace-files/discovery'
 import { toV2File } from '@/app/api/v2/files/utils'
 
 export interface UploadActor {
@@ -377,7 +376,6 @@ async function insertOrLoadFileMetadata(
       userId: input.userId,
       workspaceId: input.workspaceId,
       context: input.context,
-      discovery: defaultFileDiscovery(input.context),
       originalName: input.originalName,
       displayName: input.originalName,
       contentType: input.contentType,

apps/sim/ee/workspace-forking/application/content-outbox.ts

@@ -1,5 +1,5 @@
 import { db } from '@sim/db'
-import { fileDiscoveryEnum, workspaceOperationReceipt } from '@sim/db/schema'
+import { workspaceOperationReceipt } from '@sim/db/schema'
 import { and, eq } from 'drizzle-orm'
 import { z } from 'zod'
 import { OrchestrationError } from '@/lib/core/orchestration/types'
@@ -107,7 +107,6 @@ const contentPayloadSchema = z
                   'logs',
                   'workspace-logos',
                 ]),
-                discovery: z.enum(fileDiscoveryEnum.enumValues).optional(),
                 fileName: z.string().max(4096),
                 contentType: z.string().max(1024),
                 size: z.number().min(0),

apps/sim/ee/workspace-forking/lib/copy/copy-files.ts

@@ -22,7 +22,6 @@ import {
 } from '@/lib/uploads/core/storage-service'
 import { getWorkspaceFileSize, type StorageContext } from '@/lib/uploads/shared/types'
 import { MAX_FILE_SIZE } from '@/lib/uploads/utils/validation'
-import type { FileDiscovery } from '@/lib/workspace-files/discovery'
 import { activeWorkspaceFileConditions } from '@/lib/workspace-files/query-scope'
 import { resolveForkFolderMapping } from '@/ee/workspace-forking/lib/copy/copy-workflows'
 import {
@@ -50,8 +49,6 @@ function isMarkdownBlob(task: Pick<BlobCopyTask, 'contentType' | 'fileName'>): b
 export interface BlobCopyTask {
   /** Added after persisted fork jobs shipped; absence marks only copied-file provenance unknown. */
   sourceFileId?: string
-  /** Jobs queued before discovery existed contain only listed workspace files. */
-  discovery?: FileDiscovery
   /** Added after persisted fork jobs shipped; absence marks only copied-file provenance unknown. */
   sourceContentUpdatedAtMs?: number
   sourceKey: string
@@ -238,7 +235,6 @@ export async function planForkFileCopies(params: {
       sourceKey: meta.key,
       targetKey,
       context: meta.context as StorageContext,
-      discovery: meta.discovery,
       fileName: meta.originalName,
       contentType: meta.contentType,
       size: getWorkspaceFileSize(meta),
@@ -373,7 +369,6 @@ export async function executeForkFileBlobCopies(
               workspaceId: task.workspaceId,
               folderId: task.targetFolderId ?? null,
               context: task.context,
-              discovery: task.discovery ?? 'listed',
               chatId: null,
               originalName: targetOriginalName,
               displayName: targetDisplayName,
@@ -422,7 +417,6 @@ export async function executeForkFileBlobCopies(
                 userId: task.userId,
                 folderId: task.targetFolderId ?? null,
                 context: task.context,
-                discovery: task.discovery ?? 'listed',
                 chatId: null,
                 originalName: targetOriginalName,
                 displayName: targetDisplayName,

apps/sim/lib/dashboards/README.md

@@ -1,6 +1,6 @@
 # Table-backed dashboards
 
-Each workspace has at most one dashboard, a separate resource with its own sidebar page, resource tab, and Mothership `dashboards get` / `dashboards set` commands. Sim builds it: the page shows an empty state until the first save, and there is no create, rename, move, or folder operation. A partial unique index (migration 0393) keeps one live dashboard per workspace; lifting the limit means dropping it. Storage reuses workspace files with MIME type `text/x-sim-dashboard`; the backing `.dashboard` suffix is hidden from display names. The built-in **create-dashboard** skill documents the syntax without example dashboards or prescribed layouts. Sharing is deferred.
+Each workspace has at most one dashboard, a separate resource with its own sidebar page, resource tab, and Mothership `dashboards get` / `dashboards set` commands. Sim builds it: the page shows an empty state until the first save, and there is no create, rename, move, or folder operation. A partial unique index (migration 0392) keeps one live dashboard per workspace; lifting the limit means dropping it. Storage reuses workspace files with MIME type `text/x-sim-dashboard`; the backing `.dashboard` suffix is hidden from display names. The built-in **create-dashboard** skill documents the syntax without example dashboards or prescribed layouts. Sharing is deferred.
 
 The implementation has three boundaries:
 
@@ -78,19 +78,10 @@ before enabling the flag. Sharing and a tool for capturing the user's displayed
 data are deferred.
 
 
-## File discovery
+## Storage
 
-`workspace_files.discovery` separates listing/search membership (`listed` or `unlisted`)
-from storage and ownership (`context`). Files listings, Mothership file discovery, resource
-pickers, and content search apply this rule in SQL before pagination. Explicit-reference
-reads retain their existing authorization; unlisted is not a permission boundary.
-
-The workspace dashboard is an unlisted workspace file at the root. Only the dashboard use case
-may write its content type, and the resource picker requests it separately from Files.
-Versions, billing, cleanup, and complete workspace copies still include unlisted resources.
-
-Migration 0392 adds the defaulted discovery column and a temporary bridge for old upload
-writers during rollout. Script migration 0028 backfills non-workspace uploads in id-keyed
-pages of 1,000, including archived uploads, without changing content revisions or ownership.
-It contains no dashboard backfill: dashboards have not shipped. Remove the bridge in a
-later migration after all discovery-aware writers are deployed.
+The workspace dashboard is a workspace file at the root with content type
+`text/x-sim-dashboard`. Files listings, file search, and workflow file pickers exclude that
+content type, and only the dashboard use case may write it, so the backing file never appears
+or changes as an ordinary file. Versions, billing, cleanup, and complete workspace copies
+still include it.

apps/sim/lib/dashboards/application/dashboards.ts

@@ -46,7 +46,6 @@ export function dashboardRecord(file: WorkspaceFileRecord) {
 /** The unique index guarantees at most one live dashboard per workspace. */
 async function findWorkspaceDashboard(workspaceId: string): Promise<WorkspaceFileRecord | null> {
   const { files } = await queryWorkspaceFiles(workspaceId, {
-    discovery: 'unlisted',
     contentType: DASHBOARD_CONTENT_TYPE,
     sortBy: 'name',
     sortOrder: 'asc',
@@ -105,7 +104,6 @@ export const saveWorkspaceDashboard = defineAuthorizedWorkspaceFileUseCase({
           {
             dashboard: true,
             exactName: true,
-            discovery: 'unlisted',
             secretProvenance: EXACT_EMPTY_WORKSPACE_FILE_SECRET_PROVENANCE,
             notifyWorkspaceChange: false,
           }

apps/sim/lib/folders/config.ts

@@ -8,14 +8,13 @@ import {
   workflowSchedule,
   workspaceFiles,
 } from '@sim/db/schema'
-import { and, eq, type SQL } from 'drizzle-orm'
+import { eq, type SQL } from 'drizzle-orm'
 import type { PgColumn, PgTable } from 'drizzle-orm/pg-core'
 import type { FolderResourceType } from '@/lib/api/contracts/folders'
 import {
   FOLDER_RESOURCE_LABELS,
   FOLDER_RESOURCE_SUPPORTS_LOCKING,
 } from '@/lib/folders/resource-traits'
-import { fileDiscoveryCondition } from '@/lib/workspace-files/discovery'
 
 /**
  * Counts of cascaded resources returned by a folder delete/restore, keyed per resource
@@ -511,7 +510,7 @@ export const FOLDER_RESOURCES: Record<FolderResourceType, FolderResourceConfig>
      * `workspace_files` also stores copilot/chat/execution artifacts and profile pictures;
      * only files surfaced on the Files page live in folders.
      */
-    scope: and(eq(workspaceFiles.context, 'workspace'), fileDiscoveryCondition()),
+    scope: eq(workspaceFiles.context, 'workspace'),
   },
   knowledge_base: {
     resourceType: 'knowledge_base',

apps/sim/lib/uploads/contexts/workspace/workspace-file-manager.ts

@@ -1,5 +1,4 @@
 import { DASHBOARD_CONTENT_TYPE } from '@/lib/dashboards/resource'
-import { type FileDiscovery, fileDiscoveryCondition } from '@/lib/workspace-files/discovery'
 /**
  * Workspace file storage system
  * Files uploaded at workspace level persist indefinitely and are accessible across all workflows
@@ -103,6 +102,7 @@ import { getWorkspaceFileSize, MAX_WORKSPACE_FILE_SIZE } from '@/lib/uploads/sha
 import { isMarkdownFile } from '@/lib/uploads/utils/file-utils'
 import type { ServableFile } from '@/lib/uploads/utils/file-utils.server'
 import { SIM_PAGE_CONTENT_TYPE } from '@/lib/workspace-files/page-compile'
+import { workspaceFileContentTypeCondition } from '@/lib/workspace-files/query-scope'
 import {
   MAX_SIM_PAGE_UPLOAD_SNIFF_BYTES,
   restoreSimPageSourceBuffer,
@@ -207,7 +207,6 @@ export interface ActiveWorkspaceContext {
 }
 
 interface ListWorkspaceFilesOptions {
-  discovery?: FileDiscovery
   contentType?: string
 
   scope?: WorkspaceFileScope
@@ -277,7 +276,6 @@ const MAX_NUMBERED_COPY_SUFFIX = 20
 const MAX_UPLOAD_UNIQUE_RETRIES = 8
 
 interface WorkspaceFileMetadataInsert {
-  discovery?: FileDiscovery
   id: string
   key: string
   userId: string
@@ -444,7 +442,6 @@ export async function uploadWorkspaceFile(
     folderId?: string | null
     folderPath?: string
     exactName?: boolean
-    discovery?: FileDiscovery
     /** Only the workspace dashboard use case writes dashboard content; it lives at the root. */
     dashboard?: true
     secretProvenance?: WorkspaceFileSecretProvenance
@@ -554,7 +551,6 @@ export async function uploadWorkspaceFile(
             originalName: uniqueName,
             contentType: effectiveContentType,
             size: effectiveBuffer.length,
-            discovery: options?.discovery ?? 'listed',
           })
           if (!inserted) {
             throw new FileConflictError(uniqueName)
@@ -1067,7 +1063,6 @@ export async function trackChatUpload(
               chatId,
               messageId: messageId ?? null,
               context: 'mothership',
-              discovery: 'unlisted',
               displayName: candidate,
             })
             .where(
@@ -1115,7 +1110,6 @@ export async function trackChatUpload(
             userId,
             workspaceId,
             context: 'mothership',
-            discovery: 'unlisted',
             chatId,
             messageId: messageId ?? null,
             originalName: fileName,
@@ -1400,8 +1394,7 @@ export async function listWorkspaceFiles(
       .where(
         and(
           workspaceFileScopeCondition(workspaceId, scope),
-          fileDiscoveryCondition(options?.discovery),
-          options?.contentType ? eq(workspaceFiles.contentType, options.contentType) : undefined
+          workspaceFileContentTypeCondition(options?.contentType)
         )
       )
       .orderBy(workspaceFiles.uploadedAt)
@@ -1437,7 +1430,6 @@ const WORKSPACE_FILE_SORTS = {
 } satisfies Record<V2FileSortBy, readonly KeysetKey<WorkspaceFileRecord>[]>
 
 export interface QueryWorkspaceFilesOptions {
-  discovery?: FileDiscovery
   contentType?: string
 
   scope?: WorkspaceFileScope
@@ -1529,8 +1521,7 @@ export async function queryWorkspaceFiles(
 
   const conditions = [
     workspaceFileScopeCondition(workspaceId, scope),
-    fileDiscoveryCondition(options.discovery),
-    options.contentType ? eq(workspaceFiles.contentType, options.contentType) : undefined,
+    workspaceFileContentTypeCondition(options.contentType),
     workspaceFileFolderCondition(folderId),
     workspaceFileFolderScopeCondition(folderScope),
     searchFilter(workspaceFiles.originalName, search),

apps/sim/lib/uploads/server/metadata.ts

@@ -10,7 +10,6 @@ import {
   type StorageContext,
 } from '@/lib/uploads/shared/types'
 import { inferContextFromKey } from '@/lib/uploads/utils/file-utils'
-import { defaultFileDiscovery } from '@/lib/workspace-files/discovery'
 
 const logger = createLogger('FileMetadata')
 
@@ -158,10 +157,6 @@ async function insertFileMetadataWithExecutor(
         organizationId: organizationId || null,
         folderId: folderId ?? null,
         context,
-        discovery:
-          existingDeleted.context === context
-            ? existingDeleted.discovery
-            : defaultFileDiscovery(context),
         originalName,
         displayName: originalName,
         contentType,
@@ -193,7 +188,6 @@ async function insertFileMetadataWithExecutor(
         organizationId: organizationId || null,
         folderId: folderId ?? null,
         context,
-        discovery: defaultFileDiscovery(context),
         originalName,
         displayName: originalName,
         contentType,
@@ -250,7 +244,6 @@ async function insertImmutableFileMetadataWithExecutor(
       organizationId: organizationId || null,
       folderId: folderId ?? null,
       context,
-      discovery: defaultFileDiscovery(context),
       originalName,
       displayName: originalName,
       contentType,
@@ -333,7 +326,6 @@ export async function insertFileMetadataMany(
         organizationId: row.organizationId || null,
         folderId: row.folderId ?? null,
         context: row.context,
-        discovery: defaultFileDiscovery(row.context),
         originalName: row.originalName,
         displayName: row.originalName,
         contentType: row.contentType,

apps/sim/lib/workflows/references/resources.ts

@@ -24,8 +24,10 @@ import { MAX_FOLDERS_PER_WORKSPACE } from '@/lib/folders/constants'
 import { parseFolderPath, ROOT_FOLDER_PATH } from '@/lib/folders/paths'
 import { loadActiveFolderPathIndex } from '@/lib/folders/queries'
 import type { ForkMcpServerMeta, ForkRemapKind } from '@/lib/workflows/references/remap-references'
-import { fileDiscoveryCondition } from '@/lib/workspace-files/discovery'
-import { activeWorkspaceFileConditions } from '@/lib/workspace-files/query-scope'
+import {
+  activeWorkspaceFileConditions,
+  workspaceFileContentTypeCondition,
+} from '@/lib/workspace-files/query-scope'
 
 export interface ForkResourceCandidate {
   id: string
@@ -241,7 +243,7 @@ const fileCandidatesQuery = (executor: DbOrTx, workspaceId: string, keys?: strin
     .where(
       and(
         ...activeWorkspaceFileConditions([workspaceId]),
-        keys ? undefined : fileDiscoveryCondition(),
+        keys ? undefined : workspaceFileContentTypeCondition(),
         keys ? inArray(workspaceFiles.key, keys) : undefined
       )
     )
@@ -302,7 +304,7 @@ const fileCandidatesWithFolderQuery = (
     .where(
       and(
         ...activeWorkspaceFileConditions([workspaceId]),
-        keys ? undefined : fileDiscoveryCondition(),
+        keys ? undefined : workspaceFileContentTypeCondition(),
         page?.after ? gt(workspaceFiles.id, page.after) : undefined,
         keys ? inArray(workspaceFiles.key, keys) : undefined
       )