fix(release): keep Firecrawl news/image search results, run pinned async versions on their own variables

Author: waleedlatif1

apps/docs/content/docs/integrations/firecrawl.mdx

@@ -156,14 +156,20 @@ Search for information on the web using Firecrawl
 | --------- | ---- | ----------- |
 | `data` | array | Search results data with scraped content and metadata |
 |   ↳ `title` | string | Search result title from search engine |
-|   ↳ `description` | string | Search result description/snippet from search engine |
+|   ↳ `description` | string | Search result description/snippet from search engine; web results only |
 |   ↳ `url` | string | URL of the search result |
+|   ↳ `snippet` | string | News result snippet; news results only |
+|   ↳ `date` | string | News publication date; news results only |
+|   ↳ `imageUrl` | string | Image URL; image results, and news results that carry one |
+|   ↳ `imageWidth` | number | Image width in pixels; image results only |
+|   ↳ `imageHeight` | number | Image height in pixels; image results only |
+|   ↳ `position` | number | Rank within its source; news and image results only |
 |   ↳ `markdown` | string | Page content in markdown; returned only when scraping was requested via the hidden scrapeOptions input |
 |   ↳ `html` | string | Processed HTML content; returned only when "html" is among the scrape formats requested via the hidden scrapeOptions input |
 |   ↳ `rawHtml` | string | Unprocessed raw HTML; returned only when "rawHtml" is among the scrape formats requested via the hidden scrapeOptions input |
 |   ↳ `links` | array | Links found on the page; returned only when "links" is among the scrape formats requested via the hidden scrapeOptions input |
 |   ↳ `screenshot` | string | Screenshot URL \(expires after 24 hours\); returned only when "screenshot" is among the scrape formats requested via the hidden scrapeOptions input |
-|   ↳ `metadata` | object | Metadata about the search result page |
+|   ↳ `metadata` | object | Metadata about the search result page; web and news results only |
 |     ↳ `title` | string | Page title |
 |     ↳ `description` | string | Page meta description |
 |     ↳ `sourceURL` | string | Original source URL |

apps/sim/app/api/cli/auth/poll/route.ts

@@ -3,6 +3,7 @@ import { type NextRequest, NextResponse } from 'next/server'
 import { pollCliAuthContract } from '@/lib/api/contracts'
 import { parseRequest } from '@/lib/api/server'
 import {
+  apiKeyCreationErrorStatus,
   performCreatePersonalApiKey,
   performCreateWorkspaceApiKey,
 } from '@/lib/api-key/orchestration'
@@ -83,7 +84,7 @@ async function mintForGrant(
   if (!result.success || !result.key) {
     return {
       ok: false,
-      status: result.errorCode === 'conflict' ? 409 : 500,
+      status: apiKeyCreationErrorStatus(result.errorCode),
       message: result.error ?? 'Failed to generate API key',
     }
   }

apps/sim/background/workflow-execution.ts

@@ -286,7 +286,8 @@ export async function executeWorkflowJob(
         /**
          * The version this run executes, loaded once: the core runs this same version's
          * blocks, so a deploy landing mid-setup cannot pair one version's variables with
-         * another's graph.
+         * another's graph. A pinned version runs with only its own snapshot, as a sync run
+         * of it does, never the editor's current variables.
          */
         const pinnedDeploymentVersionId = payload.pinnedDeploymentVersionId
         const deployedState = await withDatabaseReadRetry(
@@ -328,7 +329,9 @@ export async function executeWorkflowJob(
           metadata,
           workflow,
           payload.input,
-          resolveDeployedRunVariables(deployedState, workflow.variables),
+          pinnedDeploymentVersionId
+            ? (deployedState.variables ?? {})
+            : resolveDeployedRunVariables(deployedState, workflow.variables),
           []
         )
 

apps/sim/lib/integrations/credential-display.ts

@@ -22,6 +22,7 @@ import { CANONICAL_SERVICE_ACCOUNT_SLUGS } from '@/lib/integrations/oauth-servic
 import { OAUTH_PROVIDERS } from '@/lib/oauth/oauth'
 import type { OAuthProvider, OAuthServiceConfig } from '@/lib/oauth/types'
 import { getServiceConfigByProviderId, parseProvider } from '@/lib/oauth/utils'
+import { resolveAccessControlBlockType } from '@/lib/permission-groups/integration-allowlist'
 
 /**
  * Above this many covered integrations the subtitle states a count instead of
@@ -226,7 +227,7 @@ export function resolveCredentialDisplay(credential: DisplayableCredential): Cre
     return {
       service: null,
       integration,
-      blockType: 'gitlab',
+      blockType: resolveAccessControlBlockType('gitlab'),
       icon: GitlabIcon,
       familyName: null,
       coveredIntegrations: integration ? [integration] : [],

apps/sim/tools/firecrawl/search.test.ts

@@ -21,6 +21,25 @@ describe('Firecrawl v2 search results', () => {
     expect(result.output.creditsUsed).toBe(2)
   })
 
+  it('keeps news and image results when those sources were requested', async () => {
+    if (!searchTool.transformResponse) throw new Error('Missing response transform')
+    const result = await searchTool.transformResponse(
+      jsonResponse({
+        success: true,
+        data: {
+          news: [{ url: 'https://news.example.com', title: 'Story', snippet: 'A news result' }],
+          images: [{ url: 'https://example.com/page', imageUrl: 'https://example.com/a.png' }],
+        },
+        creditsUsed: 2,
+      })
+    )
+
+    expect(result.output.data).toEqual([
+      { url: 'https://news.example.com', title: 'Story', snippet: 'A news result' },
+      { url: 'https://example.com/page', imageUrl: 'https://example.com/a.png' },
+    ])
+  })
+
   it('returns an empty result array when the provider finds no web results', async () => {
     if (!searchTool.transformResponse) throw new Error('Missing response transform')
     const result = await searchTool.transformResponse(

apps/sim/tools/firecrawl/search.ts

@@ -76,15 +76,18 @@ export const searchTool: ToolConfig<SearchParams, SearchResponse> = {
   },
 
   transformResponse: async (response: Response) => {
+    type SearchResults = SearchResponse['output']['data']
     const data: {
-      data?: { web?: SearchResponse['output']['data'] }
+      data?: { web?: SearchResults; news?: SearchResults; images?: SearchResults }
       creditsUsed?: number
     } = await response.json()
+    const results = data.data ?? {}
 
     return {
       success: true,
       output: {
-        data: data.data?.web ?? [],
+        // v2 groups results by the requested `sources`; one list keeps every source's results.
+        data: [...(results.web ?? []), ...(results.news ?? []), ...(results.images ?? [])],
         creditsUsed: data.creditsUsed,
       },
     }

apps/sim/tools/firecrawl/types.ts

@@ -120,7 +120,8 @@ export const SEARCH_METADATA_OUTPUT_PROPERTIES = {
  */
 export const SEARCH_METADATA_OUTPUT: OutputProperty = {
   type: 'object',
-  description: 'Metadata about the search result page',
+  description: 'Metadata about the search result page; web and news results only',
+  optional: true,
   properties: SEARCH_METADATA_OUTPUT_PROPERTIES,
 }
 
@@ -154,9 +155,36 @@ export const SEARCH_RESULT_OUTPUT_PROPERTIES = {
   title: { type: 'string', description: 'Search result title from search engine' },
   description: {
     type: 'string',
-    description: 'Search result description/snippet from search engine',
+    description: 'Search result description/snippet from search engine; web results only',
+    optional: true,
   },
   url: { type: 'string', description: 'URL of the search result' },
+  snippet: {
+    type: 'string',
+    description: 'News result snippet; news results only',
+    optional: true,
+  },
+  date: { type: 'string', description: 'News publication date; news results only', optional: true },
+  imageUrl: {
+    type: 'string',
+    description: 'Image URL; image results, and news results that carry one',
+    optional: true,
+  },
+  imageWidth: {
+    type: 'number',
+    description: 'Image width in pixels; image results only',
+    optional: true,
+  },
+  imageHeight: {
+    type: 'number',
+    description: 'Image height in pixels; image results only',
+    optional: true,
+  },
+  position: {
+    type: 'number',
+    description: 'Rank within its source; news and image results only',
+    optional: true,
+  },
   markdown: {
     type: 'string',
     description:
@@ -372,16 +400,23 @@ export interface ScrapeResponse extends ToolResponse {
 
 export interface SearchResponse extends ToolResponse {
   output: {
+    /** Web, then news, then image results; each source fills only its own fields. */
     data: Array<{
-      title: string
-      description: string
+      title?: string
+      description?: string
       url: string
+      snippet?: string
+      date?: string
+      imageUrl?: string
+      imageWidth?: number
+      imageHeight?: number
+      position?: number
       markdown?: string
       html?: string
       rawHtml?: string
       links?: string[]
       screenshot?: string
-      metadata: {
+      metadata?: {
         title?: string
         description?: string
         sourceURL: string

apps/sim/tools/generated/tool-outputs.ts

@@ -47,8 +47,9 @@ COPY --chown=pii:pii --chmod=755 docker/pii-entrypoint.sh ./
 # copies the image's /tmp into a bind volume mounted at a VOLUME path. The
 # VOLUME line stays below the model download, which stages wheels in /tmp.
 # tldextract (pulled in by Presidio) caches the Public Suffix List under
-# $HOME/.cache by default; point it at /tmp so it caches instead of
-# refetching the list on every start.
+# $HOME/.cache by default, which the read-only root cannot write; point it at
+# the writable /tmp volume. That volume is per task, so each task fetches the
+# list once.
 ENV PYTHONDONTWRITEBYTECODE=1 \
     TLDEXTRACT_CACHE=/tmp/tldextract
 RUN chmod 1777 /tmp