Skip to content

Commit 33bf328

Browse files
committed
fix(platform): give the live skill page Emir's heading, field and delete copy
The live skill page described a new skill as an import prompt, a built-in one as Built-in skill, used legacy's placeholders and naming hint, and confirmed a delete with its own copy. It reads as his resource details page: the skill's description under its name (none for a new one), his placeholders, and his delete confirmation. A read-only skill's field still says why it cannot be edited.
1 parent 97a72b1 commit 33bf328

2 files changed

Lines changed: 7 additions & 23 deletions

File tree

  • apps/sim

‎apps/sim/app/(product)/o/[organizationId]/integrations/_components/skill-details/skill-details.tsx‎

Lines changed: 6 additions & 16 deletions
Original file line numberDiff line numberDiff line change
@@ -28,12 +28,8 @@ import {
2828
type ParsedSkill,
2929
parseSkillMarkdown,
3030
readSkillFile,
31-
SKILL_CONTENT_PLACEHOLDER,
3231
SKILL_DESCRIPTION_MAX_LENGTH,
33-
SKILL_DESCRIPTION_PLACEHOLDER,
3432
SKILL_IMPORT_ACCEPT,
35-
SKILL_NAME_HINT,
36-
SKILL_NAME_PLACEHOLDER,
3733
type SkillDefinition,
3834
useCreateSkill,
3935
useDeleteSkill,
@@ -219,8 +215,8 @@ export function SkillDetails({
219215
<TextField
220216
label='Name'
221217
name='name'
222-
placeholder={SKILL_NAME_PLACEHOLDER}
223-
hint={lockReason ?? SKILL_NAME_HINT}
218+
placeholder='Skill name'
219+
hint={lockReason}
224220
error={errors.name}
225221
value={draft.name}
226222
onChange={(value) => edit('name', value)}
@@ -231,7 +227,7 @@ export function SkillDetails({
231227
<TextAreaField
232228
label='Description'
233229
name='description'
234-
placeholder={SKILL_DESCRIPTION_PLACEHOLDER}
230+
placeholder='Describe what this is for'
235231
error={errors.description}
236232
value={draft.description}
237233
onChange={(value) => edit('description', value)}
@@ -242,7 +238,7 @@ export function SkillDetails({
242238
<TextAreaField
243239
label='Instructions'
244240
name='content'
245-
placeholder={SKILL_CONTENT_PLACEHOLDER}
241+
placeholder='Describe what this skill should do'
246242
defaultSize='large'
247243
error={errors.content}
248244
value={draft.content}
@@ -259,13 +255,7 @@ export function SkillDetails({
259255
{back}
260256
<DirectoryHeading
261257
title={skill?.name ?? 'Create skill'}
262-
description={
263-
skill
264-
? builtin
265-
? 'Built-in skill'
266-
: skill.description
267-
: 'Write a skill, or import an existing SKILL.md'
268-
}
258+
description={skill?.description}
269259
leading={<Icon name='I044' />}
270260
/>
271261
<form
@@ -353,7 +343,7 @@ export function SkillDetails({
353343
<Modal
354344
open
355345
title={`Delete ${skill.name}?`}
356-
description='This action cannot be undone.'
346+
description='This removes it from your integrations.'
357347
variant='confirm'
358348
confirmLabel='Delete skill'
359349
destructive

‎apps/sim/platform/lib/data/skills/index.ts‎

Lines changed: 1 addition & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -6,13 +6,7 @@ export {
66
SKILL_IMPORT_ACCEPT,
77
validateSkillName,
88
} from '@/lib/skills/authoring'
9-
export {
10-
SKILL_CONTENT_PLACEHOLDER,
11-
SKILL_DESCRIPTION_MAX_LENGTH,
12-
SKILL_DESCRIPTION_PLACEHOLDER,
13-
SKILL_NAME_HINT,
14-
SKILL_NAME_PLACEHOLDER,
15-
} from '@/lib/skills/copy'
9+
export { SKILL_DESCRIPTION_MAX_LENGTH } from '@/lib/skills/copy'
1610
export {
1711
type SkillDefinition,
1812
useCreateSkill,

0 commit comments

Comments
 (0)