Skip to content

Commit 2733686

Browse files
committed
test(org): name the SSO provider field exactly
A substring match also caught the popup's own 'Select or enter a provider ID' input while it closed. The two names are distinct, so nothing in the product shares a name.
1 parent 886a0cf commit 2733686

1 file changed

Lines changed: 5 additions & 5 deletions

File tree

‎apps/sim/scripts/org-redesign-e2e/checks/settings.ts‎

Lines changed: 5 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -598,13 +598,13 @@ export async function settingsChecks() {
598598
page.getByText(/Enter a valid issuer URL|Issuer URL must/).first()
599599
).toBeVisible()
600600
assert.equal(bodies.length, 0, 'An invalid form reached the server')
601-
await page.getByRole('combobox', { name: 'Provider ID' }).click()
601+
const providerId = page.getByRole('combobox', { name: 'Provider ID', exact: true })
602+
await providerId.click()
602603
await page.getByRole('combobox', { name: 'Select or enter a provider ID' }).fill('e2e-oidc')
603604
await page.keyboard.press('Escape')
604-
await expect(
605-
page.getByRole('combobox', { name: 'Provider ID' }),
606-
'Closing the popup cleared the typed provider ID'
607-
).toContainText('e2e-oidc')
605+
await expect(providerId, 'Closing the popup cleared the typed provider ID').toContainText(
606+
'e2e-oidc'
607+
)
608608
await issuer.fill('https://idp.org-redesign.test')
609609
await page.getByRole('textbox', { name: 'Domain', exact: true }).fill('org-redesign.test')
610610
await page.getByRole('textbox', { name: 'Client ID', exact: true }).fill('e2e-client')

0 commit comments

Comments
 (0)