test(org): a member's agent chat is not found, as it is today

Author: waleedlatif1

apps/sim/scripts/test-org-redesign-e2e.ts

@@ -430,21 +430,32 @@ async function landingChecks() {
       ).toBeVisible()
     })
   })
-  await check('an agent chat redirects a member to Search and renders for an admin', async () => {
-    await withSession(MEMBER, async ({ page }) => {
-      await page.goto(url(`${root}/chat/${MEMBER_CHATS.agent.id}`))
-      await expect(page).toHaveURL((address) => address.pathname === `${root}/search`)
-      await page.goto(url(`${root}/search/chat/${MEMBER_CHATS.agent.id}`))
-      await expect(page).toHaveURL((address) => address.pathname === `${root}/search`)
-    })
-    await withSession(ADMIN, async ({ page }) => {
-      await page.goto(url(`${root}/search/chat/${ADMIN_CHATS.agent.id}`))
-      await expect(page).toHaveURL(url(`${root}/chat/${ADMIN_CHATS.agent.id}`))
-      await expect(
-        page.getByText(`Here is what I found about ${ADMIN_CHATS.agent.title}.`)
-      ).toBeVisible()
-    })
-  })
+  await check(
+    'an agent chat is not found for a member, stays out of their rail, and renders for an admin',
+    async () => {
+      await withSession(MEMBER, async ({ page }) => {
+        await page.goto(url(`${root}/chat/${MEMBER_CHATS.agent.id}`))
+        await expectPageNotFound(page)
+        await page.goto(url(`${root}/search/chat/${MEMBER_CHATS.agent.id}`))
+        await expectPageNotFound(page)
+        await page.goto(url(`${root}/home`))
+        await expect(
+          sidebar(page).getByRole('link', { name: MEMBER_CHATS.unread.title })
+        ).toBeVisible()
+        await expect(
+          sidebar(page).getByRole('link', { name: MEMBER_CHATS.agent.title })
+        ).toHaveCount(0)
+      })
+      await withSession(ADMIN, async ({ page }) => {
+        await page.goto(url(`${root}/search/chat/${ADMIN_CHATS.agent.id}`))
+        await expect(page).toHaveURL(url(`${root}/chat/${ADMIN_CHATS.agent.id}`))
+        await expect(
+          page.getByText(`Here is what I found about ${ADMIN_CHATS.agent.title}.`)
+        ).toBeVisible()
+      })
+    },
+    { allow: [/404/] }
+  )
   await check(
     'a chat that is not theirs, or in another organization, is not found',
     async () => {

apps/sim/scripts/test-organization-search-e2e.ts

@@ -1030,7 +1030,8 @@ try {
       await expect(page).toHaveURL((url) => url.pathname === `${root}/home`)
       await expect(page.getByRole('textbox', { name: 'Ask Sim' })).toBeVisible()
       await page.goto(`${baseUrl.origin}${root}/chat/${agentId}`)
-      await expect(page).toHaveURL((url) => url.pathname === `${root}/search`)
+      await expect(page.getByRole('heading', { name: 'Page not found' })).toBeVisible()
+      await expect(page.getByRole('textbox', { name: 'Ask Sim' })).toHaveCount(0)
       await page.goto(`${baseUrl.origin}${root}/search/chat/${assistantId}`)
       await expect(page.getByText(answer, { exact: true })).toBeVisible()
     }
@@ -1054,11 +1055,14 @@ try {
     const deniedRecoveries = browserErrorEvents.filter(
       (event) =>
         event.digest === 'NEXT_HTTP_ERROR_FALLBACK;404' &&
-        event.url === `${baseUrl.origin}${root}/search/chat/${deniedChatId}` &&
-        [
-          'Assistant history rejects a chat from another organization',
-          'A streamed denied chat remains navigable after hydration',
-        ].includes(event.stage)
+        ((event.url === `${baseUrl.origin}${root}/search/chat/${deniedChatId}` &&
+          [
+            'Assistant history rejects a chat from another organization',
+            'A streamed denied chat remains navigable after hydration',
+          ].includes(event.stage)) ||
+          (event.url === `${baseUrl.origin}${root}/chat/${agentId}` &&
+            event.stage ===
+              'Search-only members have Home with the Assistant and their history, but no agent chat'))
     )
     const recoveryCount = deniedRecoveries.reduce((total, event) => total + event.count, 0)
     assert.equal(