refactor(utils): replace inline toError, isRecordLike, omit, and truncate idioms with @sim/utils helpers

Author: waleedlatif1

apps/desktop/src/main/local-filesystem.ts

@@ -19,7 +19,7 @@ import {
 } from '@sim/desktop-bridge/local-filesystem-limits'
 import { generateId } from '@sim/utils/id'
 import { isRecordLike } from '@sim/utils/object'
-import { escapeRegExp } from '@sim/utils/string'
+import { escapeRegExp, truncate } from '@sim/utils/string'
 import { app, dialog, shell } from 'electron'
 import micromatch from 'micromatch'
 import safeRegex from 'safe-regex2'
@@ -1236,8 +1236,7 @@ export class LocalFilesystemService {
           matches.push({
             uri: resultUri,
             line: request.lineNumbers === false ? 0 : contextIndex + 1,
-            text:
-              line.length > MAX_GREP_LINE_LENGTH ? `${line.slice(0, MAX_GREP_LINE_LENGTH)}…` : line,
+            text: truncate(line, MAX_GREP_LINE_LENGTH, '…'),
           })
           if (matches.length >= maxResults) {
             truncated = true

apps/sim/app/api/mcp/oauth/start/route.ts

@@ -3,6 +3,7 @@ import { db } from '@sim/db'
 import { mcpServers } from '@sim/db/schema'
 import { createLogger } from '@sim/logger'
 import { getErrorMessage, toError } from '@sim/utils/errors'
+import { truncate } from '@sim/utils/string'
 import { and, eq, isNull } from 'drizzle-orm'
 import type { NextRequest } from 'next/server'
 import { NextResponse } from 'next/server'
@@ -61,7 +62,7 @@ function isDynamicClientRegistrationUnsupported(error: unknown): boolean {
 export function surfaceOauthError(error: unknown): string {
   // Spec-compliant OAuth servers throw typed subclasses with clean RFC 6749 fields.
   if (error instanceof OAuthError && !(error instanceof ServerError)) {
-    return truncate(`${error.errorCode}: ${error.message}`)
+    return truncateSurfacedError(`${error.errorCode}: ${error.message}`)
   }
 
   // ServerError wraps non-spec response bodies as "HTTP N: Invalid OAuth error
@@ -76,18 +77,16 @@ export function surfaceOauthError(error: unknown): string {
           (typeof body.message === 'string' && body.message) ||
           (typeof body.error === 'string' && body.error) ||
           null
-        if (vendorMessage) return truncate(`Authorization server: ${vendorMessage}`)
+        if (vendorMessage) return truncateSurfacedError(`Authorization server: ${vendorMessage}`)
       } catch {}
     }
-    return truncate(error.message.split('\n')[0] || 'Failed to start OAuth flow')
+    return truncateSurfacedError(error.message.split('\n')[0] || 'Failed to start OAuth flow')
   }
   return 'Failed to start OAuth flow'
 }
 
-function truncate(message: string): string {
-  return message.length > MAX_SURFACED_ERROR_LENGTH
-    ? `${message.slice(0, MAX_SURFACED_ERROR_LENGTH)}…`
-    : message
+function truncateSurfacedError(message: string): string {
+  return truncate(message, MAX_SURFACED_ERROR_LENGTH, '…')
 }
 
 export const dynamic = 'force-dynamic'

apps/sim/app/workspace/[workspaceId]/home/components/message-content/components/agent-group/tool-permission-card.tsx

@@ -14,6 +14,7 @@ import {
   toast,
 } from '@sim/emcn'
 import { createLogger } from '@sim/logger'
+import { truncate } from '@sim/utils/string'
 import { useQueryClient } from '@tanstack/react-query'
 import {
   ACTIVITY_ICON_SLOT_CLASS,
@@ -60,7 +61,7 @@ function argsPreview(params: Record<string, unknown> | undefined): string | unde
   if (!params || Object.keys(params).length === 0) return undefined
   try {
     const json = JSON.stringify(params, null, 2)
-    return json.length > 600 ? `${json.slice(0, 600)}…` : json
+    return truncate(json, 600, '…')
   } catch {
     return undefined
   }

apps/sim/blocks/blocks/google_slides.ts

@@ -1,3 +1,4 @@
+import { omit } from '@sim/utils/object'
 import { GoogleSlidesIcon } from '@/components/icons'
 import { getScopesForService } from '@/lib/oauth/utils'
 import { resolveHttpsUrlFromFileInput } from '@/lib/uploads/utils/file-utils'
@@ -3552,9 +3553,7 @@ const googleSlidesV2SubBlocks = (GoogleSlidesBlock.subBlocks || []).flatMap((sub
 
 const googleSlidesV2Inputs = GoogleSlidesBlock.inputs
   ? {
-      ...Object.fromEntries(
-        Object.entries(GoogleSlidesBlock.inputs).filter(([key]) => key !== 'imageSource')
-      ),
+      ...omit(GoogleSlidesBlock.inputs, ['imageSource']),
       imageFile: { type: 'json', description: 'Image source (file or URL)' },
     }
   : {}

apps/sim/connectors/airtable/airtable.ts

@@ -1,5 +1,6 @@
 import { createLogger } from '@sim/logger'
 import { getErrorMessage, toError } from '@sim/utils/errors'
+import { truncate } from '@sim/utils/string'
 import { fetchWithRetry } from '@/lib/knowledge/documents/secure-fetch.server'
 import { VALIDATE_RETRY_OPTIONS } from '@/lib/knowledge/documents/utils'
 import { airtableConnectorMeta } from '@/connectors/airtable/meta'
@@ -98,7 +99,7 @@ function renderTitle(value: unknown): string | null {
   if (value == null) return null
   const rendered = typeof value === 'object' ? formatCellValue(value).trim() : String(value).trim()
   if (!rendered) return null
-  return rendered.length > MAX_TITLE_LENGTH ? `${rendered.slice(0, MAX_TITLE_LENGTH)}…` : rendered
+  return truncate(rendered, MAX_TITLE_LENGTH, '…')
 }
 
 /**

apps/sim/executor/execution/block-executor.ts

@@ -1,5 +1,5 @@
 import { createLogger, type Logger } from '@sim/logger'
-import { describeError } from '@sim/utils/errors'
+import { describeError, toError } from '@sim/utils/errors'
 import { sleep } from '@sim/utils/helpers'
 import { isRecordLike, toRecord } from '@sim/utils/object'
 import { DrizzleQueryError } from 'drizzle-orm/errors'
@@ -1264,7 +1264,7 @@ export class BlockExecutor {
       if (onStreamPromise) {
         await onStreamPromise.catch(() => {})
       }
-      throw error instanceof Error ? error : new Error(String(error))
+      throw toError(error)
     }
 
     if (onStreamPromise) {

apps/sim/executor/handlers/pi/cloud/authoring/backend.ts

@@ -322,9 +322,7 @@ function mergeChangedFiles(
  */
 function mergePhaseDiffs(createDiff: string | undefined, babysitDiff: string | undefined): string {
   const merged = [createDiff, babysitDiff].filter((diff): diff is string => !!diff).join('\n')
-  return merged.length > MAX_DIFF_BYTES
-    ? `${merged.slice(0, MAX_DIFF_BYTES)}\n[diff truncated]`
-    : merged
+  return truncate(merged, MAX_DIFF_BYTES, '\n[diff truncated]')
 }
 
 function combineAuthoringAndBabysit(
@@ -554,8 +552,7 @@ async function runCloudAuthoringPi(
       let diff: string | undefined
       try {
         const raw = await runner.readFile(DIFF_PATH)
-        diff =
-          raw.length > MAX_DIFF_BYTES ? `${raw.slice(0, MAX_DIFF_BYTES)}\n[diff truncated]` : raw
+        diff = truncate(raw, MAX_DIFF_BYTES, '\n[diff truncated]')
       } catch {
         diff = undefined
       }

apps/sim/executor/handlers/pi/cloud/babysit/backend.ts

@@ -297,7 +297,7 @@ function isQuotedGitPath(path: string): boolean {
  * the net guard alone let the reported `diff` grow to megabytes across rounds.
  */
 function capDiff(text: string): string {
-  return text.length > MAX_DIFF_BYTES ? `${text.slice(0, MAX_DIFF_BYTES)}\n[diff truncated]` : text
+  return truncate(text, MAX_DIFF_BYTES, '\n[diff truncated]')
 }
 
 function mergeRoundTotals(total: PiRunTotals, round: PiRunTotals): void {

apps/sim/executor/handlers/pi/local/ssh-tools.ts

@@ -7,6 +7,7 @@
 
 import { createLogger } from '@sim/logger'
 import { getErrorMessage } from '@sim/utils/errors'
+import { truncate } from '@sim/utils/string'
 import type { Client, SFTPWrapper } from 'ssh2'
 import {
   createSSHConnection,
@@ -129,7 +130,7 @@ export async function captureRepoChanges(
     }
     const raw = await executeSSHCommand(session.client, `${scoped} && git diff HEAD`)
     const out = raw.exitCode === 0 ? raw.stdout : ''
-    const diff = out.length > maxDiffBytes ? `${out.slice(0, maxDiffBytes)}\n[diff truncated]` : out
+    const diff = truncate(out, maxDiffBytes, '\n[diff truncated]')
     return { changedFiles: [...fileSet], diff }
   } catch {
     return { changedFiles: [], diff: '' }

apps/sim/executor/variables/resolver.ts

@@ -714,7 +714,7 @@ export class VariableResolver {
         )
         return replacement
       } catch (error) {
-        replacementError = error instanceof Error ? error : new Error(String(error))
+        replacementError = toError(error)
         displayResult += match
         return match
       }