improvement(favicons): correct the platform table from vendor docs and keep misses from flashing

GitLab Dedicated instances live on gitlab-dedicated.com (and .systems pre-production);
.site is their Pages domain, kept to match gitlab.io. Adds coupacloud.com, databricks.us,
databricksapps.us, and testrail.io, each a suffix both providers miss at every level;
drops entries the parent walk already resolves and the self-hosted sentry label, whose
name collides with other products. A host with no icon is remembered client-side for the
route's miss lifetime, so a remounted icon shows its fallback without an empty frame, and
the cache key moves to v3 so stale misses for newly mapped platforms clear on deploy.

Author: waleedlatif1

apps/sim/components/favicon.tsx

@@ -2,8 +2,15 @@
 
 import { type ReactNode, useState } from 'react'
 import { cn } from '@sim/emcn'
+import { LRUCache } from 'lru-cache'
 import { faviconSrc } from '@/lib/favicon/url'
 
+/**
+ * Hosts with no icon, so an icon that mounts again renders its fallback at once instead of
+ * asking again and showing an empty slot first. Expires with the route's caching of a miss.
+ */
+const knownMisses = new LRUCache<string, true>({ max: 500, ttl: 60 * 60 * 1000 })
+
 interface FaviconProps {
   /** The site's hostname; without one the fallback renders. */
   host: string | null | undefined
@@ -20,15 +27,18 @@ interface FaviconProps {
  */
 export function Favicon({ host, fallback, className }: FaviconProps) {
   const [failedHost, setFailedHost] = useState<string | null>(null)
-  if (!host || failedHost === host) return fallback
+  if (!host || failedHost === host || knownMisses.has(host)) return fallback
   return (
     <img
       src={faviconSrc(host)}
       alt=''
       loading='lazy'
       decoding='async'
       className={cn('rounded-sm', className)}
-      onError={() => setFailedHost(host)}
+      onError={() => {
+        knownMisses.set(host, true)
+        setFailedHost(host)
+      }}
     />
   )
 }

apps/sim/lib/favicon/hosts.test.ts

@@ -53,8 +53,13 @@ describe('faviconHostCandidates', () => {
       ],
     ],
     [
-      'acme.lightning.force.com',
-      ['acme.lightning.force.com', 'lightning.force.com', 'force.com', 'salesforce.com'],
+      'acme.gitlab-dedicated.com',
+      ['acme.gitlab-dedicated.com', 'gitlab-dedicated.com', 'gitlab.com'],
+    ],
+    ['acme.testrail.io', ['acme.testrail.io', 'testrail.io', 'testrail.com']],
+    [
+      'dbc-1.cloud.databricks.us',
+      ['dbc-1.cloud.databricks.us', 'cloud.databricks.us', 'databricks.us', 'databricks.com'],
     ],
   ])(
     'ends a platform tenant %s at the platform, after its own host and parents',
@@ -90,6 +95,14 @@ describe('faviconHostCandidates', () => {
     }
   )
 
+  it('adds nothing for a platform whose parent the walk already reaches', () => {
+    expect(faviconHostCandidates('acme.my.salesforce.com')).toEqual([
+      'acme.my.salesforce.com',
+      'my.salesforce.com',
+      'salesforce.com',
+    ])
+  })
+
   it('never repeats a host the walk already reaches', () => {
     expect(faviconHostCandidates('gitlab.gitlab.com')).toEqual(['gitlab.gitlab.com', 'gitlab.com'])
   })

apps/sim/lib/favicon/platforms.ts

@@ -1,20 +1,26 @@
 /**
- * Platforms whose tenant hosts no icon provider can see — not even at the parent domain — mapped
- * to the platform's own site, so a tenant still shows the product it is. Generic hosting domains
- * (`herokuapp.com`, `azurewebsites.net`, `cloudfront.net`) are deliberately absent: they serve
- * other companies' apps, and the host's logo would misrepresent them.
+ * Platforms whose tenant hosts no icon provider can see — not even at any parent the walk
+ * reaches — mapped to the platform's own site, so a tenant still shows the product it is. A
+ * platform whose parent already resolves (`salesforce.com`, `databricks.com`, `atlassian.net`)
+ * needs no entry. Generic hosting domains (`herokuapp.com`, `azurewebsites.net`,
+ * `cloudfront.net`) are deliberately absent: they serve other companies' apps, and the host's
+ * logo would misrepresent them. GitLab Pages on Dedicated (`gitlab-dedicated.site`) maps like
+ * `gitlab.io`, whose parent already shows GitLab's icon.
  */
 const PLATFORM_SITES: ReadonlyMap<string, string> = new Map([
   ['awsapps.com', 'aws.amazon.com'],
   ['azuredatabricks.net', 'databricks.com'],
-  ['cloud.databricks.com', 'databricks.com'],
+  ['coupacloud.com', 'coupa.com'],
   ['coupahost.com', 'coupa.com'],
+  ['databricks.us', 'databricks.com'],
   ['databricksapps.com', 'databricks.com'],
+  ['databricksapps.us', 'databricks.com'],
+  ['gitlab-dedicated.com', 'gitlab.com'],
   ['gitlab-dedicated.site', 'gitlab.com'],
+  ['gitlab-dedicated.systems', 'gitlab.com'],
   ['jamacloud.com', 'jamasoftware.com'],
-  ['lightning.force.com', 'salesforce.com'],
-  ['my.salesforce.com', 'salesforce.com'],
   ['oktapreview.com', 'okta.com'],
+  ['testrail.io', 'testrail.com'],
   ['ultipro.com', 'ukg.com'],
 ])
 
@@ -25,7 +31,6 @@ const SELF_HOSTED_PRODUCTS: ReadonlyMap<string, string> = new Map([
   ['grafana', 'grafana.com'],
   ['jenkins', 'jenkins.io'],
   ['jira', 'atlassian.com'],
-  ['sentry', 'sentry.io'],
   ['testrail', 'testrail.com'],
 ])
 

apps/sim/lib/favicon/resolve.server.ts

@@ -36,7 +36,7 @@ type FaviconResolution =
 
 const inFlight = new Map<string, Promise<FaviconResolution>>()
 
-const cacheKey = (host: string) => `favicon:v2:${host}`
+const cacheKey = (host: string) => `favicon:v3:${host}`
 
 /** A host's key holds the result of the walk that starts at that host. */
 async function readCache(host: string): Promise<FaviconResolution | null> {
@@ -128,10 +128,11 @@ async function walk(candidates: string[], signal: AbortSignal): Promise<FaviconR
 }
 
 /**
- * The icon for a host, or its nearest parent domain's, from public icon providers — the
- * destination itself is never contacted, so a host behind a login still gets its platform's
- * icon. Results are cached per host (30 days for an icon, a day for none, minutes after an
- * outage), and concurrent lookups of one host in this process share a single resolution.
+ * The icon for a host, or its nearest parent domain's, from public icon providers — Sim never
+ * contacts the destination itself (a provider may, from its own servers), so a host behind a
+ * login still gets its platform's icon. Results are cached per host (30 days for an icon, a day
+ * for none or for a parent's icon chosen after a timeout, minutes after an outage), and
+ * concurrent lookups of one host in this process share a single resolution.
  */
 export async function resolveFavicon(host: string): Promise<FaviconResolution> {
   const candidates = faviconHostCandidates(host)