Revert "fix(org): fail mutations fast offline so a pending dialog can be cancelled"

This reverts commit 878abc5.

Author: waleedlatif1

apps/sim/app/_shell/providers/get-query-client.ts

@@ -29,12 +29,6 @@ export function makeQueryClient() {
       },
       mutations: {
         retry: false,
-        /**
-         * The default pauses a mutation started offline until reconnect. Nothing here persists or
-         * shows that queue: the caller just waits, holding a pending dialog open, and the action
-         * then runs long after the person gave up on it. Failing fast lets them see it and decide.
-         */
-        networkMode: 'always',
       },
     },
   })

apps/sim/ee/data-retention/hooks/data-retention.ts

@@ -37,8 +37,6 @@ export function useOrganizationRetention(orgId: string | undefined) {
     queryFn: ({ signal }) => fetchDataRetention(orgId as string, signal),
     enabled: Boolean(orgId),
     staleTime: DATA_RETENTION_STALE_TIME,
-    // A save re-reads this first: offline, that read must fail rather than wait and write on reconnect.
-    networkMode: 'always',
   })
 }
 

apps/sim/platform/app/(shell)/settings/_components/sections/data-retention/data-retention-section.round-trip.test.tsx

@@ -8,7 +8,7 @@ import {
 } from '@sim/testing/mocks/api-client-request.mock'
 import { stubResizeObserver } from '@sim/testing/mocks/browser-apis.mock'
 import { emcnMock, emcnMockFns } from '@sim/testing/mocks/emcn.mock'
-import { onlineManager, QueryClient, QueryClientProvider } from '@tanstack/react-query'
+import { QueryClient, QueryClientProvider } from '@tanstack/react-query'
 import { createRoot, type Root } from 'react-dom/client'
 import { afterEach, beforeEach, describe, expect, it, vi } from 'vitest'
 import {
@@ -161,7 +161,6 @@ describe('DataRetentionSection across saves', () => {
   })
 
   afterEach(() => {
-    onlineManager.setOnline(true)
     act(() => root.unmount())
     container.remove()
     queryClient.clear()
@@ -233,18 +232,6 @@ describe('DataRetentionSection across saves', () => {
       )
     })
 
-    it('stops at once while offline instead of waiting to write on reconnect', async () => {
-      await click('Organization')
-      await click('keep logs 7 days')
-      onlineManager.setOnline(false)
-      await failNextReads(() => click('Save'))
-
-      expect(emcnMockFns.mockToast.error).toHaveBeenCalledWith(
-        'Could not confirm the latest retention settings. Nothing was saved.'
-      )
-      expect(server.writes).toEqual([])
-    })
-
     it('removes nothing over the document from before the failure', async () => {
       await click('Organization')
       await failNextReads(() => click('Remove'))