refactor(workflows): resolve the deployed state with one const after the throw

loadDeployedWorkflowState throws first when the active version has no state
and Postgres did not withhold one, then picks the cached re-read or the
materialization in one expression; behaviour is unchanged.

Author: waleedlatif1

apps/sim/lib/workflows/persistence/utils.ts

@@ -313,23 +313,17 @@ export async function loadDeployedWorkflowState(
       throw new NoActiveDeploymentError(workflowId)
     }
 
-    let deployedState: DeployedWorkflowData
-    if (active.id === cachedVersionId && active.state == null) {
-      // Served from the cache, or re-read by id if the entry was evicted since the hint.
-      deployedState = await loadWorkflowDeploymentVersionState(
-        workflowId,
-        active.id,
-        providedWorkspaceId
-      )
-    } else if (!active.state) {
-      throw new NoActiveDeploymentError(workflowId)
-    } else {
-      deployedState = await materializeDeploymentState(
-        workflowId,
-        active,
-        await resolveWorkspaceId(workflowId, providedWorkspaceId)
-      )
-    }
+    /** Postgres withheld the state this process already caches for the active version. */
+    const withheld = active.id === cachedVersionId && active.state == null
+    if (!withheld && !active.state) throw new NoActiveDeploymentError(workflowId)
+    const deployedState = withheld
+      ? // Served from the cache, or re-read by id if the entry was evicted since the hint.
+        await loadWorkflowDeploymentVersionState(workflowId, active.id, providedWorkspaceId)
+      : await materializeDeploymentState(
+          workflowId,
+          active,
+          await resolveWorkspaceId(workflowId, providedWorkspaceId)
+        )
     cachedVersionByWorkflow.set(workflowId, active.id)
     return deployedState
   } catch (error) {