test(platform): follow members onto Home and stop waiting on a composer focus that was reverted

Members now chat and land on Home, which reads their accounts itself, so
the Integrations hover warm starts from Search and first proves Search
read none. A member's Search URL for an agent chat hands back to the chat
(the legacy gate), not a not-found.

e6ae142 dropped the composer's focus on mount, which both Mod+B checks
used as their hydration signal. They now press the shortcut again only
while the sidebar has not moved, so a press before hydration cannot pass
or toggle back.

Author: waleedlatif1

apps/sim/platform/checks/live/flows.spec.ts

@@ -66,11 +66,13 @@ test('Mod+B collapses the sidebar, the choice survives a reload, and Expand rest
   await signInAsAdmin(page, liveRoute('/home'))
   const sidebar = page.getByRole('complementary', { name: 'Platform sidebar' })
   await expect(sidebar).toBeVisible()
-  // Home's composer takes focus as it mounts and Mod+B leaves a focused field alone, as legacy did.
-  await expect(page.getByRole('textbox', { name: /Ask about your business/ })).toBeFocused()
+  // Mod+B leaves a focused field alone, as legacy did, so the press starts off any field. The
+  // server paints the sidebar before the shortcut listens: press again only while it is showing.
   await page.locator('body').click({ position: { x: 700, y: 20 } })
-  await pressShortcut(page, 'ControlOrMeta+b')
-  await expect(sidebar).toBeHidden()
+  await expect(async () => {
+    if (await sidebar.isVisible()) await pressShortcut(page, 'ControlOrMeta+b')
+    await expect(sidebar).toBeHidden({ timeout: 1_000 })
+  }).toPass()
   await page.reload()
   await expect(sidebar).toBeHidden()
   await page.getByRole('button', { name: 'Expand sidebar' }).click()

apps/sim/scripts/org-redesign-e2e/checks/landing.ts

@@ -73,26 +73,23 @@ export async function landingChecks() {
     })
   })
   await check(
-    "a member's agent chat opens as a chat, is absent under Search, and lists in the rail",
+    "a member's agent chat opens as a chat, Search hands it back to the chat, and it lists in the rail",
     async () => {
       await withSession(MEMBER, async (session) => {
         const { page } = session
         const transcript = page.getByText(`Here is what I found about ${MEMBER_CHATS.agent.title}.`)
         await page.goto(url(org.chat(MEMBER_CHATS.agent.id)))
         await expect(page).toHaveURL(url(org.chat(MEMBER_CHATS.agent.id)))
         await expect(transcript).toBeVisible()
-        // Search only opens assistant chats, so an agent chat there is absent, as in legacy.
+        // Search opens only assistant chats; a Search URL for an agent chat returns to the chat.
         await page.goto(url(org.searchChat(MEMBER_CHATS.agent.id)))
-        await expectPageNotFound(page)
-        await expect(transcript).toHaveCount(0)
+        await expect(page).toHaveURL(url(org.chat(MEMBER_CHATS.agent.id)))
+        await expect(transcript).toBeVisible()
+        await expect(searchField(page)).toHaveCount(0)
         await page.goto(url(org.home))
         await session.settle()
         await expect(railLink(page, MEMBER_CHATS.agent.title)).toBeVisible()
       })
-    },
-    {
-      // The member's own agent chat, which Search does not open.
-      allow: [refused(404, 'GET', org.searchChat(MEMBER_CHATS.agent.id))],
     }
   )
   await check(

apps/sim/scripts/org-redesign-e2e/checks/sidebar.ts

@@ -100,8 +100,13 @@ export async function sidebarChecks() {
   await check('hover warms Integrations through its own reads', async () => {
     await withSession(MEMBER, async (session) => {
       const { page } = session
-      await page.goto(url(org.home))
+      // Home reads the member's accounts itself, so the hover starts from Search, which does not.
+      await page.goto(url(org.search))
       await session.settle()
+      assert(
+        !session.requests.some(({ path }) => path.includes('/connected-accounts')),
+        'Search must not read the accounts the hover is meant to warm'
+      )
       session.requests.length = 0
       await mainNav(page).getByRole('link', { name: 'Integrations', exact: true }).hover()
       await expect
@@ -134,11 +139,13 @@ export async function sidebarChecks() {
         await page.reload()
         await expect(rail).toBeHidden()
         await expect(opener).toBeVisible()
-        // The server renders the attribute, so only this says the shortcut is listening.
-        await expect(composer(page)).toBeFocused()
+        // The server renders the collapsed rail before the shortcut listens, so a press before
+        // hydration does nothing: press again only while the rail is still hidden.
         await page.locator('body').click({ position: { x: 700, y: 20 } })
-        await page.keyboard.press('Control+b')
-        await expect(rail).toBeVisible()
+        await expect(async () => {
+          if (await rail.isHidden()) await page.keyboard.press('Control+b')
+          await expect(rail).toBeVisible({ timeout: 1_000 })
+        }).toPass()
         await composer(page).click()
         await page.keyboard.press('Control+b')
         await expect(rail).toBeVisible()