Skip to content

Commit 09fe993

Browse files
committed
fix(checks): resolve staging's skill references, drop the removed link hint, and assert the masked API key as a password field
1 parent b8fc702 commit 09fe993

4 files changed

Lines changed: 4 additions & 4 deletions

File tree

‎.agents/skills/add-block/SKILL.md‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -165,7 +165,7 @@ A block that takes a secret inline keeps running for existing workflows; the sav
165165
version is a new block type that spreads it. Keep the successor an object literal with the picker
166166
written inline, because the docs generator reads the source text:
167167

168-
```typescript
168+
```typescript illustrative
169169
export const ServiceV2Block: BlockConfig = {
170170
...ServiceBlock,
171171
type: 'service_v2',

‎.agents/skills/add-integration/SKILL.md‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -80,7 +80,7 @@ service id:
8080
`server.ts`). Make one cheap, documented read on the tools' own host with the tools' own auth,
8181
reusing their header and URL builders. `domain` and `workspaceId` normalize to exactly the form
8282
the tools build URLs from and throw for anything that could steer the host or path
83-
(`normalizeHttpBaseUrl`, `allowedDomain`, `refuseUrlCredentials`); the normalized domain is what
83+
(`normalizeHttpBaseUrl`, `allowedDomain`, and a refusal of credentials in the URL); the normalized domain is what
8484
the credential stores. Set `egress` when the user chooses the host. Add `forbiddenMeansScoped`,
8585
`rejectsKey`, or `provesKey` only for documented replies (probe a fake key to see how a bad one
8686
answers), and `errorBodyEchoesToken` when an error body echoes the token.

‎apps/sim/platform/checks/integrations.spec.ts‎

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -221,7 +221,8 @@ test('Granola connects with its API key and keeps every template in page flow',
221221
// Display name, description and the API key, which stays masked until revealed.
222222
await expect(connect.getByRole('textbox')).toHaveCount(3)
223223
await expect(connect.getByRole('textbox', { name: 'API key', exact: true })).toHaveAttribute(
224-
'data-masked'
224+
'type',
225+
'password'
225226
)
226227
// The catalog lists no reads for Granola's key, so the dialog has no access list to show.
227228
await expect(connect.getByRole('region', { name: 'Connection access', exact: true })).toHaveCount(

‎apps/sim/scripts/org-redesign-e2e/checks/links.ts‎

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -239,7 +239,6 @@ export async function linksChecks() {
239239
.getByRole('textbox', { name: 'Destination URL' })
240240
.fill('https://parts.example.com/{*}')
241241
await expect(modal.getByRole('textbox', { name: 'Default destination' })).toBeVisible()
242-
await expect(modal.getByText(/Opens when no value fills/)).toBeVisible()
243242
await modal
244243
.getByRole('textbox', { name: 'Default destination' })
245244
.fill('https://parts.example.com')

0 commit comments

Comments
 (0)