improvement(search): unify source setup and member connection actions

Author: waleedlatif1

apps/sim/app/api/knowledge/sim-search/sources/route.test.ts

@@ -0,0 +1,121 @@
+/** @vitest-environment node */
+import { authMockFns, createMockRequest } from '@sim/testing'
+import { beforeEach, describe, expect, it, vi } from 'vitest'
+
+const mocks = vi.hoisted(() => ({ execute: vi.fn() }))
+vi.mock('@/lib/knowledge/application/search-sources', () => ({
+  listSearchSources: { operation: { id: 'knowledge.search.sources.list' }, execute: mocks.execute },
+}))
+vi.mock('@/lib/knowledge/application/search', () => ({
+  KnowledgeSearchProvenanceUnavailableError: class extends Error {},
+}))
+vi.mock('@/lib/knowledge/application/upload-sessions', () => ({
+  KnowledgeDocumentUnsupportedMediaTypeError: class extends Error {},
+}))
+
+import { NoWorkspaceAccessError } from '@/lib/core/application/workspace-authorization'
+import { GET } from '@/app/api/knowledge/sim-search/sources/route'
+
+const WORKSPACE_ID = '7d28e5e2-fb03-4118-9c52-4ab77ccff369'
+const source = {
+  knowledgeBaseId: 'search-index',
+  connectorId: 'source',
+  connectorType: 'google_drive',
+  sourceDescription: 'Handbook',
+  accessMode: 'admin',
+  availability: 'available',
+  enabled: true,
+  isSyncing: false,
+  lastSyncAt: null,
+  hasSyncError: false,
+  viewerDocumentCount: 0,
+  viewerEmailVerified: true,
+  connectionRequired: false,
+  viewerMembership: null,
+}
+
+beforeEach(() => {
+  vi.clearAllMocks()
+  authMockFns.mockGetSession.mockResolvedValue({
+    user: { id: 'reader' },
+    session: { id: 'session' },
+  })
+  mocks.execute.mockResolvedValue({ sources: [source] })
+})
+
+describe('GET Search sources', () => {
+  it('authenticates before parsing the workspace query', async () => {
+    authMockFns.mockGetSession.mockResolvedValue(null)
+    const response = await GET(createMockRequest('GET'))
+    expect(response.status).toBe(401)
+    expect(mocks.execute).not.toHaveBeenCalled()
+  })
+
+  it('refuses a missing workspace before entering the use case', async () => {
+    const response = await GET(createMockRequest('GET'))
+    expect(response.status).toBe(400)
+    expect(mocks.execute).not.toHaveBeenCalled()
+  })
+
+  it('passes the authenticated subject into the registered operation and projects only the contract fields', async () => {
+    mocks.execute.mockResolvedValue({
+      sources: [
+        {
+          ...source,
+          credentialId: 'secret',
+          sourceConfig: { token: 'secret' },
+          lastSyncError: 'private failure',
+        },
+      ],
+    })
+    const response = await GET(
+      createMockRequest(
+        'GET',
+        undefined,
+        {},
+        `http://localhost/api/knowledge/sim-search/sources?workspaceId=${WORKSPACE_ID}`
+      )
+    )
+    expect(response.status).toBe(200)
+    expect(response.headers.get('Cache-Control')).toBe('private, no-store')
+    const body = await response.json()
+    expect(body).toMatchObject({ success: true, data: [source] })
+    expect(body.data[0]).toEqual(source)
+    expect(mocks.execute).toHaveBeenCalledWith(
+      expect.objectContaining({
+        principal: { kind: 'session', userId: 'reader', sessionId: 'session' },
+        input: { workspaceId: WORKSPACE_ID },
+      })
+    )
+  })
+
+  it('preserves authorization rejection and conceals source data', async () => {
+    mocks.execute.mockRejectedValue(new NoWorkspaceAccessError())
+    const response = await GET(
+      createMockRequest(
+        'GET',
+        undefined,
+        {},
+        `http://localhost/api/knowledge/sim-search/sources?workspaceId=${WORKSPACE_ID}`
+      )
+    )
+    expect(response.status).toBe(404)
+    expect(await response.json()).not.toHaveProperty('data')
+  })
+
+  it('does not publish infrastructure errors or mistake failures for an empty list', async () => {
+    mocks.execute.mockRejectedValue(new Error('database private connection string'))
+    const response = await GET(
+      createMockRequest(
+        'GET',
+        undefined,
+        {},
+        `http://localhost/api/knowledge/sim-search/sources?workspaceId=${WORKSPACE_ID}`
+      )
+    )
+    expect(response.status).toBe(500)
+    const body = await response.json()
+    expect(body.error).toBe('Internal server error')
+    expect(body).not.toHaveProperty('data')
+  })
+})

apps/sim/app/api/knowledge/sim-search/sources/route.ts

@@ -0,0 +1,23 @@
+import { listSearchSourcesContract } from '@/lib/api/contracts/knowledge'
+import {
+  defineInternalJsonRoute,
+  internalRateLimits,
+  internalSessionAuth,
+} from '@/lib/api/server/routes'
+import { internalKnowledgeErrorPolicies } from '@/lib/knowledge/api/route-policies'
+import { knowledgeOperations } from '@/lib/knowledge/application/operations'
+import { listSearchSources } from '@/lib/knowledge/application/search-sources'
+
+export const GET = defineInternalJsonRoute({
+  contract: listSearchSourcesContract,
+  auth: internalSessionAuth,
+  operation: knowledgeOperations.listSearchSources,
+  rateLimit: internalRateLimits.none({
+    reason: 'Workspace source summaries for the Search page and indexing status polling',
+  }),
+  errorPolicy: internalKnowledgeErrorPolicies.connectors,
+  mapInput: ({ query }) => ({ workspaceId: query.workspaceId }),
+  useCase: listSearchSources,
+  present: ({ sources }) => ({ success: true as const, data: sources }),
+  staticResponseHeaders: { 'Cache-Control': 'private, no-store' },
+})