Skip to content

TT-7334 prompt step UX#323

Merged
sarahentzel merged 2 commits into
developfrom
TT-7334-prompt-ux
May 22, 2026
Merged

TT-7334 prompt step UX#323
sarahentzel merged 2 commits into
developfrom
TT-7334-prompt-ux

Conversation

@gtryus
Copy link
Copy Markdown
Contributor

@gtryus gtryus commented May 22, 2026

  • Record icon should be docked to the bottom. It's too high up the page.
  • Hide the Clear button when there's no audio
  • Admin instructions
  • On desktop, the audio waveform butts up against the left side of the page. It needs some padding or margin.
  • For the BOLD user, the waveform appears in a vertical scrollbar. Remove this.
  • no playback speed
  • Before they've listened to the prompt, the Next button is disabled. This is a bug. Also, it should not say "Next," it should say "Record" or whatever the next step is.

Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR improves the Prompt step experience in Passage Detail (especially on mobile) by docking the record control to the bottom, removing the “must listen before Next” gating, and adding admin-specific guidance strings.

Changes:

  • Add support for “docked” record button rendering (record button supplied by the audio player and rendered in the mobile footer area for Prompt admins).
  • Hide Clear when there’s no audio to clear, remove playback speed for Prompt members, and adjust layout to avoid horizontal/vertical overflow issues.
  • Add new localized strings for Prompt admin instructions and an admin-specific Prompt tip; update the mobile footer test to match the new navigation behavior.

Reviewed changes

Copilot reviewed 17 out of 18 changed files in this pull request and generated 2 comments.

Show a summary per file
File Description
src/renderer/src/store/localization/reducers.tsx Adds new English strings for prompt admin instructions and prompt admin tip.
src/renderer/src/store/localization/model.tsx Extends localization TypeScript interfaces with the new prompt/admin keys.
src/renderer/src/store/localization/exported-strings-name.json Updates the generated strings bundle name reference.
src/renderer/src/context/PassageDetailContext.tsx Adds context fields/setter to carry a “docked record button” node + versioning.
src/renderer/src/components/WSAudioPlayer.tsx Adds dockRecordButton plumbing, hides Clear when no audio exists, and clamps overflow for waveform layout.
src/renderer/src/components/PassageDetail/Prompt/PassageDetailPromptMember.tsx Disables playback speed for members; tightens container sizing to prevent overflow.
src/renderer/src/components/PassageDetail/Prompt/PassageDetailPromptAdmin.tsx Hooks Prompt admin MediaRecord to dock the record button and displays admin instructions text.
src/renderer/src/components/PassageDetail/PassageDetailPlayer.tsx Splits allowZoomAndSpeed into allowZoom / allowSpeed for finer control.
src/renderer/src/components/PassageDetail/PassageDetailMobileLayout.tsx Prevents horizontal overflow in the scrolling content area; supports footerAbove usage.
src/renderer/src/components/PassageDetail/PassageDetailMobileDetail.tsx Renders the docked Prompt record button above the main footer for Prompt admins.
src/renderer/src/components/PassageDetail/PassageDetailGrids.tsx Adds horizontal padding to address waveform alignment against the left edge.
src/renderer/src/components/PassageDetail/mobile/PassageDetailMobileFooter.tsx Removes “prompt playback complete” gating for Next; always shows next-step label.
src/renderer/src/components/PassageDetail/mobile/PassageDetailMobileFooter.cy.tsx Updates Cypress component test to reflect new Prompt navigation behavior.
src/renderer/src/components/PassageDetail/mobile/MobileWorkflowSteps.tsx Adds admin-specific tooltip selection for the Prompt step.
src/renderer/src/components/MediaRecord.tsx Forwards docked record button props through to the underlying audio player.
localization/TranscriberAdmin-en.xlf Adds XLF units for the new prompt/workflowSteps strings.
localization/TranscriberAdmin-en-1.2.xliff Adds XLIFF units for the new prompt/workflowSteps strings with sourcefile context.

Comment thread src/renderer/src/components/PassageDetail/mobile/MobileWorkflowSteps.tsx Outdated
- Added new translation units for admin instructions and prompt tips in XLIFF and XLF files.
- Introduced docked record button functionality in MediaRecord and WSAudioPlayer components.
- Updated PassageDetail components to utilize new prompt-related context and permissions.
- Improved mobile layout and footer to accommodate new prompt features.
- Refactored related components to ensure consistent handling of prompt recording and playback.
@gtryus gtryus force-pushed the TT-7334-prompt-ux branch from a671d43 to 95c6033 Compare May 22, 2026 20:02
…for improved state management. Updated mock memory and query builder functions to enhance record handling and support live queries. Adjusted component structure for better context usage.
@sarahentzel sarahentzel merged commit a41883a into develop May 22, 2026
2 checks passed
@sarahentzel sarahentzel deleted the TT-7334-prompt-ux branch May 22, 2026 21:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants