Skip to content

URL injection/encoding bug in notifications #179

Description

@mkarnebeek
~/Desktop $ sem get notifications
NAME                                         AGE
test/name                                    89d
test-name                                    375d
~/Desktop $ sem get notification "test-name"
apiVersion: v1alpha
kind: Notification
...

So far so good. Until...

~/Desktop $ sem get notification "test/name"
error: http status 404 with message "Not Found
" received from upstream

Ok, so maybe it needs some escaping/encoding?

~/Desktop $ sem get notification "test//name"
error: http status 404 with message "Not Found
" received from upstream

~/Desktop $ sem get notification "test%2Fname"
error: http status 404 with message "Not Found
" received from upstream

Nope. Seems broken. Maybe try something crazy?

~/Desktop $ sem get notification "test\name"
error: http status 404 with message "{"error":"Notification test\\name not found","code":5,"message":"Notification test\\name not found"}" received from upstream

Wow, this last one seems like this was the error message intended to be received, were the previous errors seem to be calling a different actually non-existing endpoint because it, presumably, just put the user-provided string in the url.

Activity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions