Skip to content

Rename SnapshotGenerationOverrides -> TendermintSnapshotGenerationOverrides #6

@bdchatham

Description

@bdchatham

Context

SnapshotGenerationOverrides(keepRecent int32) map[string]string currently lives in this repo and is consumed by sei-k8s-controller's planner to set snapshot-interval / snapshot-keep-recent on app.toml.

In sei-k8s-controller we just landed a refactor (sei-protocol/sei-k8s-controller#108) that nests the controller-side config under a TendermintSnapshotGenerationConfig sub-struct, so the "Tendermint state-sync snapshot" mode is explicit and extensible for future snapshot flavors (e.g., seidb, app-layer).

Request

Rename SnapshotGenerationOverridesTendermintSnapshotGenerationOverrides to match. This is small and mechanical but clarifies the function name aligns with the only snapshot mode it writes overrides for — the Tendermint state-sync one.

Not blocking anything; filing so it doesn't get lost.

Call sites to update after the rename

  • github.com/sei-protocol/sei-k8s-controller/internal/planner/full.go
  • github.com/sei-protocol/sei-k8s-controller/internal/planner/archive_test.go (references KeySnapshotInterval nearby)

Suggested shape

// TendermintSnapshotGenerationOverrides returns app.toml overrides that
// configure seid to produce Tendermint state-sync snapshots at the system
// default interval, retaining `keepRecent` on disk.
func TendermintSnapshotGenerationOverrides(keepRecent int32) map[string]string { ... }

Keep the old name as a deprecated alias if any external consumer is known, or just rename outright — sei-k8s-controller is the only in-tree caller I'm aware of.

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions