Skip to content

split out linker-info from linker-messages#149937

Merged
rust-bors[bot] merged 3 commits into
rust-lang:mainfrom
jyn514:linker-info
Mar 7, 2026
Merged

split out linker-info from linker-messages#149937
rust-bors[bot] merged 3 commits into
rust-lang:mainfrom
jyn514:linker-info

Conversation

@jyn514

@jyn514 jyn514 commented Dec 13, 2025 •
edited
Loading

Copy link
Copy Markdown
Member

@rustbot rustbot added A-attributes Area: Attributes (`#[…]`, `#![…]`) S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. labels Dec 13, 2025
@rust-log-analyzer

This comment has been minimized.

Sign in to view
@rust-log-analyzer

This comment has been minimized.

Sign in to view
@saethlin

saethlin commented Dec 13, 2025

Copy link
Copy Markdown
Member

@bors try

@rust-bors

This comment has been minimized.

Sign in to view
rust-bors Bot added a commit that referenced this pull request Dec 13, 2025
@rust-bors
Auto merge of #149937 - jyn514:linker-info, r=<try>
58b1b3c 
try enabling `linker-messages` by default again
@rust-log-analyzer

This comment has been minimized.

Sign in to view
@rust-bors

rust-bors Bot commented Dec 13, 2025

Copy link
Copy Markdown
Contributor

☀️ Try build successful (CI)
Build commit: 58b1b3c (58b1b3c5342a414c161338871f8004258ccef2a7, parent: eb171a227f9e5de5d376b6edb56b174bc8235fb3)

@saethlin

saethlin commented Dec 13, 2025

Copy link
Copy Markdown
Member

@craterbot build-only

@craterbot

craterbot commented Dec 13, 2025

Copy link
Copy Markdown
Collaborator

🚨 Error: failed to parse the command

🆘 If you have any trouble with Crater please ask in t-infra on Zulip
ℹ️ Crater is a tool to run experiments across parts of the Rust ecosystem. Learn more

@saethlin

saethlin commented Dec 13, 2025

Copy link
Copy Markdown
Member

@craterbot run mode=build-only

@craterbot

craterbot commented Dec 13, 2025

Copy link
Copy Markdown
Collaborator

👌 Experiment pr-149937 created and queued.
🤖 Automatically detected try build 58b1b3c
🔍 You can check out the queue and this experiment's details.

ℹ️ Crater is a tool to run experiments across parts of the Rust ecosystem. Learn more

@craterbot craterbot added S-waiting-on-crater Status: Waiting on a crater run to be completed. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Dec 13, 2025
@rustbot rustbot added the A-run-make Area: port run-make Makefiles to rmake.rs label Dec 13, 2025
@rust-log-analyzer

This comment has been minimized.

Sign in to view
@rust-log-analyzer

This comment has been minimized.

Sign in to view
@jyn514 jyn514 mentioned this pull request Dec 14, 2025
Merged
@rust-log-analyzer

This comment has been minimized.

Sign in to view
matthiaskrgr added a commit to matthiaskrgr/rust that referenced this pull request Dec 14, 2025
@matthiaskrgr
Rollup merge of rust-lang#149969 - jyn514:ibt, r=jieyouxu
efdd61d 
don't use no_main and no_core to test IBT

The previous test was quite fragile and depended on a bunch of internal features. Simplify it.

Split out of rust-lang#149937.

cc `@jieyouxu` `@Oneirical`
matthiaskrgr added a commit to matthiaskrgr/rust that referenced this pull request Dec 14, 2025
@matthiaskrgr
Rollup merge of rust-lang#149969 - jyn514:ibt, r=jieyouxu
1b7cc44 
don't use no_main and no_core to test IBT

The previous test was quite fragile and depended on a bunch of internal features. Simplify it.

Split out of rust-lang#149937.

cc ``@jieyouxu`` ``@Oneirical``
matthiaskrgr added a commit to matthiaskrgr/rust that referenced this pull request Dec 14, 2025
@matthiaskrgr
Rollup merge of rust-lang#149969 - jyn514:ibt, r=jieyouxu
98f8736 
don't use no_main and no_core to test IBT

The previous test was quite fragile and depended on a bunch of internal features. Simplify it.

Split out of rust-lang#149937.

cc ```@jieyouxu``` ```@Oneirical```
rust-timer added a commit that referenced this pull request Dec 15, 2025
@rust-timer
Unrolled build for #149969
d399792 
Rollup merge of #149969 - jyn514:ibt, r=jieyouxu

don't use no_main and no_core to test IBT

The previous test was quite fragile and depended on a bunch of internal features. Simplify it.

Split out of #149937.

cc ```@jieyouxu``` ```@Oneirical```
@bors

bors commented Dec 15, 2025

Copy link
Copy Markdown
Collaborator

☔ The latest upstream changes (presumably #149999) made this pull request unmergeable. Please resolve the merge conflicts.

github-actions Bot pushed a commit to rust-lang/miri that referenced this pull request Dec 18, 2025
@matthiaskrgr
Rollup merge of #149969 - jyn514:ibt, r=jieyouxu
a0921cf 
don't use no_main and no_core to test IBT

The previous test was quite fragile and depended on a bunch of internal features. Simplify it.

Split out of rust-lang/rust#149937.

cc ```@jieyouxu``` ```@Oneirical```
@craterbot

craterbot commented Dec 25, 2025

Copy link
Copy Markdown
Collaborator

🚧 Experiment pr-149937 is now running

ℹ️ Crater is a tool to run experiments across parts of the Rust ecosystem. Learn more

@craterbot

craterbot commented Dec 27, 2025

Copy link
Copy Markdown
Collaborator

🎉 Experiment pr-149937 is completed!
📊 24 regressed and 5 fixed (758860 total)
📊 2582 spurious results on the retry-regressed-list.txt, consider a retry1 if this is a significant amount.
📰 Open the summary report.

⚠️ If you notice any spurious failure please add them to the denylist!
ℹ️ Crater is a tool to run experiments across parts of the Rust ecosystem. Learn more

Footnotes

  1. re-run the experiment with crates=https://crater-reports.s3.amazonaws.com/pr-149937/retry-regressed-list.txt ↩

@JonathanBrouwer JonathanBrouwer mentioned this pull request Feb 25, 2026
Closed
rust-bors Bot pushed a commit that referenced this pull request Feb 25, 2026
@bors
Auto merge of #153098 - JonathanBrouwer:rollup-dGxVpH7, r=JonathanBro…
2a2e570 
…uwer

Rollup of 13 pull requests

Successful merges:

 - #153079 (Revert "Move aarch64-apple dist builder to dynamic llvm linking")
 - #148146 (CI: use alternative disks if available)
 - #149937 (spliit out `linker-info` from `linker-messages`)
 - #151771 (Fix: On wasm targets, call `panic_in_cleanup` if panic occurs in cleanup)
 - #153035 (rustc_target: callconv: powerpc64: Use llvm_abiname rather than target_abi for ABI determination)
 - #153075 (mGCA: Lower negated literals directly and reject non-integer negations)
 - #153078 (Remove `QuerySystemFns`)
 - #149978 (deprecate `Eq::assert_receiver_is_total_eq` and emit FCW on manual impls)
 - #153029 (Rename `rustc::pass_by_value` lint as `rustc::disallowed_pass_by_ref`.)
 - #153063 (`is_ty_must_use`: do not require a `span` argument)
 - #153071 (Update books)
 - #153092 (Remove redundant self usages)
 - #153094 (Simplify `AppendOnlyVec` iterators)

Failed merges:

 - #153091 (Migration of `LintDiagnostic` - part 4)
@jhpratt

jhpratt commented Feb 26, 2026

Copy link
Copy Markdown
Member

@bors r-

#153098 (comment)

@rust-bors rust-bors Bot added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. labels Feb 26, 2026
@rust-bors

rust-bors Bot commented Feb 26, 2026

Copy link
Copy Markdown
Contributor

Commit 5847b63 has been unapproved.

This PR was contained in a rollup (#153098), which was also unapproved.

jhpratt added a commit to jhpratt/rust that referenced this pull request Mar 2, 2026
@jhpratt
Rollup merge of rust-lang#153090 - mati865:elf-raw-dylib-fns, r=TaKO8Ki
f421377 
elf-raw-dylib: set type for functions

Avoids GNU ld warnings like:
```
type and size of dynamic symbol `meooooooooooooooow' are not defined
```
First noticed in rust-lang#152451 (comment) with changes from rust-lang#149937.
JonathanBrouwer added a commit to JonathanBrouwer/rust that referenced this pull request Mar 2, 2026
@JonathanBrouwer
Rollup merge of rust-lang#153090 - mati865:elf-raw-dylib-fns, r=TaKO8Ki
09b8f72 
elf-raw-dylib: set type for functions

Avoids GNU ld warnings like:
```
type and size of dynamic symbol `meooooooooooooooow' are not defined
```
First noticed in rust-lang#152451 (comment) with changes from rust-lang#149937.
rust-timer added a commit that referenced this pull request Mar 2, 2026
@rust-timer
Unrolled build for #153090
82df08f 
Rollup merge of #153090 - mati865:elf-raw-dylib-fns, r=TaKO8Ki

elf-raw-dylib: set type for functions

Avoids GNU ld warnings like:
```
type and size of dynamic symbol `meooooooooooooooow' are not defined
```
First noticed in #152451 (comment) with changes from #149937.
@rust-bors

This comment has been minimized.

Sign in to view
@jyn514

jyn514 commented Mar 4, 2026

Copy link
Copy Markdown
Member Author 
+	error: could not exec the linker `D:\a\rust\rust\tests\ui/linking/auxiliary/fake-linker.ps1`
+	   = note: %1 is not a valid Win32 application. (os error 193)

hmmmmmmm
this is on Microsoft Windows Server 2025, maybe the problem is that the shell is set to cmd.exe instead of powershell? but i'm not sure why it wouldn't treat .ps1 as a powershell script...

maybe i can set the linker to powershell fake-linker.ps1 or something

@mati865

mati865 commented Mar 5, 2026

Copy link
Copy Markdown
Member

IIRC rust considers linker as a path, so that wouldn't work. I have no clue why it doesn't run ps script.

BTW, you should be able to get rid of ELF raw-dylib test changes because of #153090

@rustbot

rustbot commented Mar 5, 2026

Copy link
Copy Markdown
Collaborator

This PR was rebased onto a different main commit. Here's a range-diff highlighting what actually changed.

Rebasing is a normal part of keeping PRs up to date, so no action is needed—this note is just to help reviewers.

@rust-log-analyzer

This comment has been minimized.

Sign in to view
@jyn514

jyn514 commented Mar 5, 2026

Copy link
Copy Markdown
Member Author

@bors try job=x86_64-mingw-1

@rust-bors

This comment has been minimized.

Sign in to view
@ChrisDenton

ChrisDenton commented Mar 5, 2026

Copy link
Copy Markdown
Member

std::process::Command can only run .exe files on Windows because it uses CreateProcessW under the hood (well it can also run .bat scripts but that's undocumented). We'd need to change how rust runs the linker for powershell scripts to work.

@rust-bors

rust-bors Bot commented Mar 5, 2026

Copy link
Copy Markdown
Contributor

💔 Test for 950e78d failed: CI. Failed job:

@rust-log-analyzer

This comment has been minimized.

Sign in to view
@jyn514
Split out linker-info from linker-messages
20404bf 
- Hide common linker output behind `linker-info`
- Add tests
- Account for different capitalization on windows-gnu when removing
  "warning" prefix
- Add some more comments
- Add macOS deployment-target test
- Ignore linker warnings from trying to statically link glibc

  I don't know what's going on in `nofile-limit.rs` but I want no part
  of it.

- Use a fake linker so tests are platform-independent
@jyn514

jyn514 commented Mar 6, 2026

Copy link
Copy Markdown
Member Author

@bors try job=x86_64-mingw-1

@rust-bors

This comment has been minimized.

Sign in to view
@rust-bors

rust-bors Bot commented Mar 6, 2026

Copy link
Copy Markdown
Contributor

☀️ Try build successful (CI)
Build commit: b6b0c25 (b6b0c256e885dd32cfbcf93fbd2c0447da7afd3b, parent: f82485388963286763f8c8a9261ac227627f6a18)

@jyn514

jyn514 commented Mar 6, 2026

Copy link
Copy Markdown
Member Author

hell yeah

@rustbot ready

@mati865

mati865 commented Mar 6, 2026

Copy link
Copy Markdown
Member

@bors r+ rollup=iffy

@rust-bors

rust-bors Bot commented Mar 6, 2026

Copy link
Copy Markdown
Contributor

📌 Commit 20404bf has been approved by mati865

It is now in the queue for this repository.

@JonathanBrouwer JonathanBrouwer mentioned this pull request Mar 7, 2026
Merged
@jyn514 jyn514 mentioned this pull request Mar 16, 2026
Open
17 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@bjorn3 bjorn3 bjorn3 left review comments

@mati865 mati865 mati865 approved these changes

Assignees

@mati865 mati865

Labels

A-attributes Area: Attributes (`#[…]`, `#![…]`) A-CI Area: Our Github Actions CI A-run-make Area: port run-make Makefiles to rmake.rs A-testsuite Area: The testsuite used to check the correctness of rustc A-tidy Area: The tidy tool S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-bootstrap Relevant to the bootstrap subteam: Rust's build system (x.py and src/bootstrap) T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. T-infra Relevant to the infrastructure team, which will review and decide on the PR/issue.

Projects

None yet

Milestone

1.96.0

Development

Successfully merging this pull request may close these issues.