refactor(fmt): inline cache hashing

Author: chenjiahan

packages/rstack/src/fmt/cacheHash.ts

@@ -1,6 +1,6 @@
+import { hash as createDigest } from 'node:crypto';
 import { isAbsolute } from 'node:path';
 import stableStringify from 'fast-json-stable-stringify';
-import { createCacheHash } from './cacheHash.ts';
 import { fmtCacheVersion } from './cacheStore.ts';
 import { createRelativePathResolver, toPosixPath } from './pathHelpers.ts';
 import type { ResolvedFmtOptions } from './types.ts';
@@ -12,6 +12,10 @@ type CacheKeyResolver = (filePath: string) => string | undefined;
 type OptionsHasher = (options: ResolvedFmtOptions) => string | undefined;
 type PluginFingerprints = ReadonlyMap<string, string>;
 
+const cacheHashLength = 16;
+const createCacheHash = (content: string | Uint8Array): string =>
+  createDigest('sha256', content, 'base64url').slice(0, cacheHashLength);
+
 /** Identifies formatter behavior shared by all cache entries in this process. */
 const cacheNamespace: string = JSON.stringify([fmtCacheVersion, RSTACK_VERSION, PRETTIER_VERSION]);
 
@@ -63,4 +67,10 @@ const createOptionsHasher = (pluginFingerprints?: PluginFingerprints): OptionsHa
   };
 };
 
-export { cacheNamespace, createCacheKeyResolver, createOptionsHasher };
+export {
+  cacheHashLength,
+  cacheNamespace,
+  createCacheHash,
+  createCacheKeyResolver,
+  createOptionsHasher,
+};

packages/rstack/src/fmt/cacheIdentity.ts

@@ -1,7 +1,7 @@
 // Derived from @prettier/cli, see THIRD_PARTY_NOTICES.md
 
+import { hash } from 'node:crypto';
 import { readFileSync, writeFileSync } from 'node:fs';
-import { createCacheHash } from './cacheHash.ts';
 import type { FmtCacheEntry } from './cacheStore.ts';
 import { hasDottedBasename } from './pathHelpers.ts';
 import type { FmtFileCache, FmtFileRequest, FmtWorkerResult } from './types.ts';
@@ -12,6 +12,9 @@ interface FormatFileTask {
   cache?: FmtFileCache;
 }
 
+const hashContent = (content: string | Uint8Array): string =>
+  hash('sha256', content, 'base64url').slice(0, 16);
+
 /**
  * Use synchronous direct I/O inside the dedicated worker to avoid libuv
  * scheduling overhead. This prioritizes throughput over crash-safe replacement.
@@ -35,7 +38,7 @@ const formatFile = async ({
     }
 
     sourceBuffer = readFileSync(file.path);
-    contentHash = createCacheHash(sourceBuffer);
+    contentHash = hashContent(sourceBuffer);
     return sourceBuffer.toString('utf8');
   };
 
@@ -48,14 +51,14 @@ const formatFile = async ({
         }
       } else {
         sourceBuffer = readFileSync(file.path);
-        contentHash = createCacheHash(sourceBuffer);
+        contentHash = hashContent(sourceBuffer);
         if (entry[0] === contentHash) {
           return { status: 'unsupported' };
         }
       }
     } else {
       sourceBuffer = readFileSync(file.path);
-      contentHash = createCacheHash(sourceBuffer);
+      contentHash = hashContent(sourceBuffer);
       if (entry[0] === contentHash && (!shouldWrite || entry[2] === 'clean')) {
         return { status: entry[2] === 'clean' ? 'unchanged' : 'changed' };
       }
@@ -71,7 +74,7 @@ const formatFile = async ({
           cacheEntry: [
             hasDottedBasename(file.path)
               ? ''
-              : (contentHash ?? createCacheHash(sourceBuffer ?? readFileSync(file.path))),
+              : (contentHash ?? hashContent(sourceBuffer ?? readFileSync(file.path))),
             cache.optionsHash,
             'unsupported',
           ],
@@ -92,8 +95,8 @@ const formatFile = async ({
 
   const cacheHash =
     shouldWrite && !unchanged
-      ? createCacheHash(result.formatted)
-      : (contentHash ?? createCacheHash(result.source));
+      ? hashContent(result.formatted)
+      : (contentHash ?? hashContent(result.source));
   const cacheEntry: FmtCacheEntry = [
     cacheHash,
     cache.optionsHash,

packages/rstack/src/fmt/worker.ts

@@ -3,9 +3,10 @@ import { pathToFileURL } from 'node:url';
 import prettierPkgJson from 'prettier/package.json' with { type: 'json' };
 import { expect, test } from 'rstack/test';
 import pkgJson from '../../package.json' with { type: 'json' };
-import { cacheHashLength, createCacheHash } from '../../src/fmt/cacheHash.ts';
 import {
+  cacheHashLength,
   cacheNamespace,
+  createCacheHash,
   createCacheKeyResolver,
   createOptionsHasher,
 } from '../../src/fmt/cacheIdentity.ts';

packages/rstack/tests/fmt/cacheIdentity.test.ts

@@ -1,7 +1,6 @@
 import { existsSync, mkdirSync, readFileSync, readdirSync, writeFileSync } from 'node:fs';
 import path from 'node:path';
 import { expect, test } from 'rstack/test';
-import { createCacheHash } from '../../src/fmt/cacheHash.ts';
 import {
   fmtCacheFileName,
   fmtCacheVersion,
@@ -11,12 +10,12 @@ import {
 import { withTempProject } from './helpers.ts';
 
 const namespace = 'test-namespace';
-const contentA = createCacheHash('content-a');
-const contentB = createCacheHash('content-b');
-const contentC = createCacheHash('content-c');
-const optionsA = createCacheHash('options-a');
-const optionsB = createCacheHash('options-b');
-const optionsC = createCacheHash('options-c');
+const contentA = 'content-a';
+const contentB = 'content-b';
+const contentC = 'content-c';
+const optionsA = 'options-a';
+const optionsB = 'options-b';
+const optionsC = 'options-c';
 const firstEntry = [contentA, optionsA, 'clean'] as const;
 const secondEntry = [contentB, optionsB, 'dirty'] as const;
 const unsupportedEntry = ['', optionsC, 'unsupported'] as const;

packages/rstack/tests/fmt/cacheStore.test.ts

@@ -2,8 +2,12 @@ import { readFileSync, statSync, utimesSync, writeFileSync } from 'node:fs';
 import path from 'node:path';
 import { pathToFileURL } from 'node:url';
 import { expect, test } from 'rstack/test';
-import { cacheHashLength, createCacheHash } from '../../src/fmt/cacheHash.ts';
-import { cacheNamespace, createOptionsHasher } from '../../src/fmt/cacheIdentity.ts';
+import {
+  cacheHashLength,
+  cacheNamespace,
+  createCacheHash,
+  createOptionsHasher,
+} from '../../src/fmt/cacheIdentity.ts';
 import { loadFmtCacheStore } from '../../src/fmt/cacheStore.ts';
 import { runFmtFiles } from '../../src/fmt/runner.ts';
 import type { FmtCacheContext, FmtFileRequest, FmtMode } from '../../src/fmt/types.ts';

packages/rstack/tests/fmt/runnerCache.test.ts

@@ -1,7 +1,7 @@
 import path from 'node:path';
 import { readFileSync } from 'node:fs';
 import { expect, test } from 'rstack/test';
-import { createCacheHash } from '../../src/fmt/cacheHash.ts';
+import { createCacheHash } from '../../src/fmt/cacheIdentity.ts';
 import { formatFile } from '../../src/fmt/worker.ts';
 import { withTempProject, writeProjectFile } from './helpers.ts';