Skip to content

Commit e270f48

Browse files
committed
liteparse: carry forward riscv64 patches to 2.16.0
Nightly version bump omitted the patches/liteparse/<version> directory for 2.16.0, so the pdfium job's unconditional `git apply .../*.patch` step failed with "No such file or directory" before any build/test ran. Copied forward the same patch set from 2.15.1; it still applies to the chromium/8058 skia/BUILD.gn that 2.16.0 pins.
1 parent c327f9b commit e270f48

1 file changed

Lines changed: 19 additions & 0 deletions

File tree

Lines changed: 19 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,19 @@
1+
Upstream-Status: To upstream [not yet submitted; pdfium main's skia/BUILD.gn still lacks the riscv64 branch Chromium's copy has]
2+
3+
PDFium's skia/BUILD.gn asserts on every target CPU its skia_opts chain does not
4+
name, so `gn gen` fails for target_cpu = "riscv64" even with pdf_use_skia=false:
5+
the root BUILD.gn's gn_check group depends on //skia whenever checkout_skia is set,
6+
which it is for checkout_configuration=small. Chromium's own skia/BUILD.gn already
7+
carries this empty riscv64 branch (Skia's portable code path needs no extra flags).
8+
diff --git a/skia/BUILD.gn b/skia/BUILD.gn
9+
--- a/skia/BUILD.gn
10+
+++ b/skia/BUILD.gn
11+
@@ -560,6 +560,8 @@ skia_source_set("skia_opts") {
12+
# Conditional and empty body needed to avoid assert below
13+
} else if (current_cpu == "mipsel" || current_cpu == "mips64el") {
14+
cflags += [ "-fomit-frame-pointer" ]
15+
+ } else if (current_cpu == "riscv64") {
16+
+ # Conditional and empty body needed to avoid assert() below.
17+
} else {
18+
assert(false, "Unsupported target CPU " + current_cpu)
19+
}

0 commit comments

Comments
 (0)