Skip to content

Commit 7940a59

Browse files
committed
xgboost: resolve scikit-learn from the registry instead of compiling it
scikit-learn was deliberately absent from PIP_ONLY_BINARY because no riscv64 wheel existed, so pip fell back to its sdist and spent about 22 minutes of a 63 minute job compiling it in-container. #339 is merged and publishing 1.9.0, which is the version pip resolves to here, so adding it to the list forces the registry wheel and removes that compile. The test phase will fail until the publish lands: with scikit-learn in PIP_ONLY_BINARY there is no sdist fallback left, and xgboost.testing importorskips sklearn.datasets at module level, so the suite needs it.
1 parent 85b96e7 commit 7940a59

1 file changed

Lines changed: 6 additions & 6 deletions

File tree

‎.github/workflows/build-xgboost.yml‎

Lines changed: 6 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -72,12 +72,12 @@ jobs:
7272
env:
7373
CIBW_MANYLINUX_RISCV64_IMAGE: ${{ env.MANYLINUX_RISCV64_IMAGE }}
7474
CIBW_ENVIRONMENT: PIP_EXTRA_INDEX_URL=https://pypi.riseproject.dev/simple/
75-
# numpy/scipy/pandas resolve to our registry's riscv64 wheels rather
76-
# than to newer sdists on public PyPI. scikit-learn is deliberately
77-
# left out of the list: it has no riscv64 wheel anywhere yet, and the
78-
# whole suite skips without it (xgboost.testing importorskips
79-
# sklearn.datasets at module level), so it is compiled in-container.
80-
CIBW_TEST_ENVIRONMENT: PIP_ONLY_BINARY=numpy,scipy,pandas
75+
# Every scientific dependency resolves to our registry's riscv64 wheels
76+
# rather than to a newer sdist on public PyPI. scikit-learn is in the
77+
# list now that we publish it; without it pip compiled it in-container,
78+
# which the whole suite needs because xgboost.testing importorskips
79+
# sklearn.datasets at module level.
80+
CIBW_TEST_ENVIRONMENT: PIP_ONLY_BINARY=numpy,scipy,pandas,scikit-learn
8181
CIBW_TEST_REQUIRES: pytest hypothesis joblib pandas scikit-learn
8282
CIBW_TEST_SOURCES: tests/pytest.ini tests/python demo/data
8383
CIBW_TEST_COMMAND: >-

0 commit comments

Comments
 (0)