From 659816880bf86e92a623094bb4f86b7501cc9441 Mon Sep 17 00:00:00 2001 From: Zeyu Yang <40936154+zeyuyang42@users.noreply.github.com> Date: Sat, 17 Oct 2026 01:51:04 +0200 Subject: [PATCH] ci: a final release tag is not a prerelease The release job marked every release as a prerelease because it looked for a hyphen in the whole tag name, and max-v0.3.0 has one in its host prefix. Test the version part instead, so only a suffixed version (0.3.0-rc1) becomes a prerelease. Seen on the max-v0.3.0 draft, which was corrected by hand with gh release edit. Co-Authored-By: Claude Fable 5.1 --- .github/workflows/ci.yml | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/.github/workflows/ci.yml b/.github/workflows/ci.yml index 733667d..8a5b4b2 100644 --- a/.github/workflows/ci.yml +++ b/.github/workflows/ci.yml @@ -390,8 +390,10 @@ jobs: else notes_args=(--notes "Draft. Write $final and paste it here before publishing.") fi + # Prerelease only for a suffixed version (0.3.0-rc1): test the version, not the + # tag, whose host prefix (max-v, pd-v) always carries a hyphen. pre=() - case "$GITHUB_REF_NAME" in *-*) pre=(--prerelease) ;; esac + case "$VERSION" in *-*) pre=(--prerelease) ;; esac gh release create "$GITHUB_REF_NAME" --draft --verify-tag --title "$TITLE" \ "${notes_args[@]}" "${pre[@]}" assets/*.zip gh release view "$GITHUB_REF_NAME" --json isDraft,isPrerelease,assets \