From d06edba64bc5c90647dd4d0ae264b614ee4a8855 Mon Sep 17 00:00:00 2001 From: Christoph Knittel Date: Fri, 23 Oct 2026 07:15:03 +0000 Subject: [PATCH 1/2] Run the commit records tests in CI `yarn test-commit-records` ran nowhere in CI, so a change that broke the record parser or the Markdown comment passed and showed up only as wrong pages and comments on other pull requests. The renderer is platform independent, so the linux-arm64 job runs them. Signed-off-by: Christoph Knittel Co-Authored-By: Claude Opus 5.5 Claude-Session: https://claude.ai/code/session_01Xk6AeCYpCK4SZRtHYKHGoe --- .github/workflows/ci.yml | 6 ++++++ changes/commit-records-tests-in-ci.internal.md | 1 + 2 files changed, 7 insertions(+) create mode 100644 changes/commit-records-tests-in-ci.internal.md diff --git a/.github/workflows/ci.yml b/.github/workflows/ci.yml index 5eb9d76f21..beb0f67eb9 100644 --- a/.github/workflows/ci.yml +++ b/.github/workflows/ci.yml @@ -193,6 +193,12 @@ jobs: - name: Test release plan run: yarn test-release-plan + # The semantic diff renderer is platform-independent JavaScript, so one + # platform runs its tests. + - name: Test commit records + if: matrix.node-target == 'linux-arm64' + run: yarn test-commit-records + - name: Run tests run: node scripts/test.js -all diff --git a/changes/commit-records-tests-in-ci.internal.md b/changes/commit-records-tests-in-ci.internal.md new file mode 100644 index 0000000000..74f7843cb4 --- /dev/null +++ b/changes/commit-records-tests-in-ci.internal.md @@ -0,0 +1 @@ +- Run the semantic diff renderer's tests (`yarn test-commit-records`) in CI. From 890e98bb25011394df36784d51fdd8dae3a4268d Mon Sep 17 00:00:00 2001 From: Christoph Knittel Date: Fri, 23 Oct 2026 09:33:14 +0000 Subject: [PATCH 2/2] Select the commit records CI step with a matrix property Like the benchmarks and the playground build, the step is enabled by a property of its matrix entry instead of a condition on the node target. Signed-off-by: Christoph Knittel Co-Authored-By: Claude Opus 5.5 Claude-Session: https://claude.ai/code/session_01Xk6AeCYpCK4SZRtHYKHGoe --- .github/workflows/ci.yml | 5 ++--- 1 file changed, 2 insertions(+), 3 deletions(-) diff --git a/.github/workflows/ci.yml b/.github/workflows/ci.yml index beb0f67eb9..e30a5cc22c 100644 --- a/.github/workflows/ci.yml +++ b/.github/workflows/ci.yml @@ -50,6 +50,7 @@ jobs: build_playground: true generate_api_docs: true benchmarks: true + test_commit_records: true node-target: linux-arm64 rust-target: aarch64-unknown-linux-musl dune-profile: static @@ -193,10 +194,8 @@ jobs: - name: Test release plan run: yarn test-release-plan - # The semantic diff renderer is platform-independent JavaScript, so one - # platform runs its tests. - name: Test commit records - if: matrix.node-target == 'linux-arm64' + if: matrix.test_commit_records run: yarn test-commit-records - name: Run tests