You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
Commit 5d28d88
Browse filesBrowse the repository at this point in the historyBrowse files
Build Luv from the rescript-lang/luv fork with libuv 1.53.0
The opam override for Luv now fetches commit 8c12b1a of rescript-lang/luv
(PR rescript-lang/luv#2) instead of patching the upstream 0.5.14 tarball.
The fork vendors libuv 1.53.0 instead of 1.48.0 and already carries the
ARM64 musl -mno-outline-atomics fix, so the local patch is gone. The
package is versioned 0.5.14+rescript.1 and dune-project/rescript.opam pin
that version.
Review: Why a git URL and not a release tarball? The fork keeps libuv as a
git submodule; GitHub archives omit submodules, while opam's git fetch
initializes them. The commit hash should move to the merge commit once
rescript-lang/luv#2 lands.
Review: Does the OCaml rewatch use any changed Luv API? Only FS_event,
Loop, Timer, Handle and Error (native_watcher.ml). The fork's API change
(statfs reserved fields read as zero) does not reach it.
Area: rewatch ci
Output: unchanged
Tests: none, because no observable behavior changes; the shared rewatch
suite (113 checks, incl. watch mode), the rewatch-ocaml focused suite and
scripts/test.js -ounit -build -mocha -docstrings pass on the new libuv
Measured: watch edit latency, median of 21 interleaved edits (basic
fixture) 99 -> 100 ms, A/A control 98 ms; 400-directory fixture 98 -> 102
ms, A/A control 100 ms; watch cold start, median of 7 (400 dirs) 213 ->
211 ms, A/A 212 ms; idle watcher CPU over 20 s 70-90 ms for all; clean
build (400 modules), median of 9, 180 -> 180 ms; linux-arm64 devcontainer
under load, job tmp watch_ab.py and clean_ab.py
Signed-off-by: Christoph Knittel <ck@cca.io>
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01Q9Q6perkzKBQQebDnVXAEK
0 commit comments