From 69225aa4d39bd26e0ed1eca2ff1cac577efcabf2 Mon Sep 17 00:00:00 2001 From: Jan Richter Date: Fri, 2 Oct 2026 13:50:16 +0200 Subject: [PATCH] fix: github login locator error (#174) --- docs/changelog.md | 8 +++++++- package.json | 2 +- src/playwright/helpers/common.ts | 4 +--- 3 files changed, 9 insertions(+), 5 deletions(-) diff --git a/docs/changelog.md b/docs/changelog.md index bf3a340..3367130 100644 --- a/docs/changelog.md +++ b/docs/changelog.md @@ -2,7 +2,13 @@ All notable changes to this project will be documented in this file. -## [1.10.2] - Current +## [1.10.3] - Current + +### Fixed + +- **LoginHelper#logintoGithub**: remove wait for outdated locator, now simply waits for redirect to github homepage + +## [1.10.2] ### Fixed diff --git a/package.json b/package.json index 5605663..1fec5cd 100644 --- a/package.json +++ b/package.json @@ -1,6 +1,6 @@ { "name": "@red-hat-developer-hub/e2e-test-utils", - "version": "1.10.2", + "version": "1.10.3", "description": "Test utilities for RHDH E2E tests", "license": "Apache-2.0", "repository": { diff --git a/src/playwright/helpers/common.ts b/src/playwright/helpers/common.ts index 56787ac..4bd0fcc 100644 --- a/src/playwright/helpers/common.ts +++ b/src/playwright/helpers/common.ts @@ -75,9 +75,7 @@ export class LoginHelper { await this.page.fill("#app_totp", this.getGitHub2FAOTP(userid)); } - await this.page - .getByRole("heading", { name: "Home" }) - .waitFor({ timeout: 30_000 }); + await this.page.waitForURL("https://github.com/", { timeout: 20000 }); } async logintoKeycloak(popup: Page, userid: string, password: string) {