Move RecoverableError to its own target and the frameworks tier (#59027)

Summary:
Pull Request resolved: #59027

`cxxreact/RecoverableError.h` was exported only by `cxxreact:bridge` and guarded as private, so libraries could not use it under `RN_STRICT_API`, and the bridgeless Android runtime had to depend on the bridge to get it.

- Add a header-only `cxxreact:recoverableerror` target. The include path stays `<cxxreact/RecoverableError.h>`; `cxxreact:bridge` re-exports it for existing users.
- Move the header from the private tier to "for frameworks" (`FrameworksGuard.h`).
- `ReactAndroid`'s `runtime/jni` depends on `cxxreact:recoverableerror` instead of `cxxreact:bridge`.
- Remove the unused include from `Instance.cpp`.

Changelog:
[General][Changed] - Move `RecoverableError` from private headers to "for frameworks" headers

Reviewed By: cipolleschi

Differential Revision: D124957581

fbshipit-source-id: 647921290590d0b748e80f5161f87879d9c5b808

Author: j-piasecki

packages/react-native/ReactCommon/cxxreact/Instance.cpp

@@ -17,7 +17,6 @@
 #include "MethodCall.h"
 #include "NativeToJsBridge.h"
 #include "RAMBundleRegistry.h"
-#include "RecoverableError.h"
 #include "TraceSection.h"
 
 #include <folly/json.h>

packages/react-native/ReactCommon/cxxreact/RecoverableError.h

@@ -7,7 +7,7 @@
 
 #pragma once
 
-#include <react/cxxstableapi/PrivateGuard.h>
+#include <react/cxxstableapi/FrameworksGuard.h>
 
 #include <exception>
 #include <functional>

scripts/cxx-api/api-snapshots/ReactAndroidFrameworksCxx.api

@@ -6438,6 +6438,13 @@ struct facebook::react::ReadableType : public facebook::jni::JavaClass<facebook:
   public static jni::alias_ref<facebook::react::ReadableType> getType(folly::dynamic::Type type);
 }
 
+struct facebook::react::RecoverableError : public std::exception {
+  public RecoverableError(const std::string& what_);
+  public virtual const char* what() const noexcept override;
+  template <typename E>
+  public static void runRethrowingAsRecoverable(std::function<void()> act);
+}
+
 struct facebook::react::Rect {
   public bool containsPoint(facebook::react::Point point) noexcept;
   public bool operator==(const facebook::react::Rect& rhs) const noexcept = default;

scripts/cxx-api/api-snapshots/ReactAppleFrameworksCxx.api

@@ -8464,6 +8464,13 @@ struct facebook::react::ReactNativeVersionType {
   public std::string_view Prerelease;
 }
 
+struct facebook::react::RecoverableError : public std::exception {
+  public RecoverableError(const std::string& what_);
+  public virtual const char* what() const noexcept override;
+  template <typename E>
+  public static void runRethrowingAsRecoverable(std::function<void()> act);
+}
+
 struct facebook::react::Rect {
   public bool containsPoint(facebook::react::Point point) noexcept;
   public bool operator==(const facebook::react::Rect& rhs) const noexcept = default;

scripts/cxx-api/api-snapshots/ReactCommonFrameworksCxx.api

@@ -4620,6 +4620,13 @@ struct facebook::react::ReactNativeVersionType {
   public std::string_view Prerelease;
 }
 
+struct facebook::react::RecoverableError : public std::exception {
+  public RecoverableError(const std::string& what_);
+  public virtual const char* what() const noexcept override;
+  template <typename E>
+  public static void runRethrowingAsRecoverable(std::function<void()> act);
+}
+
 struct facebook::react::Rect {
   public Float getMaxX() const noexcept;
   public Float getMaxY() const noexcept;