Skip to content

Commit f054c67

Browse files
coadofacebook-github-bot
authored andcommitted
Classify react/renderer/animated internals as private (#58882)
Summary: All headers in `react/renderer/animated` were classified as "for frameworks". Most of them are implementation details of the C++ Native Animated engine: the concrete animation drivers, the concrete animated node types, and the `internal/` helpers. They are not part of the integration surface hosts use, and none of the remaining "for frameworks" headers includes them (the manager headers only forward-declare `AnimatedNode`, `AnimationDriver` and `AnimatedMountingOverrideDelegate`). This moves those 23 headers to the private tier: - `drivers/`: `AnimationDriver.h`, `AnimationDriverUtils.h`, `DecayAnimationDriver.h`, `FrameAnimationDriver.h`, `SpringAnimationDriver.h` - `internal/`: `AnimatedMountingOverrideDelegate.h`, `NativeAnimatedAllowlist.h`, `primitives.h` - `nodes/`: all concrete node types except the `AnimatedNode` base class Changelog: [Internal] Reviewed By: cortinico Differential Revision: D123404796
1 parent be5235d commit f054c67

23 files changed

Lines changed: 23 additions & 23 deletions

‎packages/react-native/ReactCommon/react/renderer/animated/drivers/AnimationDriver.h‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -5,7 +5,7 @@
55
* LICENSE file in the root directory of this source tree.
66
*/
77

8-
#include <react/cxxstableapi/FrameworksGuard.h>
8+
#include <react/cxxstableapi/PrivateGuard.h>
99

1010
/*
1111
* Adapted from react-native-windows under the MIT license.

‎packages/react-native/ReactCommon/react/renderer/animated/drivers/AnimationDriverUtils.h‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -5,7 +5,7 @@
55
* LICENSE file in the root directory of this source tree.
66
*/
77

8-
#include <react/cxxstableapi/FrameworksGuard.h>
8+
#include <react/cxxstableapi/PrivateGuard.h>
99

1010
/*
1111
* Adapted from react-native-windows under the MIT license.

‎packages/react-native/ReactCommon/react/renderer/animated/drivers/DecayAnimationDriver.h‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -5,7 +5,7 @@
55
* LICENSE file in the root directory of this source tree.
66
*/
77

8-
#include <react/cxxstableapi/FrameworksGuard.h>
8+
#include <react/cxxstableapi/PrivateGuard.h>
99

1010
/*
1111
* Adapted from react-native-windows under the MIT license.

‎packages/react-native/ReactCommon/react/renderer/animated/drivers/FrameAnimationDriver.h‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -5,7 +5,7 @@
55
* LICENSE file in the root directory of this source tree.
66
*/
77

8-
#include <react/cxxstableapi/FrameworksGuard.h>
8+
#include <react/cxxstableapi/PrivateGuard.h>
99

1010
/*
1111
* Adapted from react-native-windows under the MIT license.

‎packages/react-native/ReactCommon/react/renderer/animated/drivers/SpringAnimationDriver.h‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -5,7 +5,7 @@
55
* LICENSE file in the root directory of this source tree.
66
*/
77

8-
#include <react/cxxstableapi/FrameworksGuard.h>
8+
#include <react/cxxstableapi/PrivateGuard.h>
99

1010
/*
1111
* Adapted from react-native-windows under the MIT license.

‎packages/react-native/ReactCommon/react/renderer/animated/internal/AnimatedMountingOverrideDelegate.h‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -7,7 +7,7 @@
77

88
#pragma once
99

10-
#include <react/cxxstableapi/FrameworksGuard.h>
10+
#include <react/cxxstableapi/PrivateGuard.h>
1111

1212
#include <react/renderer/mounting/MountingOverrideDelegate.h>
1313
#include <react/renderer/mounting/MountingTransaction.h>

‎packages/react-native/ReactCommon/react/renderer/animated/internal/NativeAnimatedAllowlist.h‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -7,7 +7,7 @@
77

88
#pragma once
99

10-
#include <react/cxxstableapi/FrameworksGuard.h>
10+
#include <react/cxxstableapi/PrivateGuard.h>
1111

1212
#include <string>
1313
#include <unordered_set>

‎packages/react-native/ReactCommon/react/renderer/animated/internal/primitives.h‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -7,7 +7,7 @@
77

88
#pragma once
99

10-
#include <react/cxxstableapi/FrameworksGuard.h>
10+
#include <react/cxxstableapi/PrivateGuard.h>
1111

1212
#include <React/RendererCore.h>
1313

‎packages/react-native/ReactCommon/react/renderer/animated/nodes/AdditionAnimatedNode.h‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -5,7 +5,7 @@
55
* LICENSE file in the root directory of this source tree.
66
*/
77

8-
#include <react/cxxstableapi/FrameworksGuard.h>
8+
#include <react/cxxstableapi/PrivateGuard.h>
99

1010
/*
1111
* Adapted from react-native-windows under the MIT license.

‎packages/react-native/ReactCommon/react/renderer/animated/nodes/ColorAnimatedNode.h‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -5,7 +5,7 @@
55
* LICENSE file in the root directory of this source tree.
66
*/
77

8-
#include <react/cxxstableapi/FrameworksGuard.h>
8+
#include <react/cxxstableapi/PrivateGuard.h>
99

1010
/*
1111
* Adapted from react-native-windows under the MIT license.

0 commit comments

Comments
 (0)