Remove RuntimeSchedulerCallInvoker

Summary:
Remove the deprecated `RuntimeSchedulerCallInvoker` implementation now that
React instances expose their buffered `CallInvoker`. Make that invoker available
through the runtime binding and migrate remaining consumers to use it.

Changelog:
[General][Breaking] - Remove the deprecated `RuntimeSchedulerCallInvoker` API

Differential Revision: D123627753

Author: javache

packages/react-native/ReactCommon/react/renderer/runtimescheduler/RuntimeSchedulerCallInvoker.cpp

@@ -21,12 +21,10 @@ void CallInvokerImpl::invokeAsync(CallFunc&& func) noexcept {
   // Held for the duration of the call: `BufferedRuntimeExecutor` reaches the
   // scheduler through a raw pointer, which is only safe while the instance that
   // owns it is alive. A CallInvoker outlives its instance routinely — a caller
-  // can hold one across a reload — so the weak reference is what keeps this
-  // from dispatching into a destroyed scheduler. Dropping the work matches what
-  // `RuntimeSchedulerCallInvoker` does once its scheduler is gone.
+  // can hold one across a reload — so guard dispatch with the weak scheduler.
+  // If it has expired, there is no runtime left to receive the work.
   if (auto runtimeScheduler = runtimeScheduler_.lock()) {
-    // No priority given, so this takes the executor's default — matching what
-    // `RuntimeSchedulerCallInvoker` did via `scheduleWork`.
+    // No priority was given, so use the executor's default.
     bufferedRuntimeExecutor_->execute(std::move(func));
   }
 }

packages/react-native/ReactCommon/react/renderer/runtimescheduler/RuntimeSchedulerCallInvoker.h

@@ -51,6 +51,7 @@ struct ReactInstanceData {
   std::shared_ptr<NativeAnimatedNodesManagerProvider>
       animatedNodesManagerProvider;
   ReactInstance::BindingsInstallFunc bindingsInstallFunc;
+  ReactHost::CallInvokerBindingsInstallFunc callInvokerBindingsInstallFunc;
   std::shared_ptr<AnimationChoreographer> animationChoreographer;
 };
 
@@ -67,7 +68,8 @@ ReactHost::ReactHost(
     std::shared_ptr<NativeAnimatedNodesManagerProvider>
         animatedNodesManagerProvider,
     ReactInstance::BindingsInstallFunc bindingsInstallFunc,
-    std::shared_ptr<AnimationChoreographer> animationChoreographer)
+    std::shared_ptr<AnimationChoreographer> animationChoreographer,
+    CallInvokerBindingsInstallFunc callInvokerBindingsInstallFunc)
     : reactInstanceConfig_(std::move(reactInstanceConfig)) {
   auto componentRegistryFactory =
       mountingManager->getComponentRegistryFactory();
@@ -84,6 +86,8 @@ ReactHost::ReactHost(
       .logBoxSurfaceDelegate = logBoxSurfaceDelegate,
       .animatedNodesManagerProvider = animatedNodesManagerProvider,
       .bindingsInstallFunc = std::move(bindingsInstallFunc),
+      .callInvokerBindingsInstallFunc =
+          std::move(callInvokerBindingsInstallFunc),
       .animationChoreographer = std::move(animationChoreographer)});
   if (!reactInstanceData_->contextContainer
            ->find<MessageQueueThreadFactory>(MessageQueueThreadFactoryKey)
@@ -278,6 +282,9 @@ void ReactHost::createReactInstance() {
            std::weak_ptr<IMountingManager>(reactInstanceData_->mountingManager),
        logger = reactInstanceData_->logger,
        bindingsInstallFunc = reactInstanceData_->bindingsInstallFunc,
+       callInvokerBindingsInstallFunc =
+           reactInstanceData_->callInvokerBindingsInstallFunc,
+       jsInvoker,
        turboModuleManager =
            std::move(turboModuleManager)](jsi::Runtime& runtime) mutable {
         if (logger) {
@@ -299,6 +306,9 @@ void ReactHost::createReactInstance() {
         if (bindingsInstallFunc) {
           bindingsInstallFunc(runtime);
         }
+        if (callInvokerBindingsInstallFunc) {
+          callInvokerBindingsInstallFunc(runtime, jsInvoker);
+        }
       });
 }
 

packages/react-native/ReactCommon/react/runtime/CallInvokerImpl.cpp

@@ -41,6 +41,9 @@ struct ReactInstanceData;
 
 class ReactHost {
  public:
+  using CallInvokerBindingsInstallFunc =
+      std::function<void(jsi::Runtime &runtime, std::shared_ptr<CallInvoker> callInvoker)>;
+
   ReactHost(
       ReactInstanceConfig reactInstanceConfig,
       std::shared_ptr<IMountingManager> mountingManager,
@@ -53,7 +56,8 @@ class ReactHost {
       std::shared_ptr<SurfaceDelegate> logBoxSurfaceDelegate = nullptr,
       std::shared_ptr<NativeAnimatedNodesManagerProvider> animatedNodesManagerProvider = nullptr,
       ReactInstance::BindingsInstallFunc bindingsInstallFunc = nullptr,
-      std::shared_ptr<AnimationChoreographer> animationChoreographer = nullptr);
+      std::shared_ptr<AnimationChoreographer> animationChoreographer = nullptr,
+      CallInvokerBindingsInstallFunc callInvokerBindingsInstallFunc = nullptr);
   ReactHost(const ReactHost &) = delete;
   ReactHost &operator=(const ReactHost &) = delete;
   ReactHost(ReactHost &&) noexcept = delete;

packages/react-native/ReactCxxPlatform/react/runtime/ReactHost.cpp

@@ -4470,13 +4470,6 @@ class facebook::react::RuntimeSchedulerBinding : public facebook::jsi::HostObjec
   public virtual facebook::jsi::Value get(facebook::jsi::Runtime& runtime, const facebook::jsi::PropNameID& name) override;
 }
 
-class facebook::react::RuntimeSchedulerCallInvoker : public facebook::react::CallInvoker {
-  public RuntimeSchedulerCallInvoker(std::weak_ptr<facebook::react::RuntimeScheduler> runtimeScheduler);
-  public virtual void invokeAsync(facebook::react::CallFunc&& func) noexcept override;
-  public virtual void invokeAsync(facebook::react::SchedulerPriority priority, facebook::react::CallFunc&& func) noexcept override;
-  public virtual void invokeSync(facebook::react::CallFunc&& func) override;
-}
-
 class facebook::react::RuntimeSchedulerEventTimingDelegate {
   public virtual void dispatchPendingEventTimingEntries(facebook::react::HighResTimeStamp taskEndTime, const std::unordered_set<facebook::react::SurfaceId>& surfaceIdsWithPendingRenderingUpdates) = 0;
   public virtual ~RuntimeSchedulerEventTimingDelegate() = default;

packages/react-native/ReactCxxPlatform/react/runtime/ReactHost.h

@@ -4314,13 +4314,6 @@ class facebook::react::RuntimeSchedulerBinding : public facebook::jsi::HostObjec
   public virtual facebook::jsi::Value get(facebook::jsi::Runtime& runtime, const facebook::jsi::PropNameID& name) override;
 }
 
-class facebook::react::RuntimeSchedulerCallInvoker : public facebook::react::CallInvoker {
-  public RuntimeSchedulerCallInvoker(std::weak_ptr<facebook::react::RuntimeScheduler> runtimeScheduler);
-  public virtual void invokeAsync(facebook::react::CallFunc&& func) noexcept override;
-  public virtual void invokeAsync(facebook::react::SchedulerPriority priority, facebook::react::CallFunc&& func) noexcept override;
-  public virtual void invokeSync(facebook::react::CallFunc&& func) override;
-}
-
 class facebook::react::RuntimeSchedulerEventTimingDelegate {
   public virtual void dispatchPendingEventTimingEntries(facebook::react::HighResTimeStamp taskEndTime, const std::unordered_set<facebook::react::SurfaceId>& surfaceIdsWithPendingRenderingUpdates) = 0;
   public virtual ~RuntimeSchedulerEventTimingDelegate() = default;

scripts/cxx-api/api-snapshots/ReactAndroidDebugCxx.api

@@ -4467,13 +4467,6 @@ class facebook::react::RuntimeSchedulerBinding : public facebook::jsi::HostObjec
   public virtual facebook::jsi::Value get(facebook::jsi::Runtime& runtime, const facebook::jsi::PropNameID& name) override;
 }
 
-class facebook::react::RuntimeSchedulerCallInvoker : public facebook::react::CallInvoker {
-  public RuntimeSchedulerCallInvoker(std::weak_ptr<facebook::react::RuntimeScheduler> runtimeScheduler);
-  public virtual void invokeAsync(facebook::react::CallFunc&& func) noexcept override;
-  public virtual void invokeAsync(facebook::react::SchedulerPriority priority, facebook::react::CallFunc&& func) noexcept override;
-  public virtual void invokeSync(facebook::react::CallFunc&& func) override;
-}
-
 class facebook::react::RuntimeSchedulerEventTimingDelegate {
   public virtual void dispatchPendingEventTimingEntries(facebook::react::HighResTimeStamp taskEndTime, const std::unordered_set<facebook::react::SurfaceId>& surfaceIdsWithPendingRenderingUpdates) = 0;
   public virtual ~RuntimeSchedulerEventTimingDelegate() = default;

scripts/cxx-api/api-snapshots/ReactAndroidNewarchCxx.api

@@ -6628,13 +6628,6 @@ class facebook::react::RuntimeSchedulerBinding : public facebook::jsi::HostObjec
   public virtual facebook::jsi::Value get(facebook::jsi::Runtime& runtime, const facebook::jsi::PropNameID& name) override;
 }
 
-class facebook::react::RuntimeSchedulerCallInvoker : public facebook::react::CallInvoker {
-  public RuntimeSchedulerCallInvoker(std::weak_ptr<facebook::react::RuntimeScheduler> runtimeScheduler);
-  public virtual void invokeAsync(facebook::react::CallFunc&& func) noexcept override;
-  public virtual void invokeAsync(facebook::react::SchedulerPriority priority, facebook::react::CallFunc&& func) noexcept override;
-  public virtual void invokeSync(facebook::react::CallFunc&& func) override;
-}
-
 class facebook::react::RuntimeSchedulerEventTimingDelegate {
   public virtual void dispatchPendingEventTimingEntries(facebook::react::HighResTimeStamp taskEndTime, const std::unordered_set<facebook::react::SurfaceId>& surfaceIdsWithPendingRenderingUpdates) = 0;
   public virtual ~RuntimeSchedulerEventTimingDelegate() = default;

scripts/cxx-api/api-snapshots/ReactAndroidReleaseCxx.api

@@ -6504,13 +6504,6 @@ class facebook::react::RuntimeSchedulerBinding : public facebook::jsi::HostObjec
   public virtual facebook::jsi::Value get(facebook::jsi::Runtime& runtime, const facebook::jsi::PropNameID& name) override;
 }
 
-class facebook::react::RuntimeSchedulerCallInvoker : public facebook::react::CallInvoker {
-  public RuntimeSchedulerCallInvoker(std::weak_ptr<facebook::react::RuntimeScheduler> runtimeScheduler);
-  public virtual void invokeAsync(facebook::react::CallFunc&& func) noexcept override;
-  public virtual void invokeAsync(facebook::react::SchedulerPriority priority, facebook::react::CallFunc&& func) noexcept override;
-  public virtual void invokeSync(facebook::react::CallFunc&& func) override;
-}
-
 class facebook::react::RuntimeSchedulerEventTimingDelegate {
   public virtual void dispatchPendingEventTimingEntries(facebook::react::HighResTimeStamp taskEndTime, const std::unordered_set<facebook::react::SurfaceId>& surfaceIdsWithPendingRenderingUpdates) = 0;
   public virtual ~RuntimeSchedulerEventTimingDelegate() = default;