Merge main to resolve the already-landed E2E stack changes

Author: cipolleschi

.github/workflows/maestro-cloud-rntester.yml

@@ -170,34 +170,6 @@ jobs:
           use-prebuilds: true
           flavor: ${{ matrix.flavor }}
 
-  test_maestro_cloud_ios:
-    needs: test_ios_rntester
-    # test_ios_rntester is continue-on-error. If its Release artifact is missing,
-    # the reusable workflow fails explicitly while downloading or validating it.
-    # Maestro Cloud tests are temporarily disabled. Remove `false &&` to re-enable.
-    if: |
-      false &&
-      needs.test_ios_rntester.result == 'success' &&
-      (
-        (github.event_name == 'push' && github.ref == 'refs/heads/main') ||
-        (
-          github.event_name == 'pull_request' &&
-          github.event.pull_request.head.repo.full_name == github.repository &&
-          github.actor != 'dependabot[bot]'
-        )
-      )
-    uses: ./.github/workflows/maestro-cloud-rntester.yml
-    with:
-      platform: iOS
-      artifact-name: RNTesterApp-NewArch-Release
-      download-path: /tmp/RNTesterBuild/RNTester.app
-      app-file: /tmp/RNTesterBuild/RNTester.app
-      app-id: com.meta.RNTester.localDevelopment
-      device-model: iPhone-17-Pro
-      device-os: iOS-26-2
-      exclude-tags: android-only,local-screenshot-baseline
-    secrets: inherit
-
   test_e2e_ios_rntester:
     needs: test_ios_rntester
     if: ${{ needs.test_ios_rntester.result == 'success' }}
@@ -384,30 +356,6 @@ jobs:
           release-type: ${{ needs.set_release_type.outputs.RELEASE_TYPE }}
           gradle-cache-encryption-key: ${{ secrets.GRADLE_CACHE_ENCRYPTION_KEY }}
 
-  test_maestro_cloud_android:
-    needs: build_android
-    # Maestro Cloud tests are temporarily disabled. Remove `false &&` to re-enable.
-    if: |
-      false &&
-      needs.build_android.result == 'success' &&
-      (
-        (github.event_name == 'push' && github.ref == 'refs/heads/main') ||
-        (
-          github.event_name == 'pull_request' &&
-          github.event.pull_request.head.repo.full_name == github.repository &&
-          github.actor != 'dependabot[bot]'
-        )
-      )
-    uses: ./.github/workflows/maestro-cloud-rntester.yml
-    with:
-      platform: Android
-      artifact-name: rntester-release
-      download-path: /tmp/rntester-android
-      app-file: /tmp/rntester-android/app-arm64-v8a-release.apk
-      app-id: com.facebook.react.uiapp
-      exclude-tags: ios-only,local-screenshot-baseline
-    secrets: inherit
-
   test_e2e_android_rntester:
     needs: build_android
     if: ${{ needs.build_android.result == 'success' }}

.github/workflows/test-all.yml

@@ -43,17 +43,17 @@ JavaScript CI is the `lint`, `test_js`, and `build_js_types` jobs in [`.github/w
 
 The formatting command uses pinned npm packages for Kotlin and Java and installs pinned Ruff through Python. To format every language, install a JDK with Java 17 or newer, Python 3 with pip, and a Swift 6.3 or newer toolchain in addition to Node and Yarn. Each language wrapper checks its own requirements and prints installation guidance when something is missing; `yarn format` then skips that language and continues formatting the others. Swift formatting accepts either `swift-format` or `swift format` from the installed toolchain.
 
-### Verification: Running RNTester
-
-Needed only for changes that have to be seen running, such as user interface behavior.
-
-`yarn start` serves [RNTester](packages/rn-tester/README.md) over Metro at `http://localhost:8081`; `yarn android` builds and installs it on Android. Check the bundler with `curl "http://localhost:8081/js/RNTesterApp.bundle?platform=ios&dev=true"`.
-
 ## Gotchas
 
 - `yarn install` dirties the working tree: a `preinstall` hook (`scripts/try-set-hermes-compiler-prebuilt.js`) resolves the `hermes-compiler` placeholder in `packages/react-native/package.json` (`0.0.0` → a real version) and touches `yarn.lock`. Expected — do not commit it.
 - Metro cannot bundle until codegen is built once — `yarn --cwd packages/react-native-codegen build`. Without it, bundling fails with `Cannot find module '@react-native/codegen/lib/parsers/flow/parser'`. Every other package runs from source — `yarn build` is not needed for development (see [`scripts/build/README.md`](scripts/build/README.md)).
 
+## Verification: Running RNTester
+
+Needed only for changes that have to be seen running, such as user interface behavior.
+
+`yarn start` serves [RNTester](packages/rn-tester/README.md) over Metro at `http://localhost:8081`; `yarn android` builds and installs it on Android. Check the bundler with `curl "http://localhost:8081/js/RNTesterApp.bundle?platform=ios&dev=true"`.
+
 ## Generated code
 
 Never hand-edit generated output — change the source and regenerate. CI validates the committed snapshots.
@@ -64,6 +64,14 @@ Never hand-edit generated output — change the source and regenerate. CI valida
 - The public native API is snapshotted as well: C++ under `scripts/cxx-api` (`yarn cxx-api-build`), and Android in `packages/react-native/ReactAndroid/api/ReactAndroid.api`.
 - `CHANGELOG.md` is compiled at release time from pull request descriptions.
 
+## Flow types for npm packages
+
+`node_modules` is a `[declarations]` path in `.flowconfig`: Flow reads a package's own Flow types when it ships them (`metro` does), and otherwise the import is untyped, which `@flow strict` and `strict-local` files reject with `untyped-import`. A package used from Flow source for the first time needs a libdef in `flow-typed/npm/`, which overrides anything in `node_modules`:
+
+- Name it `<package>_v<major>.x.x.js` for the major in `package.json`, under `@<scope>/` for a scoped package.
+- Copy the shape of a neighbor: the license header, `@flow strict`, and `declare module '<package>' { … }` with `declare module.exports` or `declare export`. Declare only the surface the repo calls, typed as the package documents it, never `any`.
+- Check with `yarn flow-check`, and drop the libdef with the last use of the package.
+
 ## Contributing guidelines
 
 - Keep each change focused — no unrelated refactors, formatting, or dependency updates.

AGENTS.md

@@ -2422,8 +2422,8 @@ declare module 'fs' {
       options?: GlobOptions<WithFileTypes>,
     ): Node$Conditional<
       WithFileTypes,
-      AsyncIterator<Dirent>,
-      AsyncIterator<string>,
+      AsyncIteratorObject<Dirent>,
+      AsyncIteratorObject<string>,
     >,
     lchmod(path: FSPromisePath, mode: number): Promise<void>,
     lchown(path: FSPromisePath, uid: number, guid: number): Promise<void>,
@@ -2533,7 +2533,7 @@ declare module 'fs' {
         maxQueue?: number,
         overflow?: 'ignore' | 'throw',
       }>,
-    ): AsyncIterator<{eventType: string, filename: ?string}>,
+    ): AsyncIteratorObject<{eventType: string, filename: ?string}>,
     write<T extends Buffer | Uint8Array>(
       filehandle: FileHandle,
       buffer: T,
@@ -4271,7 +4271,7 @@ declare module 'timers/promises' {
     delay?: number,
     value?: T,
     options?: TimerOptions,
-  ): AsyncIterator<T>;
+  ): AsyncIteratorObject<T>;
 
   declare export var scheduler: Readonly<{
     wait(delay: number, options?: TimerOptions): Promise<void>,

flow-typed/environment/node.js

@@ -96,6 +96,7 @@ it('handles rgb properly', () => {
   expect(normalizeColor('rgb(0 0 0 / 0.5)')).toBe(0x00000080);
   expect(normalizeColor('rgb(0 0 0 / 1)')).toBe(0x000000ff);
   expect(normalizeColor('rgb(0, 0, 0, 0.5)')).toBe(0x00000080);
+  expect(normalizeColor('rgb(0 0 0 / 50%)')).toBe(0x00000080);
 });
 
 it('handles rgba properly', () => {
@@ -110,6 +111,8 @@ it('handles rgba properly', () => {
   expect(normalizeColor('rgba(0 0 0 / 1)')).toBe(0x000000ff);
   expect(normalizeColor('rgba(100 15 69 / 0.5)')).toBe(0x640f4580);
   expect(normalizeColor('rgba(0, 0, 0)')).toBe(0x000000ff);
+  expect(normalizeColor('rgba(0, 0, 0, 50%)')).toBe(0x00000080);
+  expect(normalizeColor('rgba(0 0 0 / 100%)')).toBe(0x000000ff);
 });
 
 it('handles hsl properly', () => {
@@ -125,6 +128,9 @@ it('handles hsl properly', () => {
   expect(normalizeColor('hsl(0 0% 0%)')).toBe(0x000000ff);
   expect(normalizeColor('hsl(360 100% 100%)')).toBe(0xffffffff);
   expect(normalizeColor('hsl(180 50% 50%)')).toBe(0x40bfbfff);
+  expect(normalizeColor('hsl(180 50% 50% / 0.2)')).toBe(0x40bfbf33);
+  expect(normalizeColor('hsl(180 50% 50% / 20%)')).toBe(0x40bfbf33);
+  expect(normalizeColor('hsl(180, 50%, 50%, 0.2)')).toBe(0x40bfbf33);
 });
 
 it('handles hsla properly', () => {
@@ -136,6 +142,8 @@ it('handles hsla properly', () => {
   expect(normalizeColor('hsla(360 100% 100% / 1)')).toBe(0xffffffff);
   expect(normalizeColor('hsla(360 100% 100% / 0)')).toBe(0xffffff00);
   expect(normalizeColor('hsla(180 50% 50% / 0.2)')).toBe(0x40bfbf33);
+  expect(normalizeColor('hsla(180, 50%, 50%, 20%)')).toBe(0x40bfbf33);
+  expect(normalizeColor('hsla(180, 50%, 50%)')).toBe(0x40bfbfff);
 });
 
 it('handles hwb properly', () => {
@@ -149,6 +157,7 @@ it('handles hwb properly', () => {
   expect(normalizeColor('hwb(70 50% 0%)')).toBe(0xeaff80ff);
   expect(normalizeColor('hwb(0, 0%, 100%)')).toBe(null);
   expect(normalizeColor('hwb(200 30% 20% / 0.5)')).toBe(0x4da1cc80);
+  expect(normalizeColor('hwb(200 30% 20% / 50%)')).toBe(0x4da1cc80);
 });
 
 it('handles named colors properly', () => {

packages/normalize-color/__tests__/normalizeColor-test.js

@@ -123,40 +123,39 @@ function parseColorString(color) {
     );
   }
 
-  if ((match = matchers.hsl.exec(color))) {
-    return (
-      (hslToRgb(
-        parse360(match[1]), // h
-        parsePercentage(match[2]), // s
-        parsePercentage(match[3]), // l
-      ) |
-        0x000000ff) >>> // a
-      0
-    );
-  }
-
-  if ((match = matchers.hsla.exec(color))) {
-    // hsla(H S L / A) notation
-    if (match[6] !== undefined) {
+  if ((match = matchers.hsla.exec(color) || matchers.hsl.exec(color))) {
+    // hsl(H S L / A) / hsla(H S L / A) notation
+    if (match[9] !== undefined) {
       return (
         (hslToRgb(
-          parse360(match[6]), // h
-          parsePercentage(match[7]), // s
-          parsePercentage(match[8]), // l
+          parse360(match[9]), // h
+          parsePercentage(match[10]), // s
+          parsePercentage(match[11]), // l
         ) |
-          parse1(match[9])) >>> // a
+          parse1(match[12])) >>> // a
         0
       );
     }
-
-    // hsla(H, S, L, A) notation
+    // hsl(H, S, L, A) / hsla(H, S, L, A) notation
+    else if (match[5] !== undefined) {
+      return (
+        (hslToRgb(
+          parse360(match[5]), // h
+          parsePercentage(match[6]), // s
+          parsePercentage(match[7]), // l
+        ) |
+          parse1(match[8])) >>> // a
+        0
+      );
+    }
+    // hsl(H, S, L) / hsla(H, S, L) notation
     return (
       (hslToRgb(
         parse360(match[2]), // h
         parsePercentage(match[3]), // s
         parsePercentage(match[4]), // l
       ) |
-        parse1(match[5])) >>> // a
+        0x000000ff) >>> // a
       0
     );
   }
@@ -242,6 +241,7 @@ function hwbToRgb(h, w, b) {
 
 const NUMBER = '[-+]?\\d*\\.?\\d+';
 const PERCENTAGE = NUMBER + '%';
+const ALPHA = NUMBER + '%?';
 
 function call(...args) {
   return '\\(\\s*(' + args.join(')\\s*,?\\s*(') + ')\\s*\\)';
@@ -272,26 +272,26 @@ function getMatchers() {
     const rgbRegexPattern =
       call(NUMBER, NUMBER, NUMBER) +
       '|' +
-      commaSeparatedCall(NUMBER, NUMBER, NUMBER, NUMBER) +
+      commaSeparatedCall(NUMBER, NUMBER, NUMBER, ALPHA) +
+      '|' +
+      callWithSlashSeparator(NUMBER, NUMBER, NUMBER, ALPHA);
+    const hslRegexPattern =
+      call(NUMBER, PERCENTAGE, PERCENTAGE) +
+      '|' +
+      commaSeparatedCall(NUMBER, PERCENTAGE, PERCENTAGE, ALPHA) +
       '|' +
-      callWithSlashSeparator(NUMBER, NUMBER, NUMBER, NUMBER);
+      callWithSlashSeparator(NUMBER, PERCENTAGE, PERCENTAGE, ALPHA);
 
     cachedMatchers = {
       rgb: new RegExp('^rgb(' + rgbRegexPattern + ')$'),
       rgba: new RegExp('^rgba(' + rgbRegexPattern + ')$'),
-      hsl: new RegExp('^hsl' + call(NUMBER, PERCENTAGE, PERCENTAGE) + '$'),
-      hsla: new RegExp(
-        '^hsla(' +
-          commaSeparatedCall(NUMBER, PERCENTAGE, PERCENTAGE, NUMBER) +
-          '|' +
-          callWithSlashSeparator(NUMBER, PERCENTAGE, PERCENTAGE, NUMBER) +
-          ')$',
-      ),
+      hsl: new RegExp('^hsl(' + hslRegexPattern + ')$'),
+      hsla: new RegExp('^hsla(' + hslRegexPattern + ')$'),
       hwb: new RegExp(
         '^hwb(' +
           callModern(NUMBER, PERCENTAGE, PERCENTAGE) +
           '|' +
-          callWithSlashSeparator(NUMBER, PERCENTAGE, PERCENTAGE, NUMBER) +
+          callWithSlashSeparator(NUMBER, PERCENTAGE, PERCENTAGE, ALPHA) +
           ')$',
       ),
       hex3: /^#([0-9a-fA-F]{1})([0-9a-fA-F]{1})([0-9a-fA-F]{1})$/,
@@ -320,7 +320,7 @@ function parse360(str) {
 }
 
 function parse1(str) {
-  const num = parseFloat(str);
+  const num = str.endsWith('%') ? parseFloat(str) / 100 : parseFloat(str);
   if (num < 0) {
     return 0;
   }