Reach public modules through umbrellas from unguarded exported headers (#59026)

Summary:

Several exported headers without a stable API guard included fine-grained headers of public modules directly. They are preprocessed in the including translation unit, so under `RN_STRICT_API` any app or library including them hits the public module's `UmbrellaGuard.h` `#error`. Switch them to the module umbrellas:

- iOS `RCTCallInvoker.h`, `RCTBridgeProxy+Cxx.h`: `<React/CallInvoker.h>`; `NSDataBigString.h`: `<React/JSBigString.h>`.
- Android `react/fabric/AnimatedPropBufferEncoder.h`: `<React/RendererCore.h>`; `react/runtime/jni/JJSTimerExecutor.h`, `JReactInstance.h`: `<React/RuntimeExecutor.h>`.
- ReactCxxPlatform `ImageLoaderModule.h`, `NativeExceptionsManager.h`: `<React/Bridging.h>`; `IMountingManager.h`, `RunLoopObserverManager.h`: `<React/RendererCore.h>`; `ReactHost.h`: `<React/CallInvoker.h>`, `<React/NativeModuleCore.h>`; `ReactInstanceConfig.h`: `<React/Debug.h>`.

Each umbrella is a superset of the header it replaces, so no declarations are lost. Includes of "for frameworks" headers stay direct. The guards are inert without `RN_STRICT_API`.

Changelog: [Internal]

Reviewed By: christophpurrer

Differential Revision: D124323428

Author: coado

packages/react-native/React/Base/RCTBridgeProxy+Cxx.h

@@ -6,7 +6,7 @@
  */
 
 #ifdef __cplusplus
-#import <ReactCommon/CallInvoker.h>
+#import <React/CallInvoker.h>
 #endif
 
 #import "RCTBridgeProxy.h"

packages/react-native/React/Base/RCTCallInvoker.h

@@ -8,7 +8,7 @@
 #import <Foundation/Foundation.h>
 
 #ifdef __cplusplus
-#import <ReactCommon/CallInvoker.h>
+#import <React/CallInvoker.h>
 #endif
 
 NS_ASSUME_NONNULL_BEGIN

packages/react-native/React/CxxBridge/NSDataBigString.h

@@ -7,7 +7,7 @@
 
 #import <Foundation/Foundation.h>
 
-#include <cxxreact/JSBigString.h>
+#include <React/JSBigString.h>
 
 namespace facebook::react {
 

packages/react-native/ReactAndroid/src/main/jni/react/fabric/AnimatedPropBufferEncoder.h

@@ -7,8 +7,8 @@
 
 #pragma once
 
+#include <React/RendererCore.h>
 #include <react/renderer/animationbackend/AnimatedProps.h>
-#include <react/renderer/core/ReactPrimitives.h>
 #include <unordered_map>
 #include <vector>
 

packages/react-native/ReactAndroid/src/main/jni/react/runtime/jni/JJSTimerExecutor.h

@@ -7,7 +7,7 @@
 
 #pragma once
 
-#include <ReactCommon/RuntimeExecutor.h>
+#include <React/RuntimeExecutor.h>
 #include <fbjni/fbjni.h>
 #include <jni.h>
 #include <react/jni/WritableNativeArray.h>

packages/react-native/ReactAndroid/src/main/jni/react/runtime/jni/JReactInstance.h

@@ -7,9 +7,9 @@
 
 #pragma once
 
+#include <React/RuntimeExecutor.h>
 #include <ReactCommon/CallInvokerHolder.h>
 #include <ReactCommon/NativeMethodCallInvokerHolder.h>
-#include <ReactCommon/RuntimeExecutor.h>
 #include <fbjni/fbjni.h>
 #include <jni.h>
 #include <jsi/jsi.h>

packages/react-native/ReactCxxPlatform/react/io/ImageLoaderModule.h

@@ -8,7 +8,7 @@
 #pragma once
 
 #include <FBReactNativeSpec/FBReactNativeSpecJSI.h>
-#include <react/bridging/Promise.h>
+#include <React/Bridging.h>
 #include <memory>
 #include <string>
 #include <utility>

packages/react-native/ReactCxxPlatform/react/logging/NativeExceptionsManager.h

@@ -8,9 +8,9 @@
 #pragma once
 
 #include <FBReactNativeSpec/FBReactNativeSpecJSI.h>
+#include <React/Bridging.h>
 #include <folly/dynamic.h>
 #include <jserrorhandler/JsErrorHandler.h>
-#include <react/bridging/Base.h>
 #include <optional>
 #include <string>
 #include <utility>

packages/react-native/ReactCxxPlatform/react/renderer/uimanager/IMountingManager.h

@@ -7,8 +7,8 @@
 
 #pragma once
 
+#include <React/RendererCore.h>
 #include <react/renderer/componentregistry/ComponentDescriptorFactory.h>
-#include <react/renderer/core/ComponentDescriptor.h>
 #include <react/renderer/mounting/MountingTransaction.h>
 #include <react/renderer/mounting/ShadowView.h>
 

packages/react-native/ReactCxxPlatform/react/runtime/ReactHost.h

@@ -9,8 +9,8 @@
 
 #include "ReactInstanceConfig.h"
 
-#include <ReactCommon/CallInvoker.h>
-#include <ReactCommon/TurboModule.h>
+#include <React/CallInvoker.h>
+#include <React/NativeModuleCore.h>
 #include <cxxreact/MessageQueueThread.h>
 #include <react/logging/DefaultLogger.h>
 #include <react/nativemodule/JavaScriptModule.h>