Repository navigation
Commit da651fd
RNTester: compile RCTUtilsTests in the RNTesterUnitTests target (#58894)
Summary:
`packages/rn-tester/RNTesterUnitTests/RCTUtilsTests.m` isn't in `RNTesterPods.xcodeproj`. It's the one test file in `RNTesterUnitTests/` with no file reference and no Sources entry, so `yarn test-ios` never compiles it and `testRCTHumanReadableType` and `testRCTValidateTypeOfViewCommandArgument` never run. This adds the file to the `RNTesterUnitTests` target.
## Changelog:
[INTERNAL] [FIXED] - Compile RCTUtilsTests in the RNTesterUnitTests target
Pull Request resolved: #58894
Test Plan:
- `xcodebuild test -workspace RNTesterPods.xcworkspace -scheme RNTester -sdk iphonesimulator -destination 'platform=iOS Simulator,id=<udid>' -only-testing:RNTesterUnitTests/RCTUtilsTests`: on `main` it executes no tests; with this change it executes 2, and both pass. Changing the expected value of the first assertion makes the run fail.
- The whole `RNTester` scheme, with Metro and the WebSocket test server up as `scripts/objc-test.sh test` starts them: `RNTesterUnitTests` 170 tests, 16 skipped, 0 failures, with both `RCTUtilsTests` cases among them. I ran it on the iOS 18.0 runtime; `scripts/.tests.env` asks for 18.3.1, which this machine doesn't have.
Reviewed By: christophpurrer
Differential Revision: D123784162
Pulled By: javache
fbshipit-source-id: 9eb78c687f74bfd1b1fe95c27a24ea9fb1890f971 parent f6fc189 commit da651fd
1 file changed
Lines changed: 4 additions & 0 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
15 | 15 | | |
16 | 16 | | |
17 | 17 | | |
| 18 | + | |
18 | 19 | | |
19 | 20 | | |
20 | 21 | | |
| |||
104 | 105 | | |
105 | 106 | | |
106 | 107 | | |
| 108 | + | |
107 | 109 | | |
108 | 110 | | |
109 | 111 | | |
| |||
346 | 348 | | |
347 | 349 | | |
348 | 350 | | |
| 351 | + | |
349 | 352 | | |
350 | 353 | | |
351 | 354 | | |
| |||
774 | 777 | | |
775 | 778 | | |
776 | 779 | | |
| 780 | + | |
777 | 781 | | |
778 | 782 | | |
779 | 783 | | |
| |||
0 commit comments