Skip to content

Commit a2e667a

Browse files
janicduplessisjanicduplessis
committed
Regenerate the C++ API snapshots with the real toolchain
Replaces the hand-edited snapshots from the previous commit, generated with Doxygen 1.16.1 (the version CI pins) and validated with `python -m scripts.cxx-api.parser --validate` — all nine views pass. Two corrections fall out. The renamed DeviceInfo members are *dropped* from the snapshots rather than renamed: `scripts/cxx-api/config.yml` excludes any symbol matching `(?i)experimental`, so the C++ surface hides the field the same way the JavaScript API snapshot does. And AppleEventBeat's destructor is `~AppleEventBeat() override` — the `virtual` in the line added by hand with the display-phase induce was never what Doxygen emits for it.
1 parent 8c4d71e commit a2e667a

6 files changed

Lines changed: 3 additions & 18 deletions

File tree

‎scripts/cxx-api/api-snapshots/ReactAndroidDebugCxx.api‎

Lines changed: 0 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -8449,7 +8449,6 @@ struct facebook::react::NativeDeviceInfoDisplayMetricsAndroid {
84498449
public P2 scale;
84508450
public P3 fontScale;
84518451
public P4 densityDpi;
8452-
public P5 experimental_safeAreaInsets;
84538452
public bool operator==(const facebook::react::NativeDeviceInfoDisplayMetricsAndroid& other) const;
84548453
}
84558454

@@ -8470,7 +8469,6 @@ struct facebook::react::NativeDeviceInfoDisplayMetrics {
84708469
public P1 height;
84718470
public P2 scale;
84728471
public P3 fontScale;
8473-
public P4 experimental_safeAreaInsets;
84748472
public bool operator==(const facebook::react::NativeDeviceInfoDisplayMetrics& other) const;
84758473
}
84768474

@@ -9244,7 +9242,6 @@ struct facebook::react::NativeDeviceInfoDisplayMetricsAndroidBridging {
92449242
public static double heightToJs(facebook::jsi::Runtime& rt, decltype(types.height) value);
92459243
public static double scaleToJs(facebook::jsi::Runtime& rt, decltype(types.scale) value);
92469244
public static double widthToJs(facebook::jsi::Runtime& rt, decltype(types.width) value);
9247-
public static facebook::jsi::Object experimental_safeAreaInsetsToJs(facebook::jsi::Runtime& rt, decltype(types.experimental_safeAreaInsets) value);
92489245
public static facebook::jsi::Object toJs(facebook::jsi::Runtime& rt, const T& value, const std::shared_ptr<facebook::react::CallInvoker>& jsInvoker);
92499246
}
92509247

@@ -9256,7 +9253,6 @@ struct facebook::react::NativeDeviceInfoDisplayMetricsBridging {
92569253
public static double heightToJs(facebook::jsi::Runtime& rt, decltype(types.height) value);
92579254
public static double scaleToJs(facebook::jsi::Runtime& rt, decltype(types.scale) value);
92589255
public static double widthToJs(facebook::jsi::Runtime& rt, decltype(types.width) value);
9259-
public static facebook::jsi::Object experimental_safeAreaInsetsToJs(facebook::jsi::Runtime& rt, decltype(types.experimental_safeAreaInsets) value);
92609256
public static facebook::jsi::Object toJs(facebook::jsi::Runtime& rt, const T& value, const std::shared_ptr<facebook::react::CallInvoker>& jsInvoker);
92619257
}
92629258

‎scripts/cxx-api/api-snapshots/ReactAndroidNewarchCxx.api‎

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -8210,7 +8210,6 @@ struct facebook::react::NativeDeviceInfoDisplayMetricsAndroid {
82108210
public P2 scale;
82118211
public P3 fontScale;
82128212
public P4 densityDpi;
8213-
public P5 experimental_safeAreaInsets;
82148213
public bool operator==(const facebook::react::NativeDeviceInfoDisplayMetricsAndroid& other) const;
82158214
}
82168215

@@ -8231,7 +8230,6 @@ struct facebook::react::NativeDeviceInfoDisplayMetrics {
82318230
public P1 height;
82328231
public P2 scale;
82338232
public P3 fontScale;
8234-
public P4 experimental_safeAreaInsets;
82358233
public bool operator==(const facebook::react::NativeDeviceInfoDisplayMetrics& other) const;
82368234
}
82378235

‎scripts/cxx-api/api-snapshots/ReactAndroidReleaseCxx.api‎

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -8440,7 +8440,6 @@ struct facebook::react::NativeDeviceInfoDisplayMetricsAndroid {
84408440
public P2 scale;
84418441
public P3 fontScale;
84428442
public P4 densityDpi;
8443-
public P5 experimental_safeAreaInsets;
84448443
public bool operator==(const facebook::react::NativeDeviceInfoDisplayMetricsAndroid& other) const;
84458444
}
84468445

@@ -8461,7 +8460,6 @@ struct facebook::react::NativeDeviceInfoDisplayMetrics {
84618460
public P1 height;
84628461
public P2 scale;
84638462
public P3 fontScale;
8464-
public P4 experimental_safeAreaInsets;
84658463
public bool operator==(const facebook::react::NativeDeviceInfoDisplayMetrics& other) const;
84668464
}
84678465

‎scripts/cxx-api/api-snapshots/ReactAppleDebugCxx.api‎

Lines changed: 1 addition & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -4224,7 +4224,7 @@ class facebook::react::AppleEventBeat : public facebook::react::EventBeat, publi
42244224
public AppleEventBeat(std::shared_ptr<facebook::react::EventBeat::OwnerBox> ownerBox, std::unique_ptr<const facebook::react::RunLoopObserver> uiRunLoopObserver, facebook::react::RuntimeScheduler& RuntimeScheduler);
42254225
public virtual void activityDidChange(const facebook::react::RunLoopObserver::Delegate* delegate, facebook::react::RunLoopObserver::Activity activity) const noexcept override;
42264226
public virtual void requestSynchronous() const override;
4227-
public virtual ~AppleEventBeat() override;
4227+
public ~AppleEventBeat() override;
42284228
}
42294229

42304230
class facebook::react::AsyncArrayBuffer {
@@ -10436,7 +10436,6 @@ struct facebook::react::NativeDeviceInfoDisplayMetrics {
1043610436
public P1 height;
1043710437
public P2 scale;
1043810438
public P3 fontScale;
10439-
public P4 experimental_safeAreaInsets;
1044010439
public bool operator==(const facebook::react::NativeDeviceInfoDisplayMetrics& other) const;
1044110440
}
1044210441

@@ -11165,7 +11164,6 @@ struct facebook::react::NativeDeviceInfoDisplayMetricsBridging {
1116511164
public static double heightToJs(facebook::jsi::Runtime& rt, decltype(types.height) value);
1116611165
public static double scaleToJs(facebook::jsi::Runtime& rt, decltype(types.scale) value);
1116711166
public static double widthToJs(facebook::jsi::Runtime& rt, decltype(types.width) value);
11168-
public static facebook::jsi::Object experimental_safeAreaInsetsToJs(facebook::jsi::Runtime& rt, decltype(types.experimental_safeAreaInsets) value);
1116911167
public static facebook::jsi::Object toJs(facebook::jsi::Runtime& rt, const T& value, const std::shared_ptr<facebook::react::CallInvoker>& jsInvoker);
1117011168
}
1117111169

@@ -15734,7 +15732,6 @@ struct JS::NativeDeviceInfo::DisplayMetrics::Builder::Input {
1573415732
protected RCTRequired<double> height;
1573515733
protected RCTRequired<double> scale;
1573615734
protected RCTRequired<double> width;
15737-
protected std::optional<JS::NativeDeviceInfo::WindowSafeAreaInsets::Builder> experimental_safeAreaInsets;
1573815735
}
1573915736

1574015737
struct JS::NativeDeviceInfo::WindowSafeAreaInsets {

‎scripts/cxx-api/api-snapshots/ReactAppleNewarchCxx.api‎

Lines changed: 1 addition & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -4211,7 +4211,7 @@ class facebook::react::AppleEventBeat : public facebook::react::EventBeat, publi
42114211
public AppleEventBeat(std::shared_ptr<facebook::react::EventBeat::OwnerBox> ownerBox, std::unique_ptr<const facebook::react::RunLoopObserver> uiRunLoopObserver, facebook::react::RuntimeScheduler& RuntimeScheduler);
42124212
public virtual void activityDidChange(const facebook::react::RunLoopObserver::Delegate* delegate, facebook::react::RunLoopObserver::Activity activity) const noexcept override;
42134213
public virtual void requestSynchronous() const override;
4214-
public virtual ~AppleEventBeat() override;
4214+
public ~AppleEventBeat() override;
42154215
}
42164216

42174217
class facebook::react::AsyncArrayBuffer {
@@ -10253,7 +10253,6 @@ struct facebook::react::NativeDeviceInfoDisplayMetrics {
1025310253
public P1 height;
1025410254
public P2 scale;
1025510255
public P3 fontScale;
10256-
public P4 experimental_safeAreaInsets;
1025710256
public bool operator==(const facebook::react::NativeDeviceInfoDisplayMetrics& other) const;
1025810257
}
1025910258

@@ -15418,7 +15417,6 @@ struct JS::NativeDeviceInfo::DisplayMetrics::Builder::Input {
1541815417
protected RCTRequired<double> height;
1541915418
protected RCTRequired<double> scale;
1542015419
protected RCTRequired<double> width;
15421-
protected std::optional<JS::NativeDeviceInfo::WindowSafeAreaInsets::Builder> experimental_safeAreaInsets;
1542215420
}
1542315421

1542415422
struct JS::NativeDeviceInfo::WindowSafeAreaInsets {

‎scripts/cxx-api/api-snapshots/ReactAppleReleaseCxx.api‎

Lines changed: 1 addition & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -4222,7 +4222,7 @@ class facebook::react::AppleEventBeat : public facebook::react::EventBeat, publi
42224222
public AppleEventBeat(std::shared_ptr<facebook::react::EventBeat::OwnerBox> ownerBox, std::unique_ptr<const facebook::react::RunLoopObserver> uiRunLoopObserver, facebook::react::RuntimeScheduler& RuntimeScheduler);
42234223
public virtual void activityDidChange(const facebook::react::RunLoopObserver::Delegate* delegate, facebook::react::RunLoopObserver::Activity activity) const noexcept override;
42244224
public virtual void requestSynchronous() const override;
4225-
public virtual ~AppleEventBeat() override;
4225+
public ~AppleEventBeat() override;
42264226
}
42274227

42284228
class facebook::react::AsyncArrayBuffer {
@@ -10427,7 +10427,6 @@ struct facebook::react::NativeDeviceInfoDisplayMetrics {
1042710427
public P1 height;
1042810428
public P2 scale;
1042910429
public P3 fontScale;
10430-
public P4 experimental_safeAreaInsets;
1043110430
public bool operator==(const facebook::react::NativeDeviceInfoDisplayMetrics& other) const;
1043210431
}
1043310432

@@ -15592,7 +15591,6 @@ struct JS::NativeDeviceInfo::DisplayMetrics::Builder::Input {
1559215591
protected RCTRequired<double> height;
1559315592
protected RCTRequired<double> scale;
1559415593
protected RCTRequired<double> width;
15595-
protected std::optional<JS::NativeDeviceInfo::WindowSafeAreaInsets::Builder> experimental_safeAreaInsets;
1559615594
}
1559715595

1559815596
struct JS::NativeDeviceInfo::WindowSafeAreaInsets {

0 commit comments

Comments
 (0)