Reach public modules through umbrellas from for-frameworks headers (#58969)

Summary:
Pull Request resolved: #58969

Several "for frameworks" headers included fine-grained headers of public modules directly. A framework author includes a for-frameworks header directly, outside any umbrella, so under `RN_STRICT_API` those includes hit the public module's `UmbrellaGuard.h` `#error`, which `RN_ALLOW_FRAMEWORKS` does not suppress. Switch them to the module umbrellas:

- Image component (`ImageComponentDescriptor.h`, `ImageEventEmitter.h`, `ImageProps.h`, `ImageShadowNode.h`, `ImageState.h`): `<React/View.h>`, `<React/RendererCore.h>`, `<React/Graphics.h>`, `<React/ImageManager.h>`.
- `ComponentDescriptorFactory.h`: `<React/RendererCore.h>`, `<React/Utils.h>`, `<React/ComponentRegistry.h>`.
- `react/renderer/core` `DynamicEventPayload.h`, `DynamicPointerEvent.h`, `DynamicPropsUtilities.h`, `ReactRootViewTagGenerator.h`: `<React/RendererCore.h>`.
- `DefaultTurboModules.h`: `<React/NativeModuleCore.h>`.
- iOS/macOS `RCTInstance.h` and `RCTContextContainerHandling.h`: `<React/CallInvoker.h>`, `<React/Utils.h>`.

Includes of for-frameworks headers in the same module stay direct, since umbrellas do not re-export them. The `react/renderer/core` headers and `ComponentDescriptorFactory.h` now include their own module's umbrella, so the CMake `react_renderer_core` and `react_renderer_componentregistry` targets expose their umbrella directory as `PUBLIC` instead of `INTERFACE`: core's own sources (`EventEmitter.cpp`, `Props.cpp`, `ShadowNode.cpp`, ...) include these headers and must resolve `<React/RendererCore.h>` too. Each umbrella is a superset of the headers it replaces, so no declarations are lost. The guards are inert without `RN_STRICT_API`.

Changelog: [Internal]

Reviewed By: cipolleschi

Differential Revision: D124320010

fbshipit-source-id: ec242157c8c486857b744e860fd9a1500cf64012

Author: coado

packages/react-native/ReactCommon/react/nativemodule/defaults/DefaultTurboModules.h

@@ -9,7 +9,7 @@
 
 #include <react/cxxstableapi/FrameworksGuard.h>
 
-#include <ReactCommon/TurboModule.h>
+#include <React/NativeModuleCore.h>
 
 namespace facebook::react {
 

packages/react-native/ReactCommon/react/renderer/animations/LayoutAnimationKeyFrameManager.cpp

@@ -15,7 +15,6 @@
 #include <react/debug/react_native_assert.h>
 #include <react/renderer/animations/conversions.h>
 #include <react/renderer/animations/utils.h>
-#include <react/renderer/components/image/ImageProps.h>
 #include <react/renderer/components/view/ViewProps.h>
 #include <react/renderer/components/view/ViewPropsInterpolation.h>
 #include <react/renderer/core/ComponentDescriptor.h>

packages/react-native/ReactCommon/react/renderer/componentregistry/CMakeLists.txt

@@ -12,7 +12,7 @@ file(GLOB react_renderer_componentregistry_SRC CONFIGURE_DEPENDS *.cpp)
 add_library(react_renderer_componentregistry OBJECT ${react_renderer_componentregistry_SRC})
 
 target_include_directories(react_renderer_componentregistry PUBLIC ${REACT_COMMON_DIR})
-target_include_directories(react_renderer_componentregistry INTERFACE ${REACT_COMMON_DIR}/react/renderer/componentregistry)
+target_include_directories(react_renderer_componentregistry PUBLIC ${REACT_COMMON_DIR}/react/renderer/componentregistry)
 
 target_link_libraries(react_renderer_componentregistry
         folly_runtime

packages/react-native/ReactCommon/react/renderer/componentregistry/ComponentDescriptorFactory.h

@@ -11,11 +11,10 @@
 
 #include <memory>
 
-#include <react/renderer/core/ComponentDescriptor.h>
-#include <react/renderer/core/EventDispatcher.h>
-#include <react/utils/ContextContainer.h>
+#include <React/RendererCore.h>
+#include <React/Utils.h>
 
-#include "ComponentDescriptorRegistry.h"
+#include <React/ComponentRegistry.h>
 
 namespace facebook::react {
 

packages/react-native/ReactCommon/react/renderer/components/image/ImageComponentDescriptor.h

@@ -11,8 +11,8 @@
 
 #include <memory>
 
+#include <React/RendererCore.h>
 #include <react/renderer/components/image/ImageShadowNode.h>
-#include <react/renderer/core/ConcreteComponentDescriptor.h>
 
 namespace facebook::react {
 

packages/react-native/ReactCommon/react/renderer/components/image/ImageEventEmitter.h

@@ -11,8 +11,8 @@
 
 #include <cstdint>
 
-#include <react/renderer/components/view/ViewEventEmitter.h>
-#include <react/renderer/imagemanager/primitives.h>
+#include <React/ImageManager.h>
+#include <React/View.h>
 
 namespace facebook::react {
 

packages/react-native/ReactCommon/react/renderer/components/image/ImageProps.h

@@ -12,10 +12,10 @@
 #include <optional>
 #include <string>
 
-#include <react/renderer/components/view/ViewProps.h>
-#include <react/renderer/core/PropsParserContext.h>
-#include <react/renderer/graphics/Color.h>
-#include <react/renderer/imagemanager/primitives.h>
+#include <React/Graphics.h>
+#include <React/ImageManager.h>
+#include <React/RendererCore.h>
+#include <React/View.h>
 
 namespace facebook::react {
 

packages/react-native/ReactCommon/react/renderer/components/image/ImageShadowNode.h

@@ -11,13 +11,12 @@
 
 #include <memory>
 
+#include <React/ImageManager.h>
+#include <React/RendererCore.h>
+#include <React/View.h>
 #include <react/renderer/components/image/ImageEventEmitter.h>
 #include <react/renderer/components/image/ImageProps.h>
 #include <react/renderer/components/image/ImageState.h>
-#include <react/renderer/components/view/ConcreteViewShadowNode.h>
-#include <react/renderer/core/ShadowNodeFamily.h>
-#include <react/renderer/imagemanager/ImageManager.h>
-#include <react/renderer/imagemanager/primitives.h>
 
 namespace facebook::react {
 

packages/react-native/ReactCommon/react/renderer/components/image/ImageState.h

@@ -12,9 +12,7 @@
 #include <memory>
 #include <utility>
 
-#include <react/renderer/imagemanager/ImageRequest.h>
-#include <react/renderer/imagemanager/ImageRequestParams.h>
-#include <react/renderer/imagemanager/primitives.h>
+#include <React/ImageManager.h>
 
 #ifdef ANDROID
 #include <folly/dynamic.h>

packages/react-native/ReactCommon/react/renderer/core/CMakeLists.txt

@@ -12,7 +12,7 @@ file(GLOB react_renderer_core_SRC CONFIGURE_DEPENDS *.cpp)
 add_library(react_renderer_core OBJECT ${react_renderer_core_SRC})
 
 target_include_directories(react_renderer_core PUBLIC ${REACT_COMMON_DIR})
-target_include_directories(react_renderer_core INTERFACE ${REACT_COMMON_DIR}/react/renderer/core)
+target_include_directories(react_renderer_core PUBLIC ${REACT_COMMON_DIR}/react/renderer/core)
 target_link_libraries(react_renderer_core
         folly_runtime
         glog