Skip to content

Commit 8a75a4d

Browse files
cortinicometa-codesync[bot]
authored andcommitted
Skip device-specific screenshot flows in Maestro Cloud (#58166)
Summary: Pull Request resolved: #58166 The screenshot baselines used by two Android RNTester flows were captured on the local CI emulator and have fixed pixel dimensions that do not match the Maestro Cloud device profile. Tag those flows as local screenshot baselines and exclude that tag from the Android Maestro Cloud job. The existing local Android E2E job continues to run both flows and validate their screenshots. Changelog: [Internal] ___ Differential Revision: D117687713 fbshipit-source-id: de7cb4c8b395f204d672f8a209a29ccaa6ab0226
1 parent cec189b commit 8a75a4d

4 files changed

Lines changed: 7 additions & 2 deletions

File tree

.github/workflows/test-all.yml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -372,7 +372,7 @@ jobs:
372372
download-path: /tmp/rntester-android
373373
app-file: /tmp/rntester-android/app-arm64-v8a-release.apk
374374
app-id: com.facebook.react.uiapp
375-
exclude-tags: ios-only
375+
exclude-tags: ios-only,local-screenshot-baseline
376376
secrets: inherit
377377

378378
test_e2e_android_rntester:

packages/rn-tester/.maestro/image-blur-prefetch.yml

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,9 @@
11
appId: ${APP_ID} # iOS: com.meta.RNTester.localDevelopment | Android: com.facebook.react.uiapp
22
tags:
33
- android-only
4+
# The screenshot baseline is captured on the local CI emulator and is
5+
# intentionally not portable across Maestro Cloud device profiles.
6+
- local-screenshot-baseline
47
---
58
# Android-only: prefetch an image, then render the same URI with blurRadius so
69
# the blur postprocessor applies to the already-decoded bitmap. Flaky on the iOS

packages/rn-tester/.maestro/image-wide-gamut.yml

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,9 @@
11
appId: ${APP_ID} # iOS: com.meta.RNTester.localDevelopment | Android: com.facebook.react.uiapp
22
tags:
33
- android-only
4+
# The screenshot baseline is captured on the local CI emulator and is
5+
# intentionally not portable across Maestro Cloud device profiles.
6+
- local-screenshot-baseline
47
---
58
# Android-only: alpha transparency + sRGB vs Display-P3 wide-gamut. Color
69
# fidelity is covered by a screenshot captured from the ARM64 APK on the API 35

packages/rn-tester/.maestro/image.yml

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -14,7 +14,6 @@ appId: ${APP_ID} # iOS: com.meta.RNTester.localDevelopment | Android: com.facebo
1414
id: 'example_search'
1515
- inputText:
1616
text: 'Image.getSize'
17-
- hideKeyboard
1817
- tapOn:
1918
id: 'platform-test-results'
2019
- assertVisible: 'Results'

0 commit comments

Comments
 (0)