Use public feature flags entry point in exported headers

Summary:
Exported headers that read feature flags inline now go through the generated `ReactNativePublicFeatureFlags.h` instead of `ReactNativeFeatureFlags.h`. Sources that relied on the transitive include now include `ReactNativeFeatureFlags.h` directly.

Changelog: [Internal]

Differential Revision: D122353873

Author: j-piasecki

packages/react-native/ReactCommon/react/renderer/attributedstring/conversions.h

@@ -10,7 +10,7 @@
 #include <react/cxxstableapi/FrameworksGuard.h>
 
 #include <react/debug/react_native_expect.h>
-#include <react/featureflags/ReactNativeFeatureFlags.h>
+#include <react/featureflags/ReactNativePublicFeatureFlags.h>
 #include <react/renderer/attributedstring/AttributedString.h>
 #include <react/renderer/attributedstring/ParagraphAttributes.h>
 #include <react/renderer/attributedstring/TextAttributes.h>
@@ -517,7 +517,7 @@ inline void parseUnprocessedFontVariant(const PropsParserContext &context, const
 
 inline void fromRawValue(const PropsParserContext &context, const RawValue &value, FontVariant &result)
 {
-  if (ReactNativeFeatureFlags::enableNativeCSSParsing()) {
+  if (ReactNativeFeatureFlags_DO_NOT_USE::enableNativeCSSParsing()) {
     parseUnprocessedFontVariant(context, value, result);
   } else {
     parseProcessedFontVariant(context, value, result);

packages/react-native/ReactCommon/react/renderer/components/view/BackgroundImagePropsConversions.h

@@ -9,7 +9,7 @@
 
 #include <react/cxxstableapi/UmbrellaGuard.h>
 
-#include <react/featureflags/ReactNativeFeatureFlags.h>
+#include <react/featureflags/ReactNativePublicFeatureFlags.h>
 #include <react/renderer/core/PropsParserContext.h>
 #include <react/renderer/core/RawProps.h>
 #include <react/renderer/graphics/BackgroundImage.h>
@@ -30,7 +30,7 @@ void parseUnprocessedBackgroundImageString(const std::string &value, std::vector
 
 inline void fromRawValue(const PropsParserContext &context, const RawValue &value, std::vector<BackgroundImage> &result)
 {
-  if (ReactNativeFeatureFlags::enableNativeCSSParsing()) {
+  if (ReactNativeFeatureFlags_DO_NOT_USE::enableNativeCSSParsing()) {
     if (value.hasType<std::string>()) {
       parseUnprocessedBackgroundImageString((std::string)value, result);
     } else if (value.hasType<std::vector<RawValue>>()) {

packages/react-native/ReactCommon/react/renderer/components/view/BoxShadowPropsConversions.h

@@ -11,7 +11,7 @@
 
 #include <glog/logging.h>
 #include <react/debug/react_native_expect.h>
-#include <react/featureflags/ReactNativeFeatureFlags.h>
+#include <react/featureflags/ReactNativePublicFeatureFlags.h>
 #include <react/renderer/components/view/CSSConversions.h>
 #include <react/renderer/core/PropsParserContext.h>
 #include <react/renderer/core/RawProps.h>
@@ -255,7 +255,7 @@ parseUnprocessedBoxShadow(const PropsParserContext &context, const RawValue &val
 
 inline void fromRawValue(const PropsParserContext &context, const RawValue &value, std::vector<BoxShadow> &result)
 {
-  if (ReactNativeFeatureFlags::enableNativeCSSParsing()) {
+  if (ReactNativeFeatureFlags_DO_NOT_USE::enableNativeCSSParsing()) {
     parseUnprocessedBoxShadow(context, value, result);
   } else {
     parseProcessedBoxShadow(context, value, result);

packages/react-native/ReactCommon/react/renderer/components/view/FilterPropsConversions.h

@@ -11,7 +11,7 @@
 
 #include <glog/logging.h>
 #include <react/debug/react_native_expect.h>
-#include <react/featureflags/ReactNativeFeatureFlags.h>
+#include <react/featureflags/ReactNativePublicFeatureFlags.h>
 #include <react/renderer/components/view/CSSConversions.h>
 #include <react/renderer/core/PropsParserContext.h>
 #include <react/renderer/core/RawProps.h>
@@ -358,7 +358,7 @@ parseUnprocessedFilter(const PropsParserContext &context, const RawValue &value,
 
 inline void fromRawValue(const PropsParserContext &context, const RawValue &value, std::vector<FilterFunction> &result)
 {
-  if (ReactNativeFeatureFlags::enableNativeCSSParsing()) {
+  if (ReactNativeFeatureFlags_DO_NOT_USE::enableNativeCSSParsing()) {
     parseUnprocessedFilter(context, value, result);
   } else {
     parseProcessedFilter(context, value, result);

packages/react-native/ReactCommon/react/renderer/components/view/conversions.h

@@ -11,7 +11,7 @@
 
 #include <glog/logging.h>
 #include <react/debug/react_native_expect.h>
-#include <react/featureflags/ReactNativeFeatureFlags.h>
+#include <react/featureflags/ReactNativePublicFeatureFlags.h>
 #include <react/renderer/components/view/primitives.h>
 #include <react/renderer/core/LayoutMetrics.h>
 #include <react/renderer/core/PropsParserContext.h>
@@ -520,7 +520,7 @@ inline yoga::FloatOptional convertAspectRatio(const PropsParserContext & /*conte
   if (value.hasType<float>()) {
     return yoga::FloatOptional((float)value);
   }
-  if (ReactNativeFeatureFlags::enableNativeCSSParsing() && value.hasType<std::string>()) {
+  if (ReactNativeFeatureFlags_DO_NOT_USE::enableNativeCSSParsing() && value.hasType<std::string>()) {
     auto ratio = parseCSSProperty<CSSRatio>((std::string)value);
     if (std::holds_alternative<CSSRatio>(ratio)) {
       auto r = std::get<CSSRatio>(ratio);
@@ -995,7 +995,7 @@ inline void parseUnprocessedTransform(const PropsParserContext &context, const R
 
 inline void fromRawValue(const PropsParserContext &context, const RawValue &value, Transform &result)
 {
-  if (ReactNativeFeatureFlags::enableNativeCSSParsing()) {
+  if (ReactNativeFeatureFlags_DO_NOT_USE::enableNativeCSSParsing()) {
     parseUnprocessedTransform(context, value, result);
   } else {
     parseProcessedTransform(context, value, result);
@@ -1079,7 +1079,7 @@ parseUnprocessedTransformOrigin(const PropsParserContext &context, const RawValu
 
 inline void fromRawValue(const PropsParserContext &context, const RawValue &value, TransformOrigin &result)
 {
-  if (ReactNativeFeatureFlags::enableNativeCSSParsing()) {
+  if (ReactNativeFeatureFlags_DO_NOT_USE::enableNativeCSSParsing()) {
     parseUnprocessedTransformOrigin(context, value, result);
   } else {
     parseProcessedTransformOrigin(context, value, result);

packages/react-native/ReactCommon/react/renderer/core/ConcreteComponentDescriptor.h

@@ -13,7 +13,7 @@
 #include <vector>
 
 #include <react/debug/react_native_assert.h>
-#include <react/featureflags/ReactNativeFeatureFlags.h>
+#include <react/featureflags/ReactNativePublicFeatureFlags.h>
 #include <react/renderer/core/ComponentDescriptor.h>
 #include <react/renderer/core/EventDispatcher.h>
 #include <react/renderer/core/Props.h>
@@ -56,7 +56,7 @@ class ConcreteComponentDescriptor : public ComponentDescriptor {
     // iterator-setter path and the runtime flag is on, `parse()` is never
     // called, so the O(n²) preparation here is wasted. Skip it.
     if constexpr (HasIteratorSetterCtor<ConcreteProps>) {
-      if (!ReactNativeFeatureFlags::enableCppPropsIteratorSetter()) {
+      if (!ReactNativeFeatureFlags_DO_NOT_USE::enableCppPropsIteratorSetter()) {
         rawPropsParser_.prepare<ConcreteProps>();
       }
     } else {
@@ -136,7 +136,8 @@ class ConcreteComponentDescriptor : public ComponentDescriptor {
     //    and the only path when the flag is off): parse + per-field
     //    `convertRawProp` via the 3-arg ctor.
     constexpr bool kSupportsIteratorSetter = HasIteratorSetterCtor<ConcreteProps>;
-    const bool useIteratorSetter = kSupportsIteratorSetter && ReactNativeFeatureFlags::enableCppPropsIteratorSetter();
+    const bool useIteratorSetter =
+        kSupportsIteratorSetter && ReactNativeFeatureFlags_DO_NOT_USE::enableCppPropsIteratorSetter();
 
     std::shared_ptr<ConcreteProps> shadowNodeProps;
     if constexpr (kSupportsIteratorSetter) {
@@ -151,11 +152,11 @@ class ConcreteComponentDescriptor : public ComponentDescriptor {
 
 #ifdef RN_SERIALIZABLE_STATE
     bool fallbackToDynamicRawPropsAccumulation = true;
-    if (ReactNativeFeatureFlags::enableExclusivePropsUpdateAndroid() &&
-        ReactNativeFeatureFlags::enableAccumulatedUpdatesInRawPropsAndroid()) {
+    if (ReactNativeFeatureFlags_DO_NOT_USE::enableExclusivePropsUpdateAndroid() &&
+        ReactNativeFeatureFlags_DO_NOT_USE::enableAccumulatedUpdatesInRawPropsAndroid()) {
       // When exclusive props update is enabled, we only apply Props 1.5 processing
       // (raw props merging) when Props 2.0 is not available.
-      if (ReactNativeFeatureFlags::enablePropsUpdateReconciliationAndroid()) {
+      if (ReactNativeFeatureFlags_DO_NOT_USE::enablePropsUpdateReconciliationAndroid()) {
         // Cast to base Props reference to safely call virtual method
         const auto &baseProps = static_cast<const Props &>(*shadowNodeProps);
         if (strcmp(ShadowNodeT::Name(), baseProps.getDiffPropsImplementationTarget()) == 0) {

packages/react-native/ReactCommon/react/renderer/graphics/fromRawValueShared.h

@@ -9,7 +9,7 @@
 
 #include <react/cxxstableapi/UmbrellaGuard.h>
 #include <react/debug/react_native_expect.h>
-#include <react/featureflags/ReactNativeFeatureFlags.h>
+#include <react/featureflags/ReactNativePublicFeatureFlags.h>
 #include <react/renderer/core/RawValue.h>
 #include <react/renderer/css/CSSColor.h>
 #include <react/renderer/css/CSSValueParser.h>
@@ -28,7 +28,7 @@ inline void fromRawValueShared(
 {
   ColorComponents colorComponents = {0, 0, 0, 0};
 
-  if (ReactNativeFeatureFlags::enableNativeCSSParsing() && value.hasType<std::string>()) {
+  if (ReactNativeFeatureFlags_DO_NOT_USE::enableNativeCSSParsing() && value.hasType<std::string>()) {
     auto cssColor = parseCSSProperty<CSSColor>((std::string)value);
     if (std::holds_alternative<CSSColor>(cssColor)) {
       auto c = std::get<CSSColor>(cssColor);

packages/react-native/ReactCommon/react/renderer/mounting/ShadowTree.cpp

@@ -10,6 +10,7 @@
 #include <cxxreact/TraceSection.h>
 #include <jsinspector-modern/tracing/PerformanceTracerSection.h>
 #include <react/debug/react_native_assert.h>
+#include <react/featureflags/ReactNativeFeatureFlags.h>
 #include <react/renderer/components/root/RootComponentDescriptor.h>
 #include <react/renderer/core/LayoutContext.h>
 #include <react/renderer/core/LayoutPrimitives.h>

packages/react-native/ReactCommon/react/renderer/mounting/tests/StackingContextTest.cpp

@@ -9,6 +9,7 @@
 
 #include <gtest/gtest.h>
 
+#include <react/featureflags/ReactNativeFeatureFlags.h>
 #include <react/renderer/componentregistry/ComponentDescriptorProviderRegistry.h>
 #include <react/renderer/components/root/RootComponentDescriptor.h>
 #include <react/renderer/components/scrollview/ScrollViewComponentDescriptor.h>