Skip to content

Commit 7fc911a

Browse files
Nivaldo Bondançameta-codesync[bot]
authored andcommitted
Migrate DeviceInfoModuleTest off JUnit3 TestCase base (#59431)
Summary: Pull Request resolved: #59431 Drop the vestigial `: TestCase()` base (already on Robolectric runner with `Test`/`Before` annotations and Truth assertions); drop the `override` modifier on `setUp`. Differential Revision: D127203153 fbshipit-source-id: a20e6d02fb247d53f895a60f35adfe75bdadaedb
1 parent 11b10c0 commit 7fc911a

1 file changed

Lines changed: 2 additions & 3 deletions

File tree

‎packages/react-native/ReactAndroid/src/test/java/com/facebook/react/modules/deviceinfo/DeviceInfoModuleTest.kt‎

Lines changed: 2 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -33,7 +33,6 @@ import com.facebook.testutils.shadows.ShadowNativeMap
3333
import com.facebook.testutils.shadows.ShadowReadableNativeMap
3434
import com.facebook.testutils.shadows.ShadowSoLoader
3535
import com.facebook.testutils.shadows.ShadowWritableNativeMap
36-
import junit.framework.TestCase
3736
import org.assertj.core.api.Assertions.assertThat
3837
import org.junit.After
3938
import org.junit.Before
@@ -64,7 +63,7 @@ import org.robolectric.annotation.Config
6463
ShadowReadableNativeMap::class,
6564
],
6665
)
67-
class DeviceInfoModuleTest : TestCase() {
66+
class DeviceInfoModuleTest {
6867

6968
private lateinit var deviceInfoModule: DeviceInfoModule
7069
private lateinit var fakePortraitDisplayMetrics: WritableMap
@@ -73,7 +72,7 @@ class DeviceInfoModuleTest : TestCase() {
7372
private lateinit var displayMetricsHolder: MockedStatic<DisplayMetricsHolder>
7473

7574
@Before
76-
public override fun setUp() {
75+
fun setUp() {
7776
ReactNativeFeatureFlagsForTests.setUp()
7877
fakePortraitDisplayMetrics = JavaOnlyMap()
7978
fakePortraitDisplayMetrics.putInt("width", 100)

0 commit comments

Comments
 (0)