Remove Fabric and TurboModule dead config

Summary:
Follow-up to D116318829, addressing rubennorte's review comment. Fabric and TurboModules shipped before bridgeless and are always on, so the toggles for them were hardcoded and read nowhere.

Android, `DefaultNewArchitectureEntryPoint` — now only selects the release channel and loads the SO:
- removed `fabricEnabled`, `turboModulesEnabled`, `concurrentReactEnabled`
- removed the deprecated `load(turboModulesEnabled)` and `load(turboModulesEnabled, fabricEnabled)` overloads
- removed `isConfigurationValid`, and with it `DefaultNewArchitectureEntryPointTest` (every test targeted it)
- updated the 8 in-repo call sites that passed `fabricEnabled` into the deprecated 3-arg `DefaultReactActivityDelegate` constructor, which discarded it

iOS:
- removed `fabricEnabled` / `turboModuleEnabled` from `RCTRootViewFactoryConfiguration`
- removed the corresponding `RCTDefaultReactNativeFactoryDelegate` stubs and the `RCTAppDelegate.h` doc references

`ReactAndroid.api` and the `ReactApple*Cxx.api` snapshots are regenerated.

One call site is not updated here: `users/zh/zhaogang/benchmarks/SimpleRN/android/app/src/main/java/com/simplern/MainActivity.kt` still imports `DefaultNewArchitectureEntryPoint.fabricEnabled`. It is a personal benchmark app under `users/` that is not materialized in this working copy, so it could not be edited.

Changelog:
[General][Breaking] - Remove the `fabricEnabled` / `turboModulesEnabled` / `concurrentReactEnabled` accessors and remaining deprecated `load` overloads from `DefaultNewArchitectureEntryPoint`, and the `fabricEnabled` / `turboModuleEnabled` properties from `RCTRootViewFactoryConfiguration`; Fabric and TurboModules are always enabled

Differential Revision: D119380472

Author: christophpurrer

packages/react-native/Libraries/AppDelegate/RCTAppDelegate.h

@@ -47,8 +47,6 @@ NS_ASSUME_NONNULL_BEGIN
  *   - (UIViewController *)createRootViewController;
  *   - (void)setRootView:(UIView *)rootView toRootViewController:(UIViewController *)rootViewController;
  * New Architecture:
- *   - (BOOL)turboModuleEnabled;
- *   - (BOOL)fabricEnabled;
  *   - (NSDictionary *)prepareInitialProps
  *   - (Class)getModuleClassFromName:(const char *)name
  *   - (std::shared_ptr<facebook::react::TurboModule>)getTurboModule:(const std::string &)name

packages/react-native/Libraries/AppDelegate/RCTDefaultReactNativeFactoryDelegate.mm

@@ -116,16 +116,6 @@ - (BOOL)newArchEnabled
   return YES;
 }
 
-- (BOOL)fabricEnabled
-{
-  return YES;
-}
-
-- (BOOL)turboModuleEnabled
-{
-  return YES;
-}
-
 - (Class)getModuleClassFromName:(const char *)name
 {
   return nullptr;

packages/react-native/Libraries/AppDelegate/RCTRootViewFactory.h

@@ -43,12 +43,6 @@ typedef void (^RCTLoadSourceForBridgeBlock)(RCTBridge *bridge, RCTSourceLoadBloc
 #pragma mark - RCTRootViewFactory Configuration
 @interface RCTRootViewFactoryConfiguration : NSObject
 
-/// This property controls whether the App will use the Fabric renderer of the New Architecture or not.
-@property (nonatomic, assign, readonly) BOOL fabricEnabled;
-
-/// This method controls whether the `turboModules` feature of the New Architecture is turned on or off
-@property (nonatomic, assign, readonly) BOOL turboModuleEnabled;
-
 /// Return the bundle URL for the main bundle.
 @property (nonatomic, nonnull) RCTBundleURLBlock bundleURLBlock;
 

packages/react-native/Libraries/AppDelegate/RCTRootViewFactory.mm

@@ -46,8 +46,6 @@ - (instancetype)initWithBundleURLBlock:(RCTBundleURLBlock)bundleURLBlock
 {
   if (self = [super init]) {
     _bundleURLBlock = bundleURLBlock;
-    _fabricEnabled = YES;
-    _turboModuleEnabled = YES;
   }
   return self;
 }

packages/react-native/ReactAndroid/api/ReactAndroid.api

@@ -1768,15 +1768,8 @@ public final class com/facebook/react/defaults/DefaultComponentsRegistry {
 
 public final class com/facebook/react/defaults/DefaultNewArchitectureEntryPoint {
 	public static final field INSTANCE Lcom/facebook/react/defaults/DefaultNewArchitectureEntryPoint;
-	public static final fun getConcurrentReactEnabled ()Z
-	public static final fun getFabricEnabled ()Z
 	public final fun getReleaseLevel ()Lcom/facebook/react/common/ReleaseLevel;
-	public static final fun getTurboModulesEnabled ()Z
 	public static final fun load ()V
-	public static final fun load (Z)V
-	public static final fun load (ZZ)V
-	public static synthetic fun load$default (ZILjava/lang/Object;)V
-	public static synthetic fun load$default (ZZILjava/lang/Object;)V
 	public final fun setReleaseLevel (Lcom/facebook/react/common/ReleaseLevel;)V
 }
 

packages/react-native/ReactAndroid/src/main/java/com/facebook/react/defaults/DefaultNewArchitectureEntryPoint.kt

@@ -5,12 +5,9 @@
  * LICENSE file in the root directory of this source tree.
  */
 
-@file:Suppress("DEPRECATION") // We want to use ReactFeatureFlags here specifically
-
 package com.facebook.react.defaults
 
 import com.facebook.react.common.ReleaseLevel
-import com.facebook.react.common.annotations.VisibleForTesting
 import com.facebook.react.internal.featureflags.ReactNativeFeatureFlags
 import com.facebook.react.internal.featureflags.ReactNativeFeatureFlagsOverrides_RNOSS_Canary_Android
 import com.facebook.react.internal.featureflags.ReactNativeFeatureFlagsOverrides_RNOSS_Experimental_Android
@@ -20,58 +17,20 @@ import com.facebook.react.internal.featureflags.ReactNativeFeatureFlagsProvider
 /**
  * A utility class that serves as an entry point for users setup the New Architecture.
  *
- * This class needs to be invoked as `DefaultNewArchitectureEntryPoint.load(...)` by passing a
- * series of optional parameters.
+ * This class needs to be invoked as `DefaultNewArchitectureEntryPoint.load()`.
  *
  * By default it loads a library called `appmodules`. `appmodules` is a convention used to refer to
  * the application dynamic library. If changed here should be updated also inside the template.
  *
- * By default it also enables both TurboModules, Fabric and Concurrent React (aka React 18), and
- * Bridgeless
+ * The [releaseLevel] selects which feature flag release channel the app is loaded with.
  */
 public object DefaultNewArchitectureEntryPoint {
 
   public var releaseLevel: ReleaseLevel = ReleaseLevel.STABLE
 
-  /**
-   * Loads the React Native New Architecture entry point with the default configuration.
-   *
-   * This will load the app with TurboModules, Fabric and Bridgeless by default.
-   */
+  /** Loads the React Native New Architecture entry point. */
   @JvmStatic
   public fun load() {
-    load(turboModulesEnabled = true, fabricEnabled = true)
-  }
-
-  @JvmStatic
-  @Deprecated(
-      message =
-          "Loading the entry point with different flags for Fabric and TurboModule is deprecated." +
-              " Please use load() instead when loading the New Architecture.",
-      replaceWith = ReplaceWith("load()"),
-  )
-  public fun load(
-      turboModulesEnabled: Boolean = true,
-  ) {
-    load(turboModulesEnabled, fabricEnabled = true)
-  }
-
-  @JvmStatic
-  @Deprecated(
-      message =
-          "Loading the entry point with different flags for Fabric and TurboModule is deprecated." +
-              " Please use load() instead when loading the New Architecture.",
-      replaceWith = ReplaceWith("load()"),
-  )
-  public fun load(
-      turboModulesEnabled: Boolean = true,
-      fabricEnabled: Boolean = true,
-  ) {
-    val (isValid, errorMessage) = isConfigurationValid(turboModulesEnabled, fabricEnabled)
-    if (!isValid) {
-      error(errorMessage)
-    }
-
     when (releaseLevel) {
       ReleaseLevel.EXPERIMENTAL -> {
         ReactNativeFeatureFlags.override(
@@ -86,46 +45,13 @@ public object DefaultNewArchitectureEntryPoint {
       }
     }
 
-    privateTurboModulesEnabled = turboModulesEnabled
-
     DefaultSoLoader.maybeLoadSoLibrary()
   }
 
   @JvmStatic
   internal fun loadWithFeatureFlags(featureFlags: ReactNativeFeatureFlagsProvider) {
     ReactNativeFeatureFlags.override(featureFlags)
 
-    privateTurboModulesEnabled = true
-
     DefaultSoLoader.maybeLoadSoLibrary()
   }
-
-  @JvmStatic
-  public val fabricEnabled: Boolean
-    get() = true
-
-  private var privateTurboModulesEnabled: Boolean = false
-
-  @JvmStatic
-  public val turboModulesEnabled: Boolean
-    get() = privateTurboModulesEnabled
-
-  @JvmStatic
-  public val concurrentReactEnabled: Boolean
-    get() = true
-
-  @VisibleForTesting
-  public fun isConfigurationValid(
-      turboModulesEnabled: Boolean,
-      fabricEnabled: Boolean,
-  ): Pair<Boolean, String> =
-      if (!turboModulesEnabled || !fabricEnabled) {
-        false to
-            "You cannot load React Native with the New Architecture disabled. " +
-                "Please use DefaultNewArchitectureEntryPoint.load() instead of " +
-                "DefaultNewArchitectureEntryPoint.load(turboModulesEnabled=$turboModulesEnabled, " +
-                "fabricEnabled=$fabricEnabled)"
-      } else {
-        true to ""
-      }
 }

packages/react-native/ReactAndroid/src/test/java/com/facebook/react/defaults/DefaultNewArchitectureEntryPointTest.kt

@@ -9,7 +9,6 @@ package com.helloworld
 
 import com.facebook.react.ReactActivity
 import com.facebook.react.ReactActivityDelegate
-import com.facebook.react.defaults.DefaultNewArchitectureEntryPoint.fabricEnabled
 import com.facebook.react.defaults.DefaultReactActivityDelegate
 
 class MainActivity : ReactActivity() {
@@ -20,10 +19,7 @@ class MainActivity : ReactActivity() {
    */
   override fun getMainComponentName(): String = "HelloWorld"
 
-  /**
-   * Returns the instance of the [ReactActivityDelegate]. We use [DefaultReactActivityDelegate]
-   * which allows you to enable New Architecture with a single boolean flags [fabricEnabled]
-   */
+  /** Returns the instance of the [ReactActivityDelegate]. We use [DefaultReactActivityDelegate]. */
   override fun createReactActivityDelegate(): ReactActivityDelegate =
-      DefaultReactActivityDelegate(this, mainComponentName, fabricEnabled)
+      DefaultReactActivityDelegate(this, mainComponentName)
 }

private/helloworld/android/app/src/main/java/com/helloworld/MainActivity.kt

@@ -1697,8 +1697,6 @@ interface RCTRootViewFactoryConfiguration : public NSObject {
   public @property (assign) RCTLoadSourceForBridgeBlock loadSourceForBridge;
   public @property (assign) RCTLoadSourceForBridgeWithProgressBlock loadSourceForBridgeWithProgress;
   public @property (assign) RCTSourceURLForBridgeBlock sourceURLForBridge;
-  public @property (assign, readonly) BOOL fabricEnabled;
-  public @property (assign, readonly) BOOL turboModuleEnabled;
   public @property (weak) id<RCTJSRuntimeConfiguratorProtocol> jsRuntimeConfiguratorDelegate;
   public virtual instancetype initWithBundleURL:newArchEnabled:(NSURL* bundleURL, BOOL newArchEnabled);
   public virtual instancetype initWithBundleURLBlock:newArchEnabled:(RCTBundleURLBlock bundleURLBlock, BOOL newArchEnabled);

scripts/cxx-api/api-snapshots/ReactAppleDebugCxx.api

@@ -1696,8 +1696,6 @@ interface RCTRootViewFactoryConfiguration : public NSObject {
   public @property (assign) RCTLoadSourceForBridgeBlock loadSourceForBridge;
   public @property (assign) RCTLoadSourceForBridgeWithProgressBlock loadSourceForBridgeWithProgress;
   public @property (assign) RCTSourceURLForBridgeBlock sourceURLForBridge;
-  public @property (assign, readonly) BOOL fabricEnabled;
-  public @property (assign, readonly) BOOL turboModuleEnabled;
   public @property (weak) id<RCTJSRuntimeConfiguratorProtocol> jsRuntimeConfiguratorDelegate;
   public virtual instancetype initWithBundleURL:newArchEnabled:(NSURL* bundleURL, BOOL newArchEnabled);
   public virtual instancetype initWithBundleURLBlock:newArchEnabled:(RCTBundleURLBlock bundleURLBlock, BOOL newArchEnabled);