Retier react/utils headers (#58842)

Summary:
Pull Request resolved: #58842

Make `Base64.h`, `Uuid.h`, `MoveWrapper.h` and `jsi-utils.h` private, and `SimpleThreadSafeCache.h`, `OnScopeExit.h`, `FloatComparison.h`, `RunLoopObserver.h`, `LowPriorityExecutor.h`, `PackTraits.h`, `TemplateStringLiteral.h` and `iequals.h` for frameworks; drop them from `<React/Utils.h>` and include them directly where they were reached through it. Guard `FollyConvert.h` as public and add it to the umbrella for Objective-C++.

Changelog: [Internal]

Differential Revision: D123383902

Author: j-piasecki

packages/react-native/ReactCommon/jsinspector-modern/ScopedExecutor.h

@@ -10,6 +10,7 @@
 #include <react/cxxstableapi/FrameworksGuard.h>
 
 #include <React/Utils.h>
+#include <react/utils/OnScopeExit.h>
 #include <cassert>
 #include <functional>
 #include <memory>

packages/react-native/ReactCommon/react/renderer/components/text/platform/android/react/renderer/components/text/HostPlatformParagraphProps.cpp

@@ -13,6 +13,7 @@
 #include <react/renderer/core/graphicsConversions.h>
 #include <react/renderer/core/propsConversions.h>
 #include <react/renderer/debug/debugStringConvertibleUtils.h>
+#include <react/utils/FloatComparison.h>
 
 #include <glog/logging.h>
 

packages/react-native/ReactCommon/react/renderer/debug/debugStringConvertibleUtils.h

@@ -14,6 +14,7 @@
 #include <string>
 
 #include <React/Utils.h>
+#include <react/utils/FloatComparison.h>
 #include <react/renderer/debug/DebugStringConvertible.h>
 #include <react/renderer/debug/DebugStringConvertibleItem.h>
 

packages/react-native/ReactCommon/react/renderer/textlayoutmanager/TextMeasureCache.h

@@ -11,6 +11,8 @@
 
 #include <React/RendererCore.h>
 #include <React/Utils.h>
+#include <react/utils/FloatComparison.h>
+#include <react/utils/SimpleThreadSafeCache.h>
 #include <react/renderer/attributedstring/AttributedString.h>
 #include <react/renderer/attributedstring/ParagraphAttributes.h>
 

packages/react-native/ReactCommon/react/renderer/textlayoutmanager/platform/android/react/renderer/textlayoutmanager/TextLayoutManager.h

@@ -11,6 +11,7 @@
 
 #include <React/RendererCore.h>
 #include <React/Utils.h>
+#include <react/utils/SimpleThreadSafeCache.h>
 #include <react/jni/SafeReleaseJniRef.h>
 #include <react/renderer/attributedstring/AttributedStringBox.h>
 #include <react/renderer/attributedstring/ParagraphAttributes.h>

packages/react-native/ReactCommon/react/utils/Base64.h

@@ -7,7 +7,7 @@
 
 #pragma once
 
-#include <react/cxxstableapi/UmbrellaGuard.h>
+#include <react/cxxstableapi/PrivateGuard.h>
 
 #include <string>
 #include <string_view>

packages/react-native/ReactCommon/react/utils/FloatComparison.h

@@ -7,7 +7,7 @@
 
 #pragma once
 
-#include <react/cxxstableapi/UmbrellaGuard.h>
+#include <react/cxxstableapi/FrameworksGuard.h>
 
 #include <cmath>
 

packages/react-native/ReactCommon/react/utils/MoveWrapper.h

@@ -7,7 +7,7 @@
 
 #pragma once
 
-#include <react/cxxstableapi/UmbrellaGuard.h>
+#include <react/cxxstableapi/PrivateGuard.h>
 
 #include <memory>
 

packages/react-native/ReactCommon/react/utils/OnScopeExit.h

@@ -7,7 +7,7 @@
 
 #pragma once
 
-#include <react/cxxstableapi/UmbrellaGuard.h>
+#include <react/cxxstableapi/FrameworksGuard.h>
 
 #include <utility>
 

packages/react-native/ReactCommon/react/utils/React/Utils.h

@@ -30,27 +30,23 @@
 #undef RN_UMBRELLA_CONTEXT
 #define RN_UMBRELLA_CONTEXT 1
 
-#include <react/utils/Base64.h>
 #include <react/utils/ContextContainer.h>
-#include <react/utils/FloatComparison.h>
-#include <react/utils/LowPriorityExecutor.h>
 #include <react/utils/ManagedObjectWrapper.h>
-#include <react/utils/MoveWrapper.h>
-#include <react/utils/OnScopeExit.h>
 #include <react/utils/PackTraits.h>
 #include <react/utils/ReactNativeVersion.h>
-#include <react/utils/RunLoopObserver.h>
 #include <react/utils/SharedFunction.h>
-#include <react/utils/SimpleThreadSafeCache.h>
 #include <react/utils/Telemetry.h>
 #include <react/utils/TemplateStringLiteral.h>
-#include <react/utils/Uuid.h>
 #include <react/utils/fnv1a.h>
 #include <react/utils/hash_combine.h>
 #include <react/utils/iequals.h>
-#include <react/utils/jsi-utils.h>
 #include <react/utils/toLower.h>
 #include <react/utils/to_underlying.h>
 
+// Only shipped on Apple platforms, and only usable from Objective-C++.
+#if defined(__OBJC__) && defined(__cplusplus) && __has_include(<react/utils/FollyConvert.h>)
+#include <react/utils/FollyConvert.h>
+#endif
+
 #undef RN_UMBRELLA_CONTEXT
 #pragma pop_macro("RN_UMBRELLA_CONTEXT")