Make StackTraceParser.h private in jserrorhandler (#58793)

Summary:
Pull Request resolved: #58793

`StackTraceParser` is an implementation detail of `JsErrorHandler`: it is only used by `JsErrorHandler.cpp` and its own unit test, and `JsErrorHandler.h` does not include it. Mark it as a private header instead of a for-frameworks one.

- Swap `FrameworksGuard.h` for `PrivateGuard.h` in `StackTraceParser.h`.
- Include `JsErrorHandler.h` via its namespaced path so the header resolves when it is not exported alongside it.
- Stop shipping `StackTraceParser.h` as a header for prebuilt `React-jserrorhandler` pods.

Changelog: [Internal]

Reviewed By: cipolleschi

Differential Revision: D122770464

fbshipit-source-id: fb51d85fcd52f18cf1254c873b94bef89c8a2a6f

Author: coado

packages/react-native/ReactCommon/jserrorhandler/React-jserrorhandler.podspec

@@ -34,7 +34,7 @@ Pod::Spec.new do |s|
   s.platforms              = min_supported_versions
   s.source                 = source
   s.header_dir             = "jserrorhandler"
-  s.source_files           = podspec_sources(["ErrorUtils.{cpp,h}", "JsErrorHandler.{cpp,h}", "StackTraceParser.{cpp,h}"], ["ErrorUtils.h", "JsErrorHandler.h", "StackTraceParser.h"])
+  s.source_files           = podspec_sources(["ErrorUtils.{cpp,h}", "JsErrorHandler.{cpp,h}", "StackTraceParser.{cpp,h}"], ["ErrorUtils.h", "JsErrorHandler.h"])
   s.pod_target_xcconfig = {
     "HEADER_SEARCH_PATHS" => header_search_paths.join(' '),
     "USE_HEADERMAP" => "YES",

packages/react-native/ReactCommon/jserrorhandler/StackTraceParser.h

@@ -7,11 +7,11 @@
 
 #pragma once
 
-#include <react/cxxstableapi/FrameworksGuard.h>
+#include <react/cxxstableapi/PrivateGuard.h>
 
+#include <jserrorhandler/JsErrorHandler.h>
 #include <string>
 #include <vector>
-#include "JsErrorHandler.h"
 
 namespace facebook::react {
 

scripts/cxx-api/api-snapshots/ReactAndroidFrameworksCxx.api

@@ -3757,10 +3757,6 @@ class facebook::react::SharedColor {
   public std::string toString() const noexcept;
 }
 
-class facebook::react::StackTraceParser {
-  public static std::vector<facebook::react::JsErrorHandler::ProcessedError::StackFrame> parse(bool isHermes, const std::string& stackString);
-}
-
 class facebook::react::State {
   protected State(facebook::react::StateData::Shared data, const facebook::react::State& previousState);
   protected State(facebook::react::StateData::Shared data, facebook::react::ShadowNodeFamily::Weak family);

scripts/cxx-api/api-snapshots/ReactAppleFrameworksCxx.api

@@ -5973,10 +5973,6 @@ class facebook::react::SharedColor {
   public std::string toString() const noexcept;
 }
 
-class facebook::react::StackTraceParser {
-  public static std::vector<facebook::react::JsErrorHandler::ProcessedError::StackFrame> parse(bool isHermes, const std::string& stackString);
-}
-
 class facebook::react::State {
   protected State(facebook::react::StateData::Shared data, const facebook::react::State& previousState);
   protected State(facebook::react::StateData::Shared data, facebook::react::ShadowNodeFamily::Weak family);

scripts/cxx-api/api-snapshots/ReactCommonFrameworksCxx.api

@@ -2352,10 +2352,6 @@ class facebook::react::SharedColor {
   public std::string toString() const noexcept;
 }
 
-class facebook::react::StackTraceParser {
-  public static std::vector<facebook::react::JsErrorHandler::ProcessedError::StackFrame> parse(bool isHermes, const std::string& stackString);
-}
-
 class facebook::react::State {
   protected State(facebook::react::StateData::Shared data, const facebook::react::State& previousState);
   protected State(facebook::react::StateData::Shared data, facebook::react::ShadowNodeFamily::Weak family);