Skip to content

Commit 3488e06

Browse files
coadofacebook-github-bot
authored andcommitted
Classify RCTTurboModuleManager.h as for-frameworks (#58948)
Summary: Add the for-frameworks guard to the iOS `RCTTurboModuleManager.h`. `RCTTurboModuleManager` creates and owns TurboModules for a host, and `RCTTurboModuleManagerDelegate` is the protocol a host implements to supply them. That is host-integration API, in the same tier as `RCTHost.h` and `RCTInstance.h`, which are already for-frameworks: the app factory delegate in `RCTReactNativeFactory.h` adopts both `RCTHostDelegate` and `RCTTurboModuleManagerDelegate`, and imports both headers. Changelog: [Internal] Differential Revision: D124079995
1 parent 8d658f4 commit 3488e06

4 files changed

Lines changed: 2 additions & 42 deletions

File tree

‎packages/react-native/ReactCommon/react/nativemodule/core/platform/ios/ReactCommon/RCTTurboModuleManager.h‎

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -7,6 +7,8 @@
77

88
#pragma once
99

10+
#include <react/cxxstableapi/FrameworksGuard.h>
11+
1012
#import <memory>
1113

1214
#import <React/NativeModuleCore.h>

‎scripts/cxx-api/api-snapshots/ReactAppleDebugCxx.api‎

Lines changed: 0 additions & 14 deletions
Original file line numberDiff line numberDiff line change
@@ -1939,12 +1939,6 @@ interface RCTTransformAnimatedNode : public RCTAnimatedNode {
19391939
public virtual NSDictionary<NSString*, NSObject*>* propsDictionary();
19401940
}
19411941

1942-
interface RCTTurboModuleManager : public NSObject <RCTTurboModuleRegistry> {
1943-
public virtual instancetype initWithBridgeProxy:bridgeModuleDecorator:delegate:jsInvoker:devMenuConfigurationDecorator:(RCTBridgeProxy* bridgeProxy, RCTBridgeModuleDecorator* bridgeModuleDecorator, id<RCTTurboModuleManagerDelegate> delegate, std::shared_ptr<facebook::react::CallInvoker> jsInvoker, RCTDevMenuConfigurationDecorator* devMenuConfigurationDecorator);
1944-
public virtual void installJSBindings:(facebook::jsi::Runtime& runtime);
1945-
public virtual void invalidate();
1946-
}
1947-
19481942
interface RCTUIImageViewAnimated : public UIImageView {
19491943
}
19501944

@@ -2967,14 +2961,6 @@ protocol RCTTurboModule : public RCTModuleProvider {
29672961
public virtual void setEventEmitterCallback:(EventEmitterCallbackWrapper* eventEmitterCallbackWrapper);
29682962
}
29692963

2970-
protocol RCTTurboModuleManagerDelegate : public NSObject {
2971-
public virtual Class getModuleClassFromName:(const char* name);
2972-
public virtual NSArray<id<RCTBridgeModule>>* extraModulesForBridge:((deprecated("Please make all native modules returned from this method TurboModule-compatible.")) __attribute);
2973-
public virtual id<RCTModuleProvider> getModuleProvider:(const char* name);
2974-
public virtual id<RCTTurboModule> getModuleInstanceFromClass:(Class moduleClass);
2975-
public virtual std::shared_ptr<facebook::react::TurboModule> getTurboModule:jsInvoker:(const std::string& name, std::shared_ptr<facebook::react::CallInvoker> jsInvoker);
2976-
}
2977-
29782964
protocol RCTTurboModuleRegistry : public NSObject {
29792965
public virtual BOOL moduleIsInitialized:(const char* moduleName);
29802966
public virtual id moduleForName:(const char* moduleName);

‎scripts/cxx-api/api-snapshots/ReactAppleNewarchCxx.api‎

Lines changed: 0 additions & 14 deletions
Original file line numberDiff line numberDiff line change
@@ -1932,12 +1932,6 @@ interface RCTTransformAnimatedNode : public RCTAnimatedNode {
19321932
public virtual NSDictionary<NSString*, NSObject*>* propsDictionary();
19331933
}
19341934

1935-
interface RCTTurboModuleManager : public NSObject <RCTTurboModuleRegistry> {
1936-
public virtual instancetype initWithBridgeProxy:bridgeModuleDecorator:delegate:jsInvoker:devMenuConfigurationDecorator:(RCTBridgeProxy* bridgeProxy, RCTBridgeModuleDecorator* bridgeModuleDecorator, id<RCTTurboModuleManagerDelegate> delegate, std::shared_ptr<facebook::react::CallInvoker> jsInvoker, RCTDevMenuConfigurationDecorator* devMenuConfigurationDecorator);
1937-
public virtual void installJSBindings:(facebook::jsi::Runtime& runtime);
1938-
public virtual void invalidate();
1939-
}
1940-
19411935
interface RCTUIImageViewAnimated : public UIImageView {
19421936
}
19431937

@@ -2959,14 +2953,6 @@ protocol RCTTurboModule : public RCTModuleProvider {
29592953
public virtual void setEventEmitterCallback:(EventEmitterCallbackWrapper* eventEmitterCallbackWrapper);
29602954
}
29612955

2962-
protocol RCTTurboModuleManagerDelegate : public NSObject {
2963-
public virtual Class getModuleClassFromName:(const char* name);
2964-
public virtual NSArray<id<RCTBridgeModule>>* extraModulesForBridge:((deprecated("Please make all native modules returned from this method TurboModule-compatible.")) __attribute);
2965-
public virtual id<RCTModuleProvider> getModuleProvider:(const char* name);
2966-
public virtual id<RCTTurboModule> getModuleInstanceFromClass:(Class moduleClass);
2967-
public virtual std::shared_ptr<facebook::react::TurboModule> getTurboModule:jsInvoker:(const std::string& name, std::shared_ptr<facebook::react::CallInvoker> jsInvoker);
2968-
}
2969-
29702956
protocol RCTTurboModuleRegistry : public NSObject {
29712957
public virtual BOOL moduleIsInitialized:(const char* moduleName);
29722958
public virtual id moduleForName:(const char* moduleName);

‎scripts/cxx-api/api-snapshots/ReactAppleReleaseCxx.api‎

Lines changed: 0 additions & 14 deletions
Original file line numberDiff line numberDiff line change
@@ -1939,12 +1939,6 @@ interface RCTTransformAnimatedNode : public RCTAnimatedNode {
19391939
public virtual NSDictionary<NSString*, NSObject*>* propsDictionary();
19401940
}
19411941

1942-
interface RCTTurboModuleManager : public NSObject <RCTTurboModuleRegistry> {
1943-
public virtual instancetype initWithBridgeProxy:bridgeModuleDecorator:delegate:jsInvoker:devMenuConfigurationDecorator:(RCTBridgeProxy* bridgeProxy, RCTBridgeModuleDecorator* bridgeModuleDecorator, id<RCTTurboModuleManagerDelegate> delegate, std::shared_ptr<facebook::react::CallInvoker> jsInvoker, RCTDevMenuConfigurationDecorator* devMenuConfigurationDecorator);
1944-
public virtual void installJSBindings:(facebook::jsi::Runtime& runtime);
1945-
public virtual void invalidate();
1946-
}
1947-
19481942
interface RCTUIImageViewAnimated : public UIImageView {
19491943
}
19501944

@@ -2967,14 +2961,6 @@ protocol RCTTurboModule : public RCTModuleProvider {
29672961
public virtual void setEventEmitterCallback:(EventEmitterCallbackWrapper* eventEmitterCallbackWrapper);
29682962
}
29692963

2970-
protocol RCTTurboModuleManagerDelegate : public NSObject {
2971-
public virtual Class getModuleClassFromName:(const char* name);
2972-
public virtual NSArray<id<RCTBridgeModule>>* extraModulesForBridge:((deprecated("Please make all native modules returned from this method TurboModule-compatible.")) __attribute);
2973-
public virtual id<RCTModuleProvider> getModuleProvider:(const char* name);
2974-
public virtual id<RCTTurboModule> getModuleInstanceFromClass:(Class moduleClass);
2975-
public virtual std::shared_ptr<facebook::react::TurboModule> getTurboModule:jsInvoker:(const std::string& name, std::shared_ptr<facebook::react::CallInvoker> jsInvoker);
2976-
}
2977-
29782964
protocol RCTTurboModuleRegistry : public NSObject {
29792965
public virtual BOOL moduleIsInitialized:(const char* moduleName);
29802966
public virtual id moduleForName:(const char* moduleName);

0 commit comments

Comments
 (0)