Delete dead per-module RCTBridge accessors

Summary:
Five module accessors on `RCTBridge` (`networking`, `webSocketModule`, `accessibilityManager`, `devSettings`, `imageStoreManager`) have no callers. Delete the bridge-side declarations and the last bridge-side implementation (`uiManager`, whose proxy implementation stays). Deprecate `devMenu`, which external clients still use.

Changelog:
[iOS][Removed] - Remove unused per-module `RCTBridge` accessors

Differential Revision: D127294783

Author: christophpurrer

packages/react-native/Libraries/Image/RCTImageStoreManager.h

@@ -40,12 +40,6 @@
 
 @end
 
-@interface RCTBridge (RCTImageStoreManager)
-
-@property (nonatomic, readonly) RCTImageStoreManager *imageStoreManager;
-
-@end
-
 @interface RCTBridgeProxy (RCTImageStoreManager)
 
 @property (nonatomic, readonly) RCTImageStoreManager *imageStoreManager;

packages/react-native/Libraries/Network/RCTNetworking.h

@@ -61,12 +61,6 @@
 
 @end
 
-@interface RCTBridge (RCTNetworking)
-
-@property (nonatomic, readonly) RCTNetworking *networking;
-
-@end
-
 @interface RCTBridgeProxy (RCTNetworking)
 
 @property (nonatomic, readonly) RCTNetworking *networking;

packages/react-native/React/CoreModules/RCTAccessibilityManager.h

@@ -32,12 +32,6 @@ extern NSString *const RCTAccessibilityManagerDidUpdateMultiplierNotification; /
 
 @end
 
-@interface RCTBridge (RCTAccessibilityManager)
-
-@property (nonatomic, readonly) RCTAccessibilityManager *accessibilityManager;
-
-@end
-
 @interface RCTBridgeProxy (RCTAccessibilityManager)
 
 @property (nonatomic, readonly) RCTAccessibilityManager *accessibilityManager;

packages/react-native/React/CoreModules/RCTDevMenu.h

@@ -137,7 +137,8 @@ typedef NSString * (^RCTDevMenuItemTitleBlock)(void);
  */
 @interface RCTBridge (RCTDevMenu)
 
-@property (nonatomic, readonly) RCTDevMenu *devMenu;
+@property (nonatomic, readonly) RCTDevMenu *devMenu __deprecated_msg(
+    "Access RCTDevMenu through the bridge proxy instead; this accessor will be removed.");
 
 @end
 

packages/react-native/React/CoreModules/RCTDevSettings.h

@@ -142,12 +142,6 @@ typedef void (^RCTConnectedHandler)(void);
 
 @end
 
-@interface RCTBridge (RCTDevSettings)
-
-@property (nonatomic, readonly) RCTDevSettings *devSettings;
-
-@end
-
 @interface RCTBridgeProxy (RCTDevSettings)
 
 @property (nonatomic, readonly) RCTDevSettings *devSettings;

packages/react-native/React/CoreModules/RCTWebSocketModule.h

@@ -33,12 +33,6 @@ RCT_EXTERN void RCTSetCustomSRWebSocketProvider(SRWebSocketProvider provider);
 
 @end
 
-@interface RCTBridge (RCTWebSocketModule)
-
-- (RCTWebSocketModule *)webSocketModule;
-
-@end
-
 @interface RCTBridgeProxy (RCTWebSocketModule)
 
 - (RCTWebSocketModule *)webSocketModule;

packages/react-native/React/Modules/RCTUIManager.mm

@@ -220,15 +220,6 @@ - (void)invalidate
 
 @end
 
-@implementation RCTBridge (RCTUIManager)
-
-- (RCTUIManager *)uiManager
-{
-  return [self moduleForClass:[RCTUIManager class]];
-}
-
-@end
-
 UIView *RCTPaperViewOrCurrentView(UIView *view)
 {
   if ([view respondsToSelector:@selector(paperView)]) {

scripts/cxx-api/api-snapshots/ReactAppleDebugCxx.api

@@ -5,18 +5,10 @@ category NSTextStorage(FontScaling) {
   public virtual void scaleFontSizeWithRatio:minimumFontSize:maximumFontSize:(CGFloat ratio, CGFloat minimumFontSize, CGFloat maximumFontSize);
 }
 
-category RCTBridge(RCTAccessibilityManager) {
-  public @property (assign, readonly) RCTAccessibilityManager* accessibilityManager;
-}
-
 category RCTBridge(RCTDevMenu) {
   public @property (assign, readonly) RCTDevMenu* devMenu;
 }
 
-category RCTBridge(RCTDevSettings) {
-  public @property (assign, readonly) RCTDevSettings* devSettings;
-}
-
 category RCTBridge(RCTEventDispatcher) {
   public virtual id<RCTEventDispatcherProtocol> eventDispatcher();
 }
@@ -25,22 +17,10 @@ category RCTBridge(RCTImageLoader) {
   public @property (assign, readonly) RCTImageLoader* imageLoader;
 }
 
-category RCTBridge(RCTImageStoreManager) {
-  public @property (assign, readonly) RCTImageStoreManager* imageStoreManager;
-}
-
-category RCTBridge(RCTNetworking) {
-  public @property (assign, readonly) RCTNetworking* networking;
-}
-
 category RCTBridge(RCTUIManager) {
   public @property (assign, readonly) RCTUIManager* uiManager;
 }
 
-category RCTBridge(RCTWebSocketModule) {
-  public virtual RCTWebSocketModule* webSocketModule();
-}
-
 category RCTBridgeProxy(Cxx) {
   public @property (assign) std::shared_ptr<facebook::react::CallInvoker> jsCallInvoker;
 }

scripts/cxx-api/api-snapshots/ReactAppleFrameworksCxx.api

@@ -5,18 +5,10 @@ category NSTextStorage(FontScaling) {
   public virtual void scaleFontSizeWithRatio:minimumFontSize:maximumFontSize:(CGFloat ratio, CGFloat minimumFontSize, CGFloat maximumFontSize);
 }
 
-category RCTBridge(RCTAccessibilityManager) {
-  public @property (assign, readonly) RCTAccessibilityManager* accessibilityManager;
-}
-
 category RCTBridge(RCTDevMenu) {
   public @property (assign, readonly) RCTDevMenu* devMenu;
 }
 
-category RCTBridge(RCTDevSettings) {
-  public @property (assign, readonly) RCTDevSettings* devSettings;
-}
-
 category RCTBridge(RCTEventDispatcher) {
   public virtual id<RCTEventDispatcherProtocol> eventDispatcher();
 }
@@ -25,22 +17,10 @@ category RCTBridge(RCTImageLoader) {
   public @property (assign, readonly) RCTImageLoader* imageLoader;
 }
 
-category RCTBridge(RCTImageStoreManager) {
-  public @property (assign, readonly) RCTImageStoreManager* imageStoreManager;
-}
-
-category RCTBridge(RCTNetworking) {
-  public @property (assign, readonly) RCTNetworking* networking;
-}
-
 category RCTBridge(RCTUIManager) {
   public @property (assign, readonly) RCTUIManager* uiManager;
 }
 
-category RCTBridge(RCTWebSocketModule) {
-  public virtual RCTWebSocketModule* webSocketModule();
-}
-
 category RCTBridgeProxy(Cxx) {
   public @property (assign) std::shared_ptr<facebook::react::CallInvoker> jsCallInvoker;
 }

scripts/cxx-api/api-snapshots/ReactAppleNewarchCxx.api

@@ -5,18 +5,10 @@ category NSTextStorage(FontScaling) {
   public virtual void scaleFontSizeWithRatio:minimumFontSize:maximumFontSize:(CGFloat ratio, CGFloat minimumFontSize, CGFloat maximumFontSize);
 }
 
-category RCTBridge(RCTAccessibilityManager) {
-  public @property (assign, readonly) RCTAccessibilityManager* accessibilityManager;
-}
-
 category RCTBridge(RCTDevMenu) {
   public @property (assign, readonly) RCTDevMenu* devMenu;
 }
 
-category RCTBridge(RCTDevSettings) {
-  public @property (assign, readonly) RCTDevSettings* devSettings;
-}
-
 category RCTBridge(RCTEventDispatcher) {
   public virtual id<RCTEventDispatcherProtocol> eventDispatcher();
 }
@@ -25,22 +17,10 @@ category RCTBridge(RCTImageLoader) {
   public @property (assign, readonly) RCTImageLoader* imageLoader;
 }
 
-category RCTBridge(RCTImageStoreManager) {
-  public @property (assign, readonly) RCTImageStoreManager* imageStoreManager;
-}
-
-category RCTBridge(RCTNetworking) {
-  public @property (assign, readonly) RCTNetworking* networking;
-}
-
 category RCTBridge(RCTUIManager) {
   public @property (assign, readonly) RCTUIManager* uiManager;
 }
 
-category RCTBridge(RCTWebSocketModule) {
-  public virtual RCTWebSocketModule* webSocketModule();
-}
-
 category RCTBridgeProxy(Cxx) {
   public @property (assign) std::shared_ptr<facebook::react::CallInvoker> jsCallInvoker;
 }