Save Maestro debug output for iOS E2E flows

Drop the android-release-only skip: the failing flow needs to run so its
debug output can show where Maestro taps. Write each attempt's debug
output to its own folder under /tmp/MaestroLogs, which the maestro-ios
action already uploads on failure.

Author: cipolleschi

.github/actions/maestro-ios/action.yml

@@ -26,10 +26,6 @@ inputs:
     required: false
     default: ''
     description: Maestro device OS name, such as iOS-26-2
-  exclude-tags:
-    required: false
-    default: ''
-    description: Comma-separated flow tags to exclude from the test run
 
 runs:
   using: composite
@@ -77,8 +73,7 @@ runs:
           "${{ inputs.flavor }}" \
           "${{ inputs.working-directory }}" \
           "${{ inputs.device-model }}" \
-          "${{ inputs.device-os }}" \
-          "${{ inputs.exclude-tags }}"
+          "${{ inputs.device-os }}"
     - name: Store video record
       if: always()
       uses: ./.github/actions/upload-artifact

.github/workflow-scripts/__tests__/maestro-ios-test.js

@@ -14,7 +14,6 @@ jest.mock('child_process', () => ({
 jest.mock('fs', () => ({
   existsSync: jest.fn(),
   lstatSync: jest.fn(),
-  readFileSync: jest.fn(),
   readdirSync: jest.fn(),
 }));
 
@@ -56,29 +55,6 @@ describe('Maestro iOS runner', () => {
     );
   });
 
-  it('skips flows with excluded tags', async () => {
-    jest.spyOn(console, 'info').mockImplementation(() => {});
-    fs.existsSync.mockReturnValue(true);
-    fs.lstatSync.mockImplementation(path => ({
-      isDirectory: () => path === 'flows/',
-    }));
-    fs.readdirSync.mockReturnValue(['excluded.yml', 'regular.yml']);
-    fs.readFileSync.mockImplementation(path =>
-      path === 'flows/excluded.yml'
-        ? 'appId: x\ntags:\n  - android-release-only\n---\n- launchApp\n'
-        : 'appId: x\n---\n- launchApp\n',
-    );
-
-    await executeFlows('com.example', 'device-id', 'flows/', 'Hermes', [
-      'android-release-only',
-    ]);
-
-    expect(childProcess.execSync).toHaveBeenCalledTimes(1);
-    expect(childProcess.execSync.mock.calls[0][0]).toContain(
-      'test "flows/regular.yml"',
-    );
-  });
-
   it('retries only the failing flow', async () => {
     fs.existsSync.mockReturnValue(false);
     childProcess.execSync.mockImplementationOnce(() => {

.github/workflow-scripts/maestro-ios.js

@@ -9,11 +9,11 @@
 
 const childProcess = require('child_process');
 const fs = require('fs');
-const {filterFlowsByTags} = require('./maestro-android');
+const path = require('path');
 
 const usage = `
 === Usage ===
-node maestro-ios.js <path to app> <app_id> <maestro_flow> <jsengine> <flavor> <working_directory> [device_model] [device_os] [exclude_tags]
+node maestro-ios.js <path to app> <app_id> <maestro_flow> <jsengine> <flavor> <working_directory> [device_model] [device_os]
 
 @param {string} appPath - Path to the app APK
 @param {string} appId - App ID that needs to be launched
@@ -23,11 +23,11 @@ node maestro-ios.js <path to app> <app_id> <maestro_flow> <jsengine> <flavor> <w
 @param {string} workingDirectory - Working directory from where to run Metro
 @param {string} deviceModel - Optional Maestro device model, such as iPhone-17-Pro
 @param {string} deviceOS - Optional Maestro device OS, such as iOS-26-2
-@param {string} excludeTags - Optional comma-separated flow tags to exclude
 ==============
 `;
 
 const MAX_ATTEMPTS = 5;
+const MAESTRO_LOG_DIRECTORY = '/tmp/MaestroLogs';
 
 function findAvailableSimulator(deviceModel, deviceOS) {
   const output = childProcess.execSync(
@@ -187,7 +187,14 @@ async function executeFlowWithRetries(
   const recProcess = startVideoRecording(udid, currentAttempt);
   try {
     const timeout = 1000 * 60 * 10; // 10 minutes
-    const command = `$HOME/.maestro/bin/maestro --udid="${udid}" test "${flow}" --format junit -e APP_ID="${appId}"`;
+    // Keep each attempt's commands, screenshots, and logs; retries would
+    // otherwise overwrite them.
+    const debugOutput = path.join(
+      MAESTRO_LOG_DIRECTORY,
+      path.basename(flow, path.extname(flow)),
+      `attempt-${currentAttempt}`,
+    );
+    const command = `$HOME/.maestro/bin/maestro --udid="${udid}" test "${flow}" --format junit -e APP_ID="${appId}" --debug-output "${debugOutput}"`;
     console.info(`Executing flow: ${flow} (attempt ${currentAttempt})`);
     console.log(command);
     childProcess.execSync(`MAESTRO_DRIVER_STARTUP_TIMEOUT=1500000 ${command}`, {
@@ -217,13 +224,7 @@ async function executeFlowWithRetries(
   }
 }
 
-async function executeFlows(
-  appId,
-  udid,
-  maestroFlow,
-  jsengine,
-  excludeTags = [],
-) {
+async function executeFlows(appId, udid, maestroFlow, jsengine) {
   if (!fs.existsSync(maestroFlow) || !fs.lstatSync(maestroFlow).isDirectory()) {
     await executeFlowWithRetries(appId, udid, maestroFlow, jsengine, 1);
     return;
@@ -237,18 +238,15 @@ async function executeFlows(
       if (file === 'helpers') {
         continue;
       }
-      await executeFlows(appId, udid, filePath, jsengine, excludeTags);
+      await executeFlows(appId, udid, filePath, jsengine);
     } else if (file.endsWith('.yml') || file.endsWith('.yaml')) {
-      if (filterFlowsByTags([filePath], excludeTags).length === 0) {
-        continue;
-      }
       await executeFlowWithRetries(appId, udid, filePath, jsengine, 1);
     }
   }
 }
 
 async function main(args = process.argv.slice(2)) {
-  if (args.length < 6 || args.length > 9) {
+  if (args.length < 6 || args.length > 8) {
     throw new Error(`Invalid number of arguments.\n${usage}`);
   }
 
@@ -260,10 +258,6 @@ async function main(args = process.argv.slice(2)) {
   const workingDirectory = args[5];
   const deviceModel = args[6] || null;
   const deviceOS = args[7] || null;
-  const excludeTags = (args[8] ?? '')
-    .split(',')
-    .map(tag => tag.trim())
-    .filter(Boolean);
 
   console.info('\n==============================');
   console.info('Running tests for iOS with the following parameters:');
@@ -275,15 +269,14 @@ async function main(args = process.argv.slice(2)) {
   console.info(`WORKING_DIRECTORY: ${workingDirectory}`);
   console.info(`DEVICE_MODEL: ${deviceModel ?? '<automatic>'}`);
   console.info(`DEVICE_OS: ${deviceOS ?? '<automatic>'}`);
-  console.info(`EXCLUDE_TAGS: ${excludeTags.join(',') || '<none>'}`);
   console.info('==============================\n');
 
   const simulator = findAvailableSimulator(deviceModel, deviceOS);
   launchSimulator(simulator);
   installAppOnSimulator(appPath, simulator.udid);
   bringSimulatorInForeground();
   await launchAppOnSimulator(appId, simulator.udid, isDebug);
-  await executeFlows(appId, simulator.udid, maestroFlow, jsengine, excludeTags);
+  await executeFlows(appId, simulator.udid, maestroFlow, jsengine);
   console.log('Test finished');
 }
 

.github/workflows/e2e-ios-rntester.yml

@@ -46,9 +46,6 @@ jobs:
           flavor: ${{ matrix.flavor }}
           device-model: iPhone-17-Pro
           device-os: iOS-26-2
-          # The maintainVisibleContentPosition flows fail on iOS since the
-          # RNTester tab bar inset change in #58900. Skip them until it's fixed.
-          exclude-tags: android-release-only
       - name: Report status
         id: report-status
         if: ${{ always() && steps.run-tests.outcome == 'failure' }}