Remove obsolete Android SDK compatibility shims

Summary:
Use `Build.VERSION_CODES` and the framework window attribute directly for APIs available in the current compile SDK, removing obsolete numeric compatibility shims. Retain only the Android 17 version shim, which is newer than the internal compile SDK.

Remove a stale `DisplayMetrics` dependency that pulled edge-to-edge window code into unrelated consumers.

Changelog:
[Internal]

Differential Revision: D122209144

Author: Abbondanzo

packages/react-native/ReactAndroid/build.gradle.kts

@@ -584,11 +584,9 @@ android {
     minSdk = libs.versions.minSdk.get().toInt()
 
     aarMetadata {
-      // RN's public ABI exposes no android API newer than 34, and the source is written to
-      // compile against SDK 34 (see util/AndroidVersion.kt). compileSdk is 36 only to build
-      // against the latest platform — it is not an API requirement. Without this, AGP 9
-      // defaults minCompileSdk to compileSdk (36), needlessly forcing every consuming
-      // library/app to compileSdk 36.
+      // RN's public ABI exposes no Android API newer than 34, so consumers do not need to
+      // match ReactAndroid's compile SDK. Without this, AGP 9 defaults minCompileSdk to
+      // compileSdk, needlessly forcing every consuming library/app to use the same SDK.
       minCompileSdk = 34
     }
 

packages/react-native/ReactAndroid/src/main/java/com/facebook/react/util/AndroidVersion.kt

@@ -14,48 +14,18 @@ import android.os.Build
 internal object AndroidVersion {
 
   /**
-   * This is the version code for Android 15 (SDK Level 35). Internally at Meta this code is also
-   * compiled against SDK 34, so we need to retain this constant instead of using
-   * [Build.VERSION_CODES.VANILLA_ICE_CREAM] directly.
-   */
-  internal const val VERSION_CODE_VANILLA_ICE_CREAM: Int = 35
-
-  /**
-   * This is the version code for Android 16 (SDK Level 36). Internally at Meta this code is also
-   * compiled against SDK 34, so we need to retain this constant instead of using
-   * [Build.VERSION_CODES.BAKLAVA] directly.
-   */
-  internal const val VERSION_CODE_BAKLAVA: Int = 36
-
-  /**
-   * This is the version code for Android 17 (SDK Level 37). Internally at Meta this code is also
-   * compiled against SDK 34, so we need to retain this constant instead of using
+   * This is the version code for Android 17 (SDK Level 37). Internally at Meta this code is
+   * compiled against SDK 36, so we need to retain this constant instead of using
    * [Build.VERSION_CODES.CINNAMON_BUN] directly.
    */
   internal const val VERSION_CODE_CINNAMON_BUN: Int = 37
 
-  /**
-   * android.R.attr.windowOptOutEdgeToEdgeEnforcement added in API 35. Internally at Meta this code
-   * is compiled against an SDK that may not have this attribute defined.
-   * https://cs.android.com/android/platform/superproject/main/+/main:frameworks/base/core/res/res/values/public-final.xml;l=3848
-   */
-  internal const val ATTR_WINDOW_OPT_OUT_EDGE_TO_EDGE_ENFORCEMENT: Int = 0x0101069a
-
-  /**
-   * This method is used to check if the current device is running Android 15 (SDK Level 35) or
-   * higher and the app is targeting Android 15 (SDK Level 35) or higher.
-   */
-  @JvmStatic
-  internal fun isAtLeastTargetSdk35(context: Context): Boolean =
-      Build.VERSION.SDK_INT >= VERSION_CODE_VANILLA_ICE_CREAM &&
-          context.applicationInfo.targetSdkVersion >= VERSION_CODE_VANILLA_ICE_CREAM
-
   /**
    * This method is used to check if the current device is running Android 16 (SDK Level 36) or
    * higher and the app is targeting Android 16 (SDK Level 36) or higher.
    */
   @JvmStatic
   fun isAtLeastTargetSdk36(context: Context): Boolean =
-      Build.VERSION.SDK_INT >= VERSION_CODE_BAKLAVA &&
-          context.applicationInfo.targetSdkVersion >= VERSION_CODE_BAKLAVA
+      Build.VERSION.SDK_INT >= Build.VERSION_CODES.BAKLAVA &&
+          context.applicationInfo.targetSdkVersion >= Build.VERSION_CODES.BAKLAVA
 }

packages/react-native/ReactAndroid/src/main/java/com/facebook/react/views/view/WindowUtil.kt

@@ -45,12 +45,15 @@ public fun setEdgeToEdgeFeatureFlagOn() {
 internal fun updateEdgeToEdgeFeatureFlag(activity: Activity) {
   // When the app targets SDK 35+, edge-to-edge may be enforced by the OS even if the
   // feature flag wasn't explicitly set. In that case, turn the flag on to match.
-  if (AndroidVersion.isAtLeastTargetSdk35(activity)) {
-    if (Build.VERSION.SDK_INT >= AndroidVersion.VERSION_CODE_BAKLAVA) {
+  if (
+      Build.VERSION.SDK_INT >= Build.VERSION_CODES.VANILLA_ICE_CREAM &&
+          activity.applicationInfo.targetSdkVersion >= Build.VERSION_CODES.VANILLA_ICE_CREAM
+  ) {
+    if (Build.VERSION.SDK_INT >= Build.VERSION_CODES.BAKLAVA) {
       // The device is running Android 16+ (where edge-to-edge is always enforced)
       isEdgeToEdgeFeatureFlagOn = true
     } else {
-      val attributes = intArrayOf(AndroidVersion.ATTR_WINDOW_OPT_OUT_EDGE_TO_EDGE_ENFORCEMENT)
+      val attributes = intArrayOf(android.R.attr.windowOptOutEdgeToEdgeEnforcement)
       val typedArray = activity.theme.obtainStyledAttributes(attributes)
 
       // The device is running Android 15 with / without opting out