From c0eeb567263806b845f262362bf9583a0d6d76b1 Mon Sep 17 00:00:00 2001 From: Pavan Kumar Reddy Balireddy Date: Fri, 11 Sep 2026 10:37:46 +0530 Subject: [PATCH 1/3] RDKB-66901 : Webui page with url "mac_ssid==" shows 500 Internal Server Error --- source/Styles/xb3/jst/includes/utility.jst | 6 ++++-- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/source/Styles/xb3/jst/includes/utility.jst b/source/Styles/xb3/jst/includes/utility.jst index db0f48d..e38580c 100644 --- a/source/Styles/xb3/jst/includes/utility.jst +++ b/source/Styles/xb3/jst/includes/utility.jst @@ -1150,8 +1150,10 @@ function cleanJsonDms($dm_key, $param_json) { function getValidatedMacSsidValueJs() { var $mac_ssid_v = ""; - if(isset($_GET['mac_ssid']) && preg_match('/^\d+$/', $_GET['mac_ssid']) == 1) { - $mac_ssid_v = intval($_GET['mac_ssid']); + $mac_ssid_input = isset($_GET['mac_ssid']) ? $_GET['mac_ssid'] : ""; + // Reject array/malformed query values before passing them to preg_match(). + if(!is_array($mac_ssid_input) && preg_match('/^\d+$/', $mac_ssid_input) == 1) { + $mac_ssid_v = intval($mac_ssid_input); if ($mac_ssid_v < 1 || $mac_ssid_v > 17) $mac_ssid_v = ""; else From 962f387fdbdba25aebbaa3fd38fdc58517834643 Mon Sep 17 00:00:00 2001 From: Pavan Kumar Reddy Balireddy Date: Mon, 14 Sep 2026 18:33:54 +0530 Subject: [PATCH 2/3] Only validate scalar query text; arrays and other values must be ignored. --- source/Styles/xb3/jst/includes/utility.jst | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/source/Styles/xb3/jst/includes/utility.jst b/source/Styles/xb3/jst/includes/utility.jst index e38580c..edec4c8 100644 --- a/source/Styles/xb3/jst/includes/utility.jst +++ b/source/Styles/xb3/jst/includes/utility.jst @@ -1151,8 +1151,8 @@ function cleanJsonDms($dm_key, $param_json) { function getValidatedMacSsidValueJs() { var $mac_ssid_v = ""; $mac_ssid_input = isset($_GET['mac_ssid']) ? $_GET['mac_ssid'] : ""; - // Reject array/malformed query values before passing them to preg_match(). - if(!is_array($mac_ssid_input) && preg_match('/^\d+$/', $mac_ssid_input) == 1) { + // Only validate scalar query text; arrays and other values must be ignored. + if(is_string($mac_ssid_input) && preg_match('/^\d+$/', $mac_ssid_input) == 1) { $mac_ssid_v = intval($mac_ssid_input); if ($mac_ssid_v < 1 || $mac_ssid_v > 17) $mac_ssid_v = ""; From 01c6fd000751809b49b50f6e8a7290b6d510a102 Mon Sep 17 00:00:00 2001 From: Pavan Kumar Reddy Balireddy Date: Tue, 15 Sep 2026 13:43:20 +0530 Subject: [PATCH 3/3] validate mac_ssid query input as numeric string --- source/Styles/xb3/jst/includes/utility.jst | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/source/Styles/xb3/jst/includes/utility.jst b/source/Styles/xb3/jst/includes/utility.jst index edec4c8..170fa9d 100644 --- a/source/Styles/xb3/jst/includes/utility.jst +++ b/source/Styles/xb3/jst/includes/utility.jst @@ -1152,7 +1152,7 @@ function getValidatedMacSsidValueJs() { var $mac_ssid_v = ""; $mac_ssid_input = isset($_GET['mac_ssid']) ? $_GET['mac_ssid'] : ""; // Only validate scalar query text; arrays and other values must be ignored. - if(is_string($mac_ssid_input) && preg_match('/^\d+$/', $mac_ssid_input) == 1) { + if((typeof $mac_ssid_input === "string") && preg_match('/^\d+$/', $mac_ssid_input) == 1) { $mac_ssid_v = intval($mac_ssid_input); if ($mac_ssid_v < 1 || $mac_ssid_v > 17) $mac_ssid_v = "";