diff --git a/test/concrete/MockChainDependentOwner.sol b/test/concrete/MockChainDependentOwner.sol index e480369..64f715a 100644 --- a/test/concrete/MockChainDependentOwner.sol +++ b/test/concrete/MockChainDependentOwner.sol @@ -23,6 +23,8 @@ contract MockChainDependentOwner { /// @param ownerOnChain The address to answer on `chainId`. /// @param ownerElsewhere The address to answer everywhere else. /// @param chainId The chain `ownerOnChain` is answered on. + // Answered back verbatim, authorising nothing, and the fuzz callers reach address(0). + //forge-lint: disable-next-line(missing-zero-check) constructor(address ownerOnChain, address ownerElsewhere, uint256 chainId) { iOwnerOnChain = ownerOnChain; iOwnerElsewhere = ownerElsewhere; diff --git a/test/src/concrete/MigrationRegistryApplyMigration.t.sol b/test/src/concrete/MigrationRegistryApplyMigration.t.sol index c80066b..4884566 100644 --- a/test/src/concrete/MigrationRegistryApplyMigration.t.sol +++ b/test/src/concrete/MigrationRegistryApplyMigration.t.sol @@ -921,6 +921,8 @@ contract MigrationRegistryApplyMigrationTest is Test { ); assertEq(sRegistry.applied(writer, namespace, migration), appliedAt); + // The inequality against the block's own moment IS what this asserts. + //forge-lint: disable-next-line(block-timestamp) assertTrue(sRegistry.applied(writer, namespace, migration) != block.timestamp); } diff --git a/test/src/lib/LibRainDeploySnapshot.t.sol b/test/src/lib/LibRainDeploySnapshot.t.sol index 43adf47..2ef446c 100644 --- a/test/src/lib/LibRainDeploySnapshot.t.sol +++ b/test/src/lib/LibRainDeploySnapshot.t.sol @@ -664,7 +664,7 @@ contract LibRainDeploySnapshotTest is Test { /// @param source The snapshot source. /// @param name The constant's name. /// @return The value it holds. - function snapshotBytesConstant(string memory source, string memory name) internal view returns (bytes memory) { + function snapshotBytesConstant(string memory source, string memory name) internal pure returns (bytes memory) { string memory declaration = string.concat("bytes constant ", name, " ="); assertTrue(vm.contains(source, declaration), string.concat("snapshot declares no bytes ", name)); string[] memory afterOpen = vm.split(vm.split(source, declaration)[1], "hex\""); @@ -676,7 +676,7 @@ contract LibRainDeploySnapshotTest is Test { /// @param source The snapshot source. /// @param name The constant's name. /// @return The value it holds. - function snapshotAddressConstant(string memory source, string memory name) internal view returns (address) { + function snapshotAddressConstant(string memory source, string memory name) internal pure returns (address) { string memory declaration = string.concat("address constant ", name, " ="); assertTrue(vm.contains(source, declaration), string.concat("snapshot declares no address ", name)); string[] memory afterOpen = vm.split(vm.split(source, declaration)[1], "address("); @@ -1596,9 +1596,7 @@ contract LibRainDeploySnapshotTest is Test { string memory a = tagOf(aMajor, aMinor, aPatch); string memory b = tagOf(bMajor, bMinor, bPatch); - bool precedes = aMajor != bMajor - ? aMajor < bMajor - : (aMinor != bMinor ? aMinor < bMinor : (aPatch != bPatch ? aPatch < bPatch : false)); + bool precedes = aMajor != bMajor ? aMajor < bMajor : (aMinor != bMinor ? aMinor < bMinor : aPatch < bPatch); assertEq(LibRainDeploySnapshot.tagPrecedes(vm, a, b), precedes); // Strict, so exactly one of the two orderings holds unless they are the